DWM Hackers Unite! Share (or request) dwm patches.

illusionist · 2012-11-09 19:59:54

Unia wrote:

I have updated the whole Pango version, so it's exactly the same as what I use in the XFT version (except for that it uses Pango )
That means, that the statuscolors patch is also (almost) the same. This makes me think the error is in the Pango patch and not in the statuscolors one. I have no idea where to look for it, though, as I found this Pango patch somewhere around the web. I don't even know if I had to modify it.
In case you (illusionist) or anyone else wants the new code to look for themselves, I have updated the Git repo.

Trying to make it work for 6 hours but failed every time. I am out of ideas now. Maybe you or someone else can come up with something. Seems like textnw, drawtext, drawcoloredtext are the problematic areas. Also second to last hunk in (pango) statuscolors patch could be modified by changing the xftcolors array.
I dont know anything other than that . My programming skills are very limited. I read the xlib description online just to understand what is going on in dwm.c .

Now I am laughing on myself .

edit reason: typo

Last edited by illusionist (2012-11-09 20:02:20)

jasonwryan · 2012-11-09 20:08:04

If you are looking for a clean statuscolours patch to apply against tip, use this:
https://pikacode.com/jasonwryan/dwm-pat … tuscolours

Unia · 2012-11-09 20:17:16

^ ^Seems like you and me are on the same level, then I have honestly no idea what's wrong, but I assume it's somewhere in the mix of XFT colors and regular colors..

EDIT: @ jason, didn't mine work? https://github.com/Unia/DWM-XFT/blob/ma … 0-xft.diff

Last edited by Unia (2012-11-09 20:19:27)

illusionist · 2012-11-09 20:19:00

jasonwryan wrote:

If you are looking for a clean statuscolours patch to apply against tip, use this:
https://pikacode.com/jasonwryan/dwm-pat … tuscolours

It looks like this patch is for xft. Actually I am trying to patch dwm 6.0 with pango and statuscolors. Patching works fine but I am not able to get more than 2 colors working.

jasonwryan · 2012-11-09 20:19:34

Your patch is number 5 in your queue, and it seems to include remnants of other patches in it: I didn't look into what they are or do, just removed all the extraneous stuff and applied it against tip to create the diff.

Unia · 2012-11-09 20:21:22

jasonwryan wrote:

Your patch is number 5 in your queue, and it seems to include remnants of other patches in it: I didn't look into what they are or do, just removed all the extraneous stuff and applied it against tip to create the diff.

Ah, obvious. I also linked to my XFT patch, what am I doing?

jasonwryan · 2012-11-09 20:21:23

illusionist wrote:

jasonwryan wrote:
If you are looking for a clean statuscolours patch to apply against tip, use this:
https://pikacode.com/jasonwryan/dwm-pat … tuscolours
It looks like this patch is for xft. Actually I am trying to patch dwm 6.0 with pango and statuscolors. Patching works fine but I am not able to get more than 2 colors working.

Oh, I hadn't been able to follow your part of the thread. Why not just use that patch against tip: forget pango, it is obsolete...

Unia · 2012-11-09 20:25:33

jasonwryan wrote:

forget pango, it is obsolete...

It is? Could you elaborate, or give a link?

illusionist · 2012-11-09 20:27:22

Unia wrote:

^ ^Seems like you and me are on the same level, then I have honestly no idea what's wrong, but I assume it's somewhere in the mix of XFT colors and regular colors..
EDIT: @ jason, didn't mine work? https://github.com/Unia/DWM-XFT/blob/ma … 0-xft.diff

AFAIK the problem is in statuscolors patch . I'll try to merge (xft) statuscolors with pango one. That means I need to learn about pango.h .
My mind is f*d right now. Can not think of anything else.

Last edited by illusionist (2012-11-09 20:29:37)

jasonwryan · 2012-11-09 20:27:44

I should have been clearer: in the context of dwm. Now that Xft is included, the pango patch is obsolete...

Unia · 2012-11-09 20:31:16

jasonwryan wrote:

I should have been clearer: in the context of dwm. Now that Xft is included, the pango patch is obsolete...

Yea, once 6.1 comes out it's a whole different story. I guess I will remove my GitHub repo on Pango then. To be honest I never understood (nor looked into) the difference between XFT and Pango.

illusionist · 2012-11-09 20:33:27

jasonwryan wrote:

Oh, I hadn't been able to follow your part of the thread. Why not just use that patch against tip: forget pango, it is obsolete...

Actually my native language is only supported by pango so xft is not useful for me.

Unia · 2012-11-09 21:05:05

illusionist wrote:

jasonwryan wrote:
Oh, I hadn't been able to follow your part of the thread. Why not just use that patch against tip: forget pango, it is obsolete...
Actually my native language is only supported by pango so xft is not useful for me.

I'm about to delete the Pango repo from my GitHub. I just want to make sure you have a copy. Do you?

illusionist · 2012-11-09 21:12:38

Let me clone it .

EDIT: Cloned ! ... Go ahead .

Last edited by illusionist (2012-11-09 21:14:40)

Unia · 2012-11-09 22:00:43

illusionist wrote:

Let me clone it .
EDIT: Cloned ! ... Go ahead .

Good luck on getting it to work. You're free to send me an email if you want to figure it out together

Unia · 2012-11-09 22:12:53

Pranavg1890 wrote:

Hi Friends, can anyone give me a patch for cyclic selection of windows in tiling mode for dwm 6.0 ? I tried googling but most of the links are dead or the patch is for older versions of dwm.

I was just reading the mailing list when I came across this post:

http://lists.suckless.org/dev/1211/13219.html

Perhaps it's what you're looking for.

EDIT: I just skimmed through the ML, but I didn't see anything on DWM 6.1. Does Suckless do the "when it's ready"-schedule, or am I missing something?

Also, since DWM now comes with XFT by default; does anyone know if Dmenu will too?

Last edited by Unia (2012-11-09 22:18:08)

jasonwryan · 2012-11-09 22:50:57

Unia wrote:

EDIT: I just skimmed through the ML, but I didn't see anything on DWM 6.1. Does Suckless do the "when it's ready"-schedule, or am I missing something?
Also, since DWM now comes with XFT by default; does anyone know if Dmenu will too?

Yes; generally Anselm will post to the list that he is preparing a new release. As a lot of people just use tip, it is not such a big deal.

Re. dmenu: I would imagine it is only a matter of time...

Unia · 2012-11-09 23:11:10

Yea I also just switched to tip thanks for clearing this up Jason!

mjheagle8 · 2012-11-10 01:35:38

Pranavg1890 wrote:

Hi friends, the links are as follows:
https://bitbucket.org/jasonwryan/workst … at=default
https://github.com/mjheagle8/dwm/blob/m … cycle.diff
I don't know if these are the only one's that provide me the required functionality. (I just did a google search and nothing else). also, the link given for cycle at very first post of thread is dead.

I was going to say, one of those links is my github and im using 6.0

but jasonwryan beat me to it

Last edited by mjheagle8 (2012-11-10 01:35:47)

illusionist · 2012-11-10 12:22:24

Unia wrote:

illusionist wrote:
Let me clone it .
EDIT: Cloned ! ... Go ahead .
Good luck on getting it to work. You're free to send me an email if you want to figure it out together

Sure..!
I think I am getting somewhere. I'll let you know.

la11111 · 2012-11-11 09:25:27

hello all, first post! I'm glad to find this thread and that it's recently been updated. Seems like some of you understand the DWM source pretty well.

I'm having an issue with a patch I'm working on, and I wonder if someone here might have some insight.

It's status bar colors patch that lets you use ansi escape codes to specify colors in your status script rather than declaring a bunch of new ones in config.h and mucking around a bunch of color-related stuff in dwm.c - I'm having an minor issue though. The fix is probably simple.

what I do in the patch is - I parse the ansi escape codes out of the input text, then chop the text into blocks and output them one at a time using the colors specified in the escape sequence, using a slightly modified version of the drawtext function.

The issue is - the TEXTW macro doesn't seem to account for the padding that's added on whenever XDrawString is called. So each time you change the color, you get leading & trailing padding on that portion, which is not what I want (see screenshot below - I want the output to be identical to the plaintext output, only colorized, like you'd have in xterm.). But, I can't figure out how to specify this. Or if I should use a different Xlib function.

Here's a screenshot; this is the corner of the screen. The green/black is supposed to be a bar graph - I added the chars in so that you can see the padding issue. The date/time is getting pushed clear off the edge of the screen.

type the following into xterm to see the difference:

python -c "print '\x1b[48;5;46m#\x1b[48;5;233m.....\x1b[0m'"

any suggestions? Thanks,
-la0x1f

illusionist · 2012-11-11 09:56:28

Hello,
I modified the dwm-tip to work with pango and statuscolors. The colors issue is somewhat ( maybe completely ?) resolved. But now the text on my status bar is not updating instead it is getting overridden with the new one.

Image:
http://ompldr.org/vZzhhNQ/bar.png

Patch:
https://github.com/nixmeal/dwm/blob/wor … patch.diff

I think these are the areas to look for (just a suggestion) "drawtext" "textnw" and "initfont" .
Any help would be appreciated .

Last edited by illusionist (2012-11-11 09:58:55)

la11111 · 2012-11-11 10:38:34

illusionist - I'm not sure of the context of what you're trying to do, but - it's because you commented out XFillRectangle in your patch within the drawtext method ... the text doesn't get cleared after you draw it, so the next XDrawString just writes on top of it.

la11111 · 2012-11-11 11:01:08

to post an update regarding my earlier question on the patch I'm writing: I've resolved the issue. Dumb me.

So it works now! woop!

here I dumped a bunch of colors onto it as a test - nothing breaks! I think it's reasonably stable!

I'm pretty stoked - I did this to brush up on my C, and I think it did the trick. I'm using dwm 5.9 right now, but I'll make some patches for the latest few versions and put them up on github.

illusionist · 2012-11-11 11:08:55

la11111 wrote:

illusionist - I'm not sure of the context of what you're trying to do, but - it's because you commented out XFillRectangle in your patch within the drawtext method ... the text doesn't get cleared after you draw it, so the next XDrawString just writes on top of it.

Hey thank you man and welcome to the forum.
Actually the status colors patch was not working properly with pango (showing only 2 colors). And only pango works with my locale ( xft was not working). Since the dwm tip ( dwm 6.1 ) is already patched with xft , I thought to use it with statuscolors and pango.

The mistake you pointed is working . Now the text is rendering clearly. But now there is some empty space on my bar , can you tell me what could that be.

Here is the image:
https://raw.github.com/nixmeal/pkgbuild/master/pic.png

Thank you.

Edit: nice work, does your patch needs statuscolors ? I think not.

Last edited by illusionist (2012-11-11 11:11:57)

Arch Linux

#951 2012-11-09 19:59:54

Re: DWM Hackers Unite! Share (or request) dwm patches.

#952 2012-11-09 20:08:04

Re: DWM Hackers Unite! Share (or request) dwm patches.

#953 2012-11-09 20:17:16

Re: DWM Hackers Unite! Share (or request) dwm patches.

#954 2012-11-09 20:19:00

Re: DWM Hackers Unite! Share (or request) dwm patches.

#955 2012-11-09 20:19:34

Re: DWM Hackers Unite! Share (or request) dwm patches.

#956 2012-11-09 20:21:22

Re: DWM Hackers Unite! Share (or request) dwm patches.

#957 2012-11-09 20:21:23

Re: DWM Hackers Unite! Share (or request) dwm patches.

#958 2012-11-09 20:25:33

Re: DWM Hackers Unite! Share (or request) dwm patches.

#959 2012-11-09 20:27:22

Re: DWM Hackers Unite! Share (or request) dwm patches.

#960 2012-11-09 20:27:44

Re: DWM Hackers Unite! Share (or request) dwm patches.

#961 2012-11-09 20:31:16

Re: DWM Hackers Unite! Share (or request) dwm patches.

#962 2012-11-09 20:33:27

Re: DWM Hackers Unite! Share (or request) dwm patches.

#963 2012-11-09 21:05:05

Re: DWM Hackers Unite! Share (or request) dwm patches.

#964 2012-11-09 21:12:38

Re: DWM Hackers Unite! Share (or request) dwm patches.

#965 2012-11-09 22:00:43

Re: DWM Hackers Unite! Share (or request) dwm patches.

#966 2012-11-09 22:12:53

Re: DWM Hackers Unite! Share (or request) dwm patches.

#967 2012-11-09 22:50:57

Re: DWM Hackers Unite! Share (or request) dwm patches.

#968 2012-11-09 23:11:10

Re: DWM Hackers Unite! Share (or request) dwm patches.

#969 2012-11-10 01:35:38

Re: DWM Hackers Unite! Share (or request) dwm patches.

#970 2012-11-10 12:22:24

Re: DWM Hackers Unite! Share (or request) dwm patches.

#971 2012-11-11 09:25:27

Re: DWM Hackers Unite! Share (or request) dwm patches.

#972 2012-11-11 09:56:28

Re: DWM Hackers Unite! Share (or request) dwm patches.

#973 2012-11-11 10:38:34

Re: DWM Hackers Unite! Share (or request) dwm patches.

#974 2012-11-11 11:01:08

Re: DWM Hackers Unite! Share (or request) dwm patches.

#975 2012-11-11 11:08:55

Re: DWM Hackers Unite! Share (or request) dwm patches.

Board footer