[SOLVED] DWM mouse focus issue

Beg · 2013-02-26 16:36:07

The windows don't switch focus on what the mouse is pointing at if you go from an empty tab to another one. You need to move the mouse outside and back the window you have the mouse on currently to be able to get focus on it.

How to reproduce the effect:
Open 2-3 windows in tab 1, keep tab 2 empty.
focus window 1
switch to tab 2(pref with hotkeys),
move mouse to where window 2 is located in tab 1,
switch back to tab 1, now you will still have window 1 focused.

Has anyone been able to fix this?

Last edited by Beg (2013-03-01 09:28:02)

jasonwryan · 2013-02-26 17:12:10

Like this?

Beg · 2013-02-26 17:24:44

I do believe so, thanks. I will try it out.

Beg · 2013-02-26 17:40:18

I'm sorry but I'm pretty new where do I find the file I should patch? I tried grabbing xorg-server and gtk with ABS but none of those contain the file I need to patch.

illusionist · 2013-02-26 18:29:08

See the enternotify patch on my github.

Beg · 2013-02-26 18:50:47

illusionist, this did the opposite of what I wanted.

I want it to focus whatever I have my mouse over, even when I switch tabs..

The issue I have is that when I switch tabs it doesn't focus what is on my mouse, but rather what was last focused in that window before the switch.

both fixes did not fix it. Unsolving this

Beg · 2013-02-26 19:45:20

http://www.twitch.tv/iambeg/b/371625138 Here you have a video demostration

Basically, when I switch tabs, the focus stays on the focus even if the mouse is located on a new location hovering over a new window.

The blue oversized border shows the current focus.

Last edited by Beg (2013-02-26 19:50:24)

illusionist · 2013-02-28 09:00:27

I think you need to write a patch by yourself if you need that functionality. Combine something like 'ClkClientWin' and 'view(&arg)'. You may want to add a new atom too but I am not sure.
Little off topic: If you see yourself too much patching/modifying dwm then IMHO it may not be the right choice for you. It is a keyboard driven WM and mouse functionality is optional. There are other alternatives around; like ratpoison. You may give them a try.

Trilby · 2013-02-28 12:36:05

If you want to patch dwm, it would only take two or three lines added to the tag function.

At the end of the function just add an XQueryPointer to get the window the pointer is over, then wintoclient on that window, then focus that client.

Beg · 2013-02-28 20:25:50

Illusionist I do understand your PoV and I do agree that it is a keyboard oriented WM. But I have closed down endlessly many windows because the illusion I get from having the mouse over an window.

Altough after making this post I did configure my DWM to behave "differently" I added an oversized border which helps me notice what window is actually focused. I do have very bad eyes and a 1px border is to small for me to notice. Now in conjunction with both adding the border and also noticing what my problem actually is I have started to take notice of where my focus is at and I have started to use alt+k/j to manouver around windows instead of relying on the mouse.

But I would still like to solve this.

@Trilby Thanks for the instructions. I will see if I can manage it on my own!

I did as you asked Trilby

	int di;
	unsigned int dui;
	Window win,dummy;
	XQueryPointer(dpy, root, &win, &dummy, &di, &di, &di, &di, &dui);
	focus(wintoclient(win));
        XFlush(dpy);

It does not seem to work. I get no errors or crashes. As I have no experience in WM's, linux or C, I sadly don't know how to debug this, would appreciate some help!

Last edited by Beg (2013-03-02 01:07:03)

Trilby · 2013-02-28 21:23:26

That looks pretty good to me - for no experience in C you seem to have interpreted my suggestion quite well into the exact commands I was thinking. I no longer have dwm on this computer - I may dabble with this over the weekend, but my main suspicious would be that it may need an XFlush(dpy) after the call to focus.

Beg · 2013-02-28 21:57:20

Nope. Still acts the same after I added XFlush(dpy);
, I am restarting the dwm each time. Just to verify it's not human error.

Edit: I'll keep the previous post up to date to my patch fix.

Last edited by Beg (2013-02-28 21:57:57)

Trilby · 2013-03-01 03:18:02

Beg wrote:

I am restarting the dwm each time

Restarting? This would definitely be necesary, but not sufficient. Are you recompiling it?

Beg · 2013-03-01 06:24:20

Trilby wrote:

Beg wrote:
I am restarting the dwm each time
Restarting? This would definitely be necesary, but not sufficient. Are you recompiling it?

Yes. Ofcourse!

Vain · 2013-03-01 08:44:30

Hi,

you need to add it to 'view()' instead of 'tag()', I think. Plus, 'win' and 'dummy' are mixed up. Here you go:

https://github.com/vain/dwm-vain/commit … b15a7ae03d

Cheers!

Beg · 2013-03-01 09:16:15

Many thanks to you kind sir!
Thank you all!

Last edited by Beg (2013-03-02 01:07:38)

Arch Linux

#1 2013-02-26 16:36:07

[SOLVED] DWM mouse focus issue

#2 2013-02-26 17:12:10

Re: [SOLVED] DWM mouse focus issue

#3 2013-02-26 17:24:44

Re: [SOLVED] DWM mouse focus issue

#4 2013-02-26 17:40:18

Re: [SOLVED] DWM mouse focus issue

#5 2013-02-26 18:29:08

Re: [SOLVED] DWM mouse focus issue

#6 2013-02-26 18:50:47

Re: [SOLVED] DWM mouse focus issue

#7 2013-02-26 19:45:20

Re: [SOLVED] DWM mouse focus issue

#8 2013-02-28 09:00:27

Re: [SOLVED] DWM mouse focus issue

#9 2013-02-28 12:36:05

Re: [SOLVED] DWM mouse focus issue

#10 2013-02-28 20:25:50

Re: [SOLVED] DWM mouse focus issue

#11 2013-02-28 21:23:26

Re: [SOLVED] DWM mouse focus issue

#12 2013-02-28 21:57:20

Re: [SOLVED] DWM mouse focus issue

#13 2013-03-01 03:18:02

Re: [SOLVED] DWM mouse focus issue

#14 2013-03-01 06:24:20

Re: [SOLVED] DWM mouse focus issue

#15 2013-03-01 08:44:30

Re: [SOLVED] DWM mouse focus issue

#16 2013-03-01 09:16:15

Re: [SOLVED] DWM mouse focus issue

Board footer