You are not logged in.
I'm using LXDE as my desktop environment and I've come across a problem; I'm not sure whether I should flag the package as out-of-date or report it as a bug.
The package in question is 'lxsession' and the problem involves screen locking. Lxsession includes a small application to handle power actions, locking the screen, and logging out of the current session. It's normally invoked from the menu in the LXDE panel.
The current version of lxsession has a patch applied against it to support systemd. However, that patch also includes a change to support xdg-screensaver for locking the screen, and this option is placed before the upstream lxlock option. Doing this causes certain screen lockers that are otherwise supported by LXDE, such as xlockmore, to no longer function correctly. The section of the patch in question is currently:
+static const gchar* determine_lock_screen(void)
+{
+ const gchar* program = NULL;
+
+ if (g_find_program_in_path("xdg-screensaver"))
+ {
+ program = "xdg-screensaver lock";
+ }
+ else if (g_find_program_in_path("lxlock"))
+ {
+ program = "lxlock";
+ }
+ return program;
+}
+
+If this is changed to:
+static const gchar* determine_lock_screen(void)
+{
+ const gchar* program = NULL;
+
+ if (g_find_program_in_path("lxlock"))
+ {
+ program = "lxlock";
+ }
+ else if (g_find_program_in_path("xdg-screensaver"))
+ {
+ program = "xdg-screensaver lock";
+ }
+ return program;
+}
+
+then everything works correctly. I've tested this by making the change and re-compiling locally.
This change has in fact already been made in the upstream LXDE SourceForge code. However, I'm not sure that the upstream stuff includes systemd support, or if the package maintainer has a reason for specifying the two options in the current patch's order.
My question then is this: what is proper etiquette in a situation like this? I would like to be helpful and provide the patch, but I don't want to open a bug report for something that should just be flagged. Guidance?
Last edited by trogdor1138 (2013-10-13 19:04:02)
Offline
Open a bug report. That way the maintainer will immediately see what has changed and not need to dig through the code and changelog to see why the patch no longer applies. If the package cannot be updated for some reason, it will likely be bumped with your patch.
Thanks!
p.s. If anyone suggests that you should have just flagged the package, blame me Allan. ![]()
My Arch Linux Stuff • Forum Etiquette • Community Ethos - Arch is not for everyone
Offline
Done; bug report opened. Thanks for the answer.
Offline