first PKGBUILD please review

scoscosco · 2013-10-18 11:01:56

Hello,

I am creating this because a non technical friend has moved away from .deb's but lacks the knowledge to install from source. Either way the source install is very messy. Creating lots of unowned files all over the system.

A few questions...

1. I was unable to get $pkgname and $pkgver into the source line. Is this ok ?
2. I have taken the deps from http://torrent-search.sourceforge.net/d … stallation

however not 100% they correspond to Archlinux's packages. Is there a better way of knowing dep names over the linux flavors ?

3. I have run namcap, it is not spewing anything bad. Any other checks?
4. I am not the maintainer ? I'v just created this PKGBUILD, so I am the contributor?

Any help here appreciated

------------------

# Maintainer: <gwendal.lebihan.dev [at] gmail (dot) com>
# Contributer: sco` <rossybradley [at] gmail (dot) com>

pkgname=torrent-search
pkgver=0.11.2
pkgrel=1
pkgdesc="Torrent search engine developed in Python, using GTK+"
arch=('any')
url="http://torrent-search.sourceforge.net"
license=("GPLv3")
makedepends=('python2')
depends=('python2' 'pygtk' 'python2-lxml' 'python2-httplib2' 'python2-dbus')
source=(http://sourceforge.net/projects/torrent-search/files/torrent-search/0.11.2/torrent-search_0.11.2.tar.gz)
md5sums=('7753393e3fc957def24b52d2b0e22d80')

build() {
true
}

package() {
cd "$srcdir/$pkgname"
python2 setup.py install --root=$pkgdir
}

graysky · 2013-10-18 11:10:52

https://aur.archlinux.org/packages/?O=0 … ent-search

scoscosco · 2013-10-18 11:15:37

Ahh at least I get to see how its done properly!

Thanks graysky

karol · 2013-10-18 11:17:32

Read https://wiki.archlinux.org/index.php/Py … Guidelines
It suggests

package() {
  cd "$srcdir/$pkgname-$pkgver"

instead of

package() {
  cd "$srcdir/$pkgname"

If you don't build it, makedepends don't make sense.

You don't have to use $pkgname and $pkgver in the source line. Use variables where it makes sense and isn't cumbersome.

If you're going to upload it to the AUR and maintain it there, you're the maintainer. Otherwise, it doesn't really matter whether you're the maintainer or contributor.

When posting configs, code or command output, please use [ code ] tags https://bbs.archlinux.org/help.php#bbcode

like this

It makes the code more readable and - in case of longer listings - more convenient to scroll through.

Last edited by karol (2013-10-18 11:19:31)

graysky · 2013-10-18 11:28:56

karol wrote:

Read https://wiki.archlinux.org/index.php/Py … Guidelines
It suggests
package() {
  cd "$srcdir/$pkgname-$pkgver"
instead of
package() {
  cd "$srcdir/$pkgname"

Just use:

cd "$pkgname-$pkgver"

See: https://bugs.archlinux.org/task/34314

Last edited by graysky (2013-10-18 11:29:26)

Scimmia · 2013-10-18 16:59:40

karol wrote:

Read https://wiki.archlinux.org/index.php/Py … Guidelines
It suggests
package() {
  cd "$srcdir/$pkgname-$pkgver"
instead of
package() {
  cd "$srcdir/$pkgname"

That depends completely on the tarball being used. If it extracts to $pkgname instead of $pkgname-$pkgver, that's what you use.

graysky wrote:

Just use:
cd "$pkgname-$pkgver"
See: https://bugs.archlinux.org/task/34314

There's nothing wrong with cd'ing to an absolute path instead of a relative path. Some of us like to know where we are, not rely on the calling program to put is in the right place.

Arch Linux

#1 2013-10-18 11:01:56

first PKGBUILD please review

#2 2013-10-18 11:10:52

Re: first PKGBUILD please review

#3 2013-10-18 11:15:37

Re: first PKGBUILD please review

#4 2013-10-18 11:17:32

Re: first PKGBUILD please review

#5 2013-10-18 11:28:56

Re: first PKGBUILD please review

#6 2013-10-18 16:59:40

Re: first PKGBUILD please review

Board footer