Arch Linux

Thorsten Reinbold

Member

From: Germany

Registered: 2011-12-06

Posts: 353

Darktable segfaults

Is it just me, or is the new darktable release (1.4-1) extremly unstable? When trying to edit images (.cr2 Raw), the app hangs up with a segfault. Unless I delete the config files and cache, it will do so whenever I try to start it. After deleting the configs, it starts normal... unless I try to import files.

Message:

ptrace: Operation not permitted
/home/nordlicht/10503: File or Folder not found.
backtrace written to /tmp/darktable_bt_7F5F8W.txt
Segmentation fault(core dumped)

/tmp/darktable_bt_7F5F8W.txt says:

this is darktable 1.4 reporting a segfault:

/usr/share/darktable/gdb_commands:2: Error in sourced command file:
No stack.

Am I alone with this?

Last edited by Thorsten Reinbold (2013-12-27 21:43:05)

omer666

Member

Registered: 2011-01-26

Posts: 70

Re: Darktable segfaults

No you aren't, got the exact same problem on launch with DNG files from Pentax K-r.

Last edited by omer666 (2013-12-28 08:40:22)

Thorsten Reinbold

Member

From: Germany

Registered: 2011-12-06

Posts: 353

Re: Darktable segfaults

Do you have similar error messages?

omer666

Member

Registered: 2011-01-26

Posts: 70

Re: Darktable segfaults

Yes, the exact same as I said. I tried to disable OpenCL, delete ~/.config/darktable, etc. and nothing does the trick. Also, it doesn't seem to appear on the upstream bugtracker. I think we should at least fill a bug in arch bug tracker.

Thorsten Reinbold

Member

From: Germany

Registered: 2011-12-06

Posts: 353

Re: Darktable segfaults

Imho it would make more sense to file a report upstream on the darktable bugtracker. Do you have the same "No stack." message in the backtrace .txt file? That prevents me to file a report, atm.

Edit: here is the Bugreport upstream. If anyone wants to participate...

Last edited by Thorsten Reinbold (2013-12-29 12:52:40)

Thorsten Reinbold

Member

From: Germany

Registered: 2011-12-06

Posts: 353

Re: Darktable segfaults

(Moved to seperate thread)

Last edited by Thorsten Reinbold (2013-12-29 14:10:39)

Thorsten Reinbold

Member

From: Germany

Registered: 2011-12-06

Posts: 353

Re: Darktable segfaults

A fix was provided here:

https://github.com/darktable-org/darkta … 34e4a43a22

Works fine for me.

omer666

Member

Registered: 2011-01-26

Posts: 70

Re: Darktable segfaults

Yes it works for me, too.
I made an updated PKGBUILD with a patch.

PKGBUILD :

# $Id: PKGBUILD 103146 2013-12-27 15:54:52Z spupykin $
# Maintainer: Sergej Pupykin <pupykin.s+arch@gmail.com>
# Maintainer:  Christian Himpel <chressie at gmail dot com>
# Contributor: Johannes Hanika <hanatos at gmail dot com>

pkgname=darktable
pkgver=1.4
_pkgver=1.4
pkgrel=1
pkgdesc="Utility to organize and develop raw images"
arch=('i686' 'x86_64')
url=http://darktable.sf.net/
license=('GPL3')
depends=('exiv2>=0.18' 'intltool>=0.40' 'lcms2' 'lensfun>=0.2.3' 'libglade' 'dbus-glib'
	 'curl' 'libgnome-keyring' 'libgphoto2' 'openexr' 'sqlite' 'libxslt'
	 'libsoup' 'gtk-engines' 'json-glib' 'flickcurl')
makedepends=('intltool>=0.40' 'cmake' 'librsvg')
optdepends=('librsvg')
install=darktable.install
source=(http://downloads.sourceforge.net/project/darktable/darktable/${_pkgver}/darktable-$pkgver.tar.xz darktable-1.4.patch)
md5sums=('896416931ded4579f528cd11edad470c'
         '4134ab6afab831ef2183d05f14d732e5')

build() {
  cd "$srcdir/$pkgname-$pkgver"
  patch -p1 -i $srcdir/darktable-1.4.patch
  mkdir -p build
  cd build
  CXXFLAGS+=" -fpermissive"
  cmake \
      -DCMAKE_INSTALL_PREFIX=/usr \
      -DCMAKE_BUILD_TYPE=Release \
      -DDONT_INSTALL_GCONF_SCHEMAS=True \
      -DBINARY_PACKAGE_BUILD=1 \
      -DUSE_GCONF_BACKEND=Off \
      -DBUILD_USERMANUAL=False \
      ..
  make
}

package() {
  cd "$srcdir/$pkgname-$pkgver/build"
  make DESTDIR="$pkgdir" install
  mv "${pkgdir}/usr/share/doc/darktable" "${pkgdir}/usr/share/doc/${pkgname}-${pkgver}"
}

darktable-1.4.patch

diff -aur darktable-1.4.pristine/src/external/rawspeed/RawSpeed/RawImage.cpp darktable-1.4.new/src/external/rawspeed/RawSpeed/RawImage.cpp
--- darktable-1.4.pristine/src/external/rawspeed/RawSpeed/RawImage.cpp	2013-12-23 20:02:22.000000000 +0100
+++ darktable-1.4.new/src/external/rawspeed/RawSpeed/RawImage.cpp	2014-01-10 14:55:55.214496649 +0100
@@ -394,11 +394,18 @@
   if (this == &p)      // Same object?
     return *this;      // Yes, so skip assignment, and just return *this.
   pthread_mutex_lock(&p_->mymutex);
+// Retain the old RawImageData before overwriting it
   RawImageData* const old = p_;
   p_ = p.p_;
+// Increment use on new data
   ++p_->dataRefCount;
-  if (--old->dataRefCount == 0) delete old;
-  pthread_mutex_unlock(&p_->mymutex);
+// If the RawImageData previously used by "this" is unused, delete it.
+  if (--old->dataRefCount == 0) {
+      pthread_mutex_unlock(&(old->mymutex));
+      delete old;
+  } else {
+      pthread_mutex_unlock(&(old->mymutex));
+  }
   return *this;
 }
 

Thorsten Reinbold

Member

From: Germany

Registered: 2011-12-06

Posts: 353

Re: Darktable segfaults

Hey! Thanks for posting this. One thing: is it necessary to report this bug to arch direktly? I mean: the problem is solved upstream, but an new release will take a while, so Arch-users have a non functional darktable in the repos for now.