First attempt at a package - rstudio-desktop-preview

dasonk · 2014-04-20 03:35:38

Hi all - I've been interested in providing a package for the preview release of RStudio for quite some time now and I figured that I might as well just give it a shot - what's the worst that could happen. I read through some of the threads but I guess I just want some feedback on if everything looks alright and if it would be reasonable to submit this to the AUR. It builds for me and works great on my system. However I feel like I cheated a little because I just modified the PKGBUILD of rstudio-desktop-bin so that it would work with the preview release; this seems sensible to me but I'm not sure if I need to give the maintainer of that package any credit somewhere.

PKGBUILD:

# Contributor: dasonk < dasonk at gmail dot com >

pkgname=rstudio-desktop-preview
pkgver=0.98.788
pkgrel=1
pkgdesc="A new integrated development environment (IDE) for R (binary version from RStudio official website)"
arch=('i686' 'x86_64')
license=('GPL')
url="http://www.rstudio.org/ide/download/preview"
depends=('r>=2.11.1' 'qtwebkit')
conflicts=('rstudio-desktop' 'rstudio-desktop-git' 'rstudio-desktop-bin')
provides=("rstudio-desktop=${pkgver}")
options=(!strip)
_x86md5=be7da6269c6499770957f478f4eeaf2f
_x64md5=db2fc2ce37dc4d16e12bc95c85eaa731
case "$CARCH" in
	'i686')
		_arch=i386
		md5sums=($_x86md5)
		;;
	'x86_64')
		_arch=amd64
		md5sums=($_x64md5)
		;;
esac    
source=("https://s3.amazonaws.com/rstudio-dailybuilds/rstudio-${pkgver}-${_arch}.deb")
install="$pkgname".install

package() {
  msg "Converting debian package..."
  cd "$srcdir"
  tar zxpf data.tar.gz -C "$pkgdir"
  install -dm755 "$pkgdir/usr/bin"
  cd "$pkgdir/usr/lib/rstudio/bin"
  rm lib*.so.*
  cd "$pkgdir/usr/bin"
  ln -s -f ../lib/rstudio/bin/rstudio rstudio-bin
}

rstudio-desktop-preview.install:

post_install() {
  [ -e $(which xdg-icon-resource) ] && xdg-icon-resource forceupdate --theme hicolor
  update-mime-database /usr/share/mime &>/dev/null
}
post_upgrade() {
  post_install
}
post_remove() {
  post_install
}

Now I've read that just converting debian packages isn't best practice but it seems reasonable here. I also read that you really should only provide PKGBUILD for architectures that you've personally tested on - I only tested on amd64 so should I get rid of the i386 (even though I'm pretty sure it'll work just fine)?

Thanks for any feedback.

Trilby · 2014-04-20 03:41:45

There are already two (redundant) -git packages in the AUR for rstudio - what's different about this one?

Last edited by Trilby (2014-04-20 03:43:32)

Lone_Wolf · 2014-04-20 12:58:29

dasonk wrote:

However I feel like I cheated a little because I just modified the PKGBUILD of rstudio-desktop-bin so that it would work with the preview release; this seems sensible to me but I'm not sure if I need to give the maintainer of that package any credit somewhere.this seems sensible to me but I'm not sure if I need to give the maintainer of that package any credit somewhere.

In these cases it's common practice to add them as contributor.

Note that you should put yourself as maintainer.

i386 : you could comment those lines, and add that they may work but haven't been tested.

you should add -bin to the name of the package.

dasonk · 2014-04-20 21:02:04

Trilby wrote:

There are already two (redundant) -git packages in the AUR for rstudio - what's different about this one?

Good question!

rstudio-desktop is built from the sources (not the binaries) but it out of date and I'm not interested in the official release
rstudio-desktop-bin is what I based my PKGBUILD off of. This is using the debian binaries from the official releases to install. These only get updated every so often (not quite often enough for my liking with how quick Rstudio has been adding new features).
rstudio-desktop-git is the git version of rstudio. I can't get this to build at the moment and is a little too unstable for my liking.

Rstudio provides 'preview' releases which offer a decent compromise between stability and getting the newest features. This is what I want to offer. Honestly if you think that this would just clutter the AUR with something that is unnecessary then I don't need to upload it to the AUR but figured that if I was interested in it then somebody else might be as well.

Lone_Wolf wrote:

dasonk wrote:
However I feel like I cheated a little because I just modified the PKGBUILD of rstudio-desktop-bin so that it would work with the preview release; this seems sensible to me but I'm not sure if I need to give the maintainer of that package any credit somewhere.this seems sensible to me but I'm not sure if I need to give the maintainer of that package any credit somewhere.
In these cases it's common practice to add them as contributor.
Note that you should put yourself as maintainer.
i386 : you could comment those lines, and add that they may work but haven't been tested.
you should add -bin to the name of the package.

Thanks for the feedback! I changed the name to rstudio-desktop-preview-bin. I added Meow as a contributor and changed myself to be the maintainer. And actually since yesterday they updated the preview release so I upped the version and updated the md5sums. Here is the updated PKGBUILD

# Maintainer: dasonk < dasonk at gmail dot com >
# Contributor: Meow < meow at linux dot cn >

pkgname=rstudio-desktop-preview-bin
pkgver=0.98.792
pkgrel=1
pkgdesc="A new integrated development environment (IDE) for R (The preview binary from the website)."
arch=('x86_64') # May work for i686 but hasn't been tested
license=('GPL')
url="http://www.rstudio.org/ide/download/preview"
depends=('r>=2.11.1' 'qtwebkit')
conflicts=('rstudio-desktop' 'rstudio-desktop-git' 'rstudio-desktop-bin')
provides=("rstudio-desktop=${pkgver}")
options=(!strip)
#_x86md5=13afc95d4d28198a401863418b5b6113
_x64md5=8e2c6a94bc79f8183600d5a480463f19
case "$CARCH" in
#	'i686')
		#_arch=i386
		#md5sums=($_x86md5)
		#;;
	'x86_64')
		_arch=amd64
		md5sums=($_x64md5)
		;;
esac    
source=("https://s3.amazonaws.com/rstudio-dailybuilds/rstudio-${pkgver}-${_arch}.deb")

install="$pkgname".install

package() {
  msg "Converting debian package..."
  cd "$srcdir"
  tar zxpf data.tar.gz -C "$pkgdir"
  install -dm755 "$pkgdir/usr/bin"
  cd "$pkgdir/usr/lib/rstudio/bin"
  rm lib*.so.*
  cd "$pkgdir/usr/bin"
  ln -s -f ../lib/rstudio/bin/rstudio rstudio-bin
}

Is that how you envisioned me commenting out the i686 stuff? Is there anything glaringly wrong with this? Thanks for the feedback and do you think it would be worth it to upload to AUR or should I just keep this to myself...

Lone_Wolf · 2014-04-22 10:53:19

Is that how you envisioned me commenting out the i686 stuff? Is there anything glaringly wrong with this? Thanks for the feedback and do you think it would be worth it to upload to AUR or should I just keep this to myself...

Looks ok to me.

uploading it to aur :
Imo best way to find out if there's interest in these preview releases is to upload it.
Keep in mind though that this package will likely have to be updated often, and as maintainer you'll be the first one people will expect to help with issues.

dasonk · 2014-04-24 22:45:19

Thanks! I uploaded a few days ago. I appreciate all the help.

Arch Linux

#1 2014-04-20 03:35:38

First attempt at a package - rstudio-desktop-preview

#2 2014-04-20 03:41:45

Re: First attempt at a package - rstudio-desktop-preview

#3 2014-04-20 12:58:29

Re: First attempt at a package - rstudio-desktop-preview

#4 2014-04-20 21:02:04

Re: First attempt at a package - rstudio-desktop-preview

#5 2014-04-22 10:53:19

Re: First attempt at a package - rstudio-desktop-preview

#6 2014-04-24 22:45:19

Re: First attempt at a package - rstudio-desktop-preview

Board footer