You are not logged in.

#1 2014-06-13 00:20:36

Jarkore
Member
From: Austin, TX
Registered: 2013-08-05
Posts: 11
Website

[]

[]

Last edited by Jarkore (2016-08-17 01:23:59)

Offline

#2 2014-06-13 00:58:29

jasonwryan
Anarchist
From: .nz
Registered: 2009-05-09
Posts: 30,426
Website

Re: []

You shouldn't write to ~: https://wiki.archlinux.org/index.php/Ar … _standards use a message in the .install instead


Arch + dwm   •   Mercurial repos  •   Surfraw

Registered Linux User #482438

Offline

#3 2014-06-13 01:09:20

Ziusudra
Member
Registered: 2014-04-19
Posts: 120

Re: []

The (seemingly undocumented) convention is that this would be "pkgname=feednix-git". A PKGBUILD with "pkgname=feednix" would use your latest release and a file hash for the more security/stability minded.

Offline

#4 2014-06-13 02:36:29

Scimmia
Fellow
Registered: 2012-09-01
Posts: 13,655

Re: []

'gcc' should not be in the makedeps. It's part of base-devel and assumed to be installed at build time.
arch=('any') means there is no architecture specific binaries in the final package (just scripts, data, etc). Is that the case?
|| return 1 is not needed. makepkg will fail on any errors.
Please use quotes around any paths containing variables, such as ${pkgdir}/usr/bin/feednix

As for the config file in the home dir, ideally, the program itself will check if that file exists and put it there on first run if it doesn't. Barring that, you may just have to put instructions in the install script for people to do it manually.

Last edited by Scimmia (2014-06-13 02:37:34)

Offline

#5 2014-06-13 22:22:06

Jarkore
Member
From: Austin, TX
Registered: 2013-08-05
Posts: 11
Website

Re: []

[]

Last edited by Jarkore (2016-08-17 01:24:35)

Offline

#6 2014-06-13 22:41:08

WorMzy
Administrator
From: Scotland
Registered: 2010-06-16
Posts: 13,374
Website

Re: []

I'm unsure what it does (since you install things manually anyway), but 'make install' should be in the package() function. Ideally you should be 'make install'ing into $pkgdir, but again, this depends on your makefile.

'make clean' at the end of the package function is also not needed. makepkg will create a clean build environment every time you run it (unless you tell it not to).


Sakura:-
Mobo: MSI MAG X570S TORPEDO MAX // Processor: AMD Ryzen 9 5950X @4.9GHz // GFX: AMD Radeon RX 5700 XT // RAM: 32GB (4x 8GB) Corsair DDR4 (@ 3000MHz) // Storage: 1x 3TB HDD, 6x 1TB SSD, 2x 120GB SSD, 1x 275GB M2 SSD

Making lemonade from lemons since 2015.

Offline

#7 2014-06-15 03:17:38

Jarkore
Member
From: Austin, TX
Registered: 2013-08-05
Posts: 11
Website

Re: []

[]

Last edited by Jarkore (2016-08-17 01:24:44)

Offline

#8 2014-06-15 08:18:37

Raynman
Member
Registered: 2011-10-22
Posts: 1,539

Re: []

There's one comment/question that you seem to have missed:

Scimmia wrote:

arch=('any') means there is no architecture specific binaries in the final package (just scripts, data, etc). Is that the case?

Offline

Board footer

Powered by FluxBB