whistle - a minimalistic curses based audio player

progandy · 2014-07-07 17:57:31

ap0calypse wrote:

but what about ratings in ogg-vobis? flac? are there any?

There are inofficial extensions to the vorbiscomment format (used in ogg and flac), often there is a RATING field, but the format is not constant. Some use 0-5 (for stars), others 0-100 in percent. I once even read a suggestion for 0-255 just like ID3v2, but that is probably not used in the wild.
Edit: Adding unofficial fields to vorbiscomments is common practice. If a player does not understand the field, it skips it.

Last edited by progandy (2014-07-07 17:58:23)

smiszym · 2014-07-08 08:05:12

Well, perhaps you could mix embedded-in-tags ratings with whistle-only ratings. These two would be completely independent sets of ratings and it would work this way:
1. the player uses only whistle-only ratings to choose a song and to sort songs and to do whatever else,
2. whistle-only ratings default to 0 (or unknown) and can be changed at any time without altering audio files,
3. users can "import" or "copy" embedded-in-tags ratings from certain files into whistle-only ratings.

Just suggesting

ap0calypse · 2014-07-08 09:25:55

smiszym wrote:

Well, perhaps you could mix embedded-in-tags ratings with whistle-only ratings. These two would be completely independent sets of ratings and it would work this way:
1. the player uses only whistle-only ratings to choose a song and to sort songs and to do whatever else,
2. whistle-only ratings default to 0 (or unknown) and can be changed at any time without altering audio files,
3. users can "import" or "copy" embedded-in-tags ratings from certain files into whistle-only ratings.
Just suggesting

Although it might be correct and common practice to write such ratings into tags, I really am not sure if this practice is really a good practice ... How am I supposed to know which tag field represents the ranking if they are called, .... I don't know .... EXAILE_RANKING, or banshee-rank, or whatever ...

I think the most sane and secure way is to create a separate data structure to hold ratings for every song (like progandy and you recommended).
Because other players could write these ranking-tag in whatever fashion they like best, I can't think of a better way to make this happen.

In the near future I will most likely implement this ranking (additionally to some other features ), but first I'm going to implement equalizer presets, and a dynamic equalizer setting, which can be used to save equalizer settings over restarts and gives the user the possibility to apply a specific equalizer to a specific album/song/artist.

I think this is crucial, because I don't know any player, that let's you do that.

Thanks for the ideas!

dice · 2014-07-08 10:20:07

I like that clean mp3 player you've created here. I guess I've found a bug:
If I just started whistle and select a song hit p there seems to be somre error message but I can't read it fast enough before the program simply quits.
Maybe connected to that: when I stop the playing using S and then pressing p there is no sound.

Also a request:
When using the shuffle mode it is sometimes hard to find the song it is playing in the list, therefore it would be nice if the list scrolls down to the song playing when starting a new song. At least in the shuffle mode

ap0calypse · 2014-07-08 10:32:52

dice wrote:

I like that clean mp3 player you've created here. I guess I've found a bug:
If I just started whistle and select a song hit p there seems to be somre error message but I can't read it fast enough before the program simply quits.
Maybe connected to that: when I stop the playing using S and then pressing p there is no sound.
Also a request:
When using the shuffle mode it is sometimes hard to find the song it is playing in the list, therefore it would be nice if the list scrolls down to the song playing when starting a new song. At least in the shuffle mode

Hi there!

lowercase 'p' is for PAUSE, not for play, that's uppercase 'P' but thanks for noticing. There is although nothing wrong in the behavior of that. What you maybe did is "Stop - Pause" which does presumably nothing

I will test it out, it shouldn't just simply quit due to wrong user input .... I will have a look at it

EDIT: forgot to mention the reason for not 'jumping-to-track':
If you are sorting your playlists, adding and deleting stuff, and the song changes, you would be kicked right out of your work and to the position currently playing. this may annoy users (at least, that was my opinion and the opinion of another tester). So I decided to not jump to the current track in the playlist. Maybe I could make a 'jump-to-selected' toggle switch if enough people are interested in such a feature

EDIT2: .... or even easier. keybind 'j' -> jump to currently playing song. that would be a solution I could most certainly live with. What do you think?

thanks!

Last edited by ap0calypse (2014-07-08 10:50:14)

ap0calypse · 2014-07-08 11:57:59

dice wrote:

If I just started whistle and select a song hit p there seems to be somre error message but I can't read it fast enough before the program simply quits.

FIXED! pause does nothing unless a song is really playing. Pausing a not-playing track doesn't really make that much sense

smiszym · 2014-07-08 16:55:48

ap0calypse wrote:

keybind 'j' -> jump to currently playing song

Thumb up.

ap0calypse wrote:

FIXED! pause does nothing unless a song is really playing. Pausing a not-playing track doesn't really make that much sense

Some players always pause under 'p' and others toggle play/pause. I think that's a matter of preference. I personally don't mind

ap0calypse · 2014-07-08 18:57:40

Heyho!

another day with fixes and features ... today I implemented the possibility to save your current equalizer settings per song/artist/album. This way, you have the unique possibility to really fine-tune your music The normal approach to do this would be:

- select song and play it
- change equalizer with F1 - F10
- select songs you want to apply these settings to (multiselect is possible)
- press 'v'
- > you will be prompted if you want to apply these equalizer to the selected songs only, the complete albums of the selected songs or the selected artists.

done!

depending on your choice, either the songs or the albums/artists selected now all have the equalizer settings and will still have them after a restart, because they are saved in .whistle.dat.

have fun!

dice · 2014-07-09 10:46:09

ap0calypse wrote:

lowercase 'p' is for PAUSE, not for play, that's uppercase 'P' but thanks for noticing. There is although nothing wrong in the behavior of that. What you maybe did is "Stop - Pause" which does presumably nothing

Ah, I see....I didn't read the help that exact, sorry for that. I just saw 'okay it is a 'p' for pause and a 'p' for play. I didn't notice the difference, but now it's clear thank you.

ap0calypse wrote:

keybind 'j' -> jump to currently playing song. that would be a solution I could most certainly live with. What do you think?

I like that. Gives most control without being in the way

ap0calypse · 2014-07-09 11:09:02

smiszym wrote:

Some players always pause under 'p' and others toggle play/pause. I think that's a matter of preference. I personally don't mind

whistle also toggles play/pause with 'p', but it doesn't if nothing is loaded. If you loaded a file and play it, you can toggle the pause-switch as much as you want

dice wrote:

I like that. Gives most control without being in the way

I think so too. I will implement this as soon as I can

EDIT: pheewww ... looks like this 'j'-switch is harder to implement than I thought.

Unfortunately, Curses::UI::Listbox (which is the container for the playlist), doesn't support any method to just 'jump' to an index-point. That sucks ... I have to work through the Curses::UI::Listbox source code, to find out, if there is any possibility in doing so. (so far I have seen some things that look promising -> $this->(-ypos) for example. I have to check it out.)

I tried to contact the author of the perl-module, but I only get an auto-responder back, that this adress is no longer in use ... hmpf ...

EDIT 2: I have it now. the new 'j' switch is implemented in the latest version (I was right, I had to fiddle around with the -ypos param )

Last edited by ap0calypse (2014-07-09 12:03:41)

ap0calypse · 2014-07-10 18:12:33

minor update:
* progressbar now shows time additional to percentual value, because sometimes you just want to know at which second something is ...

Rasi · 2014-07-10 19:20:12

while i havent tried whistle the screenshots show that it needs some design cleanup. (keyword aligning).

apart from that its always nice to see more multimedia cli apps

ap0calypse · 2014-07-10 19:51:10

You shouldn't rely on (maybe old) screenshots try it now, and tell me how to improve it.

I just recently did a major cleanup, I think it's much prettier than in the beginning

dice · 2014-07-10 20:07:17

In recent version i get a lot of "Missing argument in sprintf on line 453" and "Use of uninitialized value in concatenation (.) or string at line 451" errors when playing a song. It occurs on the initial 'P' to start playing and when I hit 'n' for the next song. In combination with shuffle and the new jump to song function(thanks for this ) it completely destroys the ui Although resizing the window hides the error messages, I guess because the ui is repainted and therefore hides these messages.

smiszym · 2014-07-10 20:17:21

@dice, I had this as well and figured out how to solve it. Just remove ~/.whistle.dat

It seems that after some recent update (involving change of .whistle.dat structure) whistle does not like older whistle.dat files ;)

Did that help?

PS or maybe backup whistle.dat somewhere before removing, just in case its data can be rescued

ap0calypse · 2014-07-10 20:20:50

Maybe even a quick rescan could help, this rewrites the datfile

btw: sorry if recent updates fucked up your playlists ... I had to fix some bugs, and in some cases, this interferes with some datfiles.
but the latest version should work alright

Last edited by ap0calypse (2014-07-10 20:23:31)

dice · 2014-07-10 20:38:24

smiszym wrote:

Just remove ~/.whistle.dat
It seems that after some recent update (involving change of .whistle.dat structure) whistle does not like older whistle.dat files
Did that help?

Yes, it works now thanks.

Another thing I'd like to suggest: Add something like

 undef $track

to the stop function because it is still possible to pause a stopped song now, and even resume it without playing...
Maybe there is a more elegant way to do this, but it seems to work here and I am a noob with perl so I don't really know what I am doing

ap0calypse · 2014-07-10 20:46:23

Thanks, I will look into it!

EDIT: done! -> https://github.com/ap0calypse/whistle/c … 74e5af204e

Last edited by ap0calypse (2014-07-10 20:50:58)

ap0calypse · 2014-07-11 14:05:36

Because of the extended input from my favorite beta-tester which has many playlists and a huge collection, I made some improvements again. I almost f***ed up the datfile, because of the parallel work with 2 different hashes in it. I forgot to delete old values from this hash, although I deleted it in the other one, which led to inconsistency and mysterious unexpected hickups. I _think_ I managed to fix this now.

If you encounter things like wrong amount of songs in playlist-window in the left, please re-add some songs to the specific playlist. I added a delete_dups function, which now handles the duplicates and deletes them.

Thanks! ... and sorry if you encounter any problems

Last edited by ap0calypse (2014-07-11 14:06:42)

progandy · 2014-07-11 14:42:58

ap0calypse wrote:

Because of the extended input from my favorite beta-tester which has many playlists and a huge collection, I made some improvements again. I almost f***ed up the datfile, because of the parallel work with 2 different hashes in it. I forgot to delete old values from this hash, although I deleted it in the other one, which led to inconsistency and mysterious unexpected hickups. I _think_ I managed to fix this now.

maybe you should start to add a database version at the beginning of the file, and add an upgrade script that rewrites the old database into the new format.

Last edited by progandy (2014-07-11 14:43:29)

dice · 2014-07-11 14:57:52

It seems as if the datfile gains more and more complexity and managing the format becomes difficult. Maybe you should use something like SQLite? This could also give us some performance benefit for huge collections.

ap0calypse · 2014-07-11 16:48:46

progandy wrote:

maybe you should start to add a database version at the beginning of the file, and add an upgrade script that rewrites the old database into the new format.

+

dice wrote:

It seems as if the datfile gains more and more complexity and managing the format becomes difficult. Maybe you should use something like SQLite? This could also give us some performance benefit for huge collections.

I did something (from my point of view) better. I rewrote it again to not need the additional data structure. Users with old datfiles are not affected though, because the new version doesn't use the now-obsolete structure anymore. If you don't want that old garbage to be saved and loaded in future, there is unfortunately only one way: rm ~/.whistle.dat

Boy ... what a day .... I just wanted to add a little bugfix, and ended up rewriting much of the code

EDIT: BTW, playlists are now FINALLY sorted. Really sorted. Artist - Album, alphabetically, always.

Last edited by ap0calypse (2014-07-11 16:49:43)

causes · 2014-11-06 17:03:51

Nice program. I made ebuild for Gentoo Linux[1]. I would like to see backend changed from mplayer to mpv.

[1] https://github.com/causes-/causelay/com … ec6bcb0434

ap0calypse · 2015-09-19 13:26:56

Thanks to thor77 there is now a new AUR-package for whistle-git.

THANKS AGAIN FOR THAT.

the only difference is one module dependency (perl-ogg-vorbis-header removed, perl-ogg-vorbis-header-pureperl added).

@causes:

Thanks for the ebuild, very much appreciated

Does mpv have a similar 'slave mode' like mplayer? Because I rely on it. If it has, it shouldn't be too hard to switch between mplayer and mpv.

Arch Linux

#26 2014-07-07 17:57:31

Re: whistle - a minimalistic curses based audio player

#27 2014-07-08 08:05:12

Re: whistle - a minimalistic curses based audio player

#28 2014-07-08 09:25:55

Re: whistle - a minimalistic curses based audio player

#29 2014-07-08 10:20:07

Re: whistle - a minimalistic curses based audio player

#30 2014-07-08 10:32:52

Re: whistle - a minimalistic curses based audio player

#31 2014-07-08 11:57:59

Re: whistle - a minimalistic curses based audio player

#32 2014-07-08 16:55:48

Re: whistle - a minimalistic curses based audio player

#33 2014-07-08 18:57:40

Re: whistle - a minimalistic curses based audio player

#34 2014-07-09 10:46:09

Re: whistle - a minimalistic curses based audio player

#35 2014-07-09 11:09:02

Re: whistle - a minimalistic curses based audio player

#36 2014-07-10 18:12:33

Re: whistle - a minimalistic curses based audio player

#37 2014-07-10 19:20:12

Re: whistle - a minimalistic curses based audio player

#38 2014-07-10 19:51:10

Re: whistle - a minimalistic curses based audio player

#39 2014-07-10 20:07:17

Re: whistle - a minimalistic curses based audio player

#40 2014-07-10 20:17:21

Re: whistle - a minimalistic curses based audio player

#41 2014-07-10 20:20:50

Re: whistle - a minimalistic curses based audio player

#42 2014-07-10 20:38:24

Re: whistle - a minimalistic curses based audio player

#43 2014-07-10 20:46:23

Re: whistle - a minimalistic curses based audio player

#44 2014-07-11 14:05:36

Re: whistle - a minimalistic curses based audio player

#45 2014-07-11 14:42:58

Re: whistle - a minimalistic curses based audio player

#46 2014-07-11 14:57:52

Re: whistle - a minimalistic curses based audio player

#47 2014-07-11 16:48:46

Re: whistle - a minimalistic curses based audio player

#48 2014-11-06 17:03:51

Re: whistle - a minimalistic curses based audio player

#49 2015-09-19 13:26:56

Re: whistle - a minimalistic curses based audio player

Board footer