You are not logged in.
- Topics: Active | Unanswered
#1 2015-09-01 06:23:19
- Gyscos
- Member
- Registered: 2009-09-19
- Posts: 33
lz4 version inconsistent
Hello,
I have lz4 r131-1 installed according to pacman, yet running lz4 --version returns:
*** LZ4 command line interface 64-bits r128, by Yann Collet (Jun 30 2015) ***Does anyone also see this behaviour?
I just cloned the upstream git repo, and I get the correct version there.
EDIT: compiling using the PKGBUILD indeed gives me a bad version. Interestingly, going back into the source repo and running
make clean && make results in a correct binary.
What's going on???
Last edited by Gyscos (2015-09-01 06:33:50)
Offline
#2 2015-09-01 11:17:28
- mauritiusdadd
- Member
- From: Benevento, Italy
- Registered: 2013-10-27
- Posts: 776
Re: lz4 version inconsistent
It's a bug in $srcdir/$pkgname/programs/Makefile:
RELEASE?= r131
DESTDIR?=
PREFIX ?= /usr/local
CFLAGS ?= -O3
CFLAGS += -std=c99 -Wall -Wextra -Wundef -Wshadow -Wcast-qual -Wcast-align -Wstrict-prototypes -pedantic -DLZ4_VERSION=\"$(RELEASE)\"
FLAGS := -I../lib $(CPPFLAGS) $(CFLAGS) -DLZ4_VERSION=\"$(RELEASE)\" $(LDFLAGS)As you can see, the release version is set in the variable CFLAGS, but make here is invoke with the -e option. This means that when you build the package using makepkg the environment variable CFLAGS override the one in the Makefile and the default version number instead, however it seems that the default version number have not been updated: https://github.com/Cyan4973/lz4/blob/r1 … 4cli.c#L89.
--edit: bug report https://github.com/Cyan4973/lz4/issues/149
Last edited by mauritiusdadd (2015-09-01 12:04:08)
Offline