The phpmyadmin config.inc.php.pacnew is missing the closing brace?

wdrev · 2015-10-09 21:31:48

I'm in the middle of my annual Arch Linux upgrade and update (which I always do whether it needs it or not) and I have a question.
While merging the config.inc.php.pacnew file for phpmyadmin, I noticed that the last line in the file was different. Mine had a closing brace

?>

and the new one did not.

I haven't even finished the merge and I don't expect any problems but ...

I searched for this issue and could not find it, which was a little surprising but this package was only just released a week ago so it's conceivable that nobody that uses phpmyadmin on Arch has tried merging yet.

Specifically, it's phpmyadmin 4.5.0.2-1 from Thu 01 Oct 2015 09:10:08 AM CDT

I'm not a regular on the forums so sorry about not using any fancy markup and I don't know how to tag or alert the packager except I guess I'll send a link to this post to their listed email address.

I don't anticipate any problems but if anybody can suggest a better way to report an issue like this, I will appreciate any feedback.

Thanks,

byte · 2015-10-09 22:21:51

My usual workflow for things like that goes like this:

What has changed and does it affect the local configuration? -> check the package diff -> link
Does the package modify the default/upstream config? -> check the PKGBUILD -> link
Everything vanilla/plain/default? Very good. So where's the upstream default config and what has changed? -> link1, link2 (Bingo!)

Oh, almost forgot:
> annual Arch Linux upgrade
Really? I wouldn't touch any rolling release distro if I'm not willing to update at least once a _week_.

Last edited by byte (2015-10-09 22:26:46)

wdrev · 2015-10-09 22:55:11

Byte,

Thank you for the links, they were very interesting. They were not pertinent to my post, however. Let me try again.

I think I found a bug in a pacnew configuration file. I am posting information about it here as a way of warning other users. I have also sent this link to this post to the person that made the package of that release to alert them.

Question: Is there a better way to submit an issue like this?

As an aside, I simply left the closing brace in the file and that particular issue is resolved. I don't honestly know if leaving it out will cause a problem since PHP is not one of my languages. I am having other issues with the phpmyadmin upgrade but I will post those separately if they appear to need posting. When it's all the way fixed and working perfectly, I'll post another update here to let readers know it was resolved as a user issue. It will be up to the package maintainers, I suppose, to take care of any bugs in the package.

Thanks.

At your service.

byte · 2015-10-09 22:59:40

Seems you didn't read the links, as THERE IS NO ISSUE.

wdrev · 2015-10-09 23:35:00

Honestly, one of the links was broken so it's not really accurate to say that it was not pertinent. I guess unhelpful is a better word. It was the one that went to a page with a picture of an angry looking pink unicorn on it.

So I'm not going to waste any more time on this. I'm not having a problem with it now and I seem to just be pissing people off so I'm not going to pursue it any further.

From the last comment, I'm guessing that leaving out the closing brace in PHP has no effect. So for any future users searching for this issue, that seems to be the answer.

I think the real issue now is that other Arch Linux users will end up wasting time when trying to merge the file. Maybe it would be a good idea, since we should expect other users to notice the same difference I did, to put a comment at the end of the file saying that it's okay to leave out the closing brace. That, however is the packager's call.

Thanks.

At your service.

mrunion · 2015-10-10 01:30:28

Leaving out the closing brace in PHP is a standard practice to prevent getting error messages on web pages about output being written to the stream already. It's not a problem, and it's not a bug. You did good in checking things before changing them, but in this case, there is no bug and all is well.

Arch Linux

#1 2015-10-09 21:31:48

The phpmyadmin config.inc.php.pacnew is missing the closing brace?

#2 2015-10-09 22:21:51

Re: The phpmyadmin config.inc.php.pacnew is missing the closing brace?

#3 2015-10-09 22:55:11

Re: The phpmyadmin config.inc.php.pacnew is missing the closing brace?

#4 2015-10-09 22:59:40

Re: The phpmyadmin config.inc.php.pacnew is missing the closing brace?

#5 2015-10-09 23:35:00

Re: The phpmyadmin config.inc.php.pacnew is missing the closing brace?

#6 2015-10-10 01:30:28

Re: The phpmyadmin config.inc.php.pacnew is missing the closing brace?

Board footer