Pleas verify my first PKGBUILD =)

Wabuo · 2015-11-28 14:16:24

Hey here is my first working PKGBUILD!
https://github.com/Wabuo/PKGBUILD/blob/ … g/PKGBUILD
I would love if you folks could approve it.

thx for your time Wabuo

Last edited by Wabuo (2015-11-28 14:17:00)

Allan · 2015-11-28 14:51:18

I'd give the source file a better name

source=(thea-the-awakening.zip::https://onedrive.live.com/download?resi....

Lone_Wolf · 2015-11-28 14:57:42

a few comments :

- your package doesn't compile from source,but installs pre-compiled binaries .
convention is to add "-bin" to the packagename to make that clear.

- no need to manually extract the zip-file in the prepare function ,makepkg can handle zip-files.
get rid of the prepare function, use something like this in sources array to improve readability :

"thea.zip::https://onedrive.live.com/download?resid=D09AAF078EFDC73D!2983&authkey=!AGxe3W4ByFCzWfs&ithint=file%2czip"

- the fact upstream doesn't provide checksums doesn't mean they will be useless.
using checksums will make it easier to verify users are downloading the same files you used.

generate them with updpkgsums.

- license=('custom: commercial')
for custom licenses you need to put the license file in the correct place.
check https://wiki.archlinux.org/index.php/Ar … s#Licenses

ADDED
PKGEXT=.pkg.tar
usually overriding user makepkg.conf setting is frowned upon.
I think i understand why you did it, but please add some comments making clear why you do this.

Last edited by Lone_Wolf (2015-11-28 15:02:07)

Wabuo · 2015-11-28 15:20:29

Thx for your answers!

Lone_Wolf wrote:

license=('custom: commercial')
for custom licenses you need to put the license file in the correct place.
check https://wiki.archlinux.org/index.php/Ar … s#Licenses

I would but there is non right now! There is only a steam forum post with a download link, what should I do in this case?

The developer wrote:

Thea the Linux version!
So, Khash mentioned in another thread that we are unable to support, or even test Thea on Linux, and sadly, nothing has changed here. But, we decided to make the Linux version, as it is, available to anyone who wants to play with it.
Now I will just say once more that we will not be supporting this version and we do not know how well it works as it is, but hey, if you want to check it out, its here and it's free.
If you decide to have a go at it, please do leave us some feedback. Who knows, maybe one day we'll be able to play with it ourselves and fix it up, but no promises!
Enjoy!
https://onedrive.live.com/redir?resid=D … file%2czip

About the "PKGEXT=.pkg.tar" - I forgot there ...

Last edited by Wabuo (2015-11-28 15:23:08)

Trilby · 2015-11-28 15:57:04

If there is no license, it is illegal to use it. Period.

You could, perhaps, just copy that forum post from the developer into a text file and call it a License. It grants permission, but it doesn't really establish ownership (and thus rights to grant permission).

bstaletic · 2015-11-28 18:12:54

Trilby wrote:

If there is no license, it is illegal to use it. Period.

Trilby, check:

pacman -Qi iana-etc

It says there's no license for it either. I wonder what that means.

Trilby · 2015-11-28 18:21:03

That is not software - that means nothing.

$ cat /usr/share/licenses/iana-etc/LICENSE
The contents of this package are inelligible for copyright protection.

Arch Linux

#1 2015-11-28 14:16:24

Pleas verify my first PKGBUILD =)

#2 2015-11-28 14:51:18

Re: Pleas verify my first PKGBUILD =)

#3 2015-11-28 14:57:42

Re: Pleas verify my first PKGBUILD =)

#4 2015-11-28 15:20:29

Re: Pleas verify my first PKGBUILD =)

#5 2015-11-28 15:57:04

Re: Pleas verify my first PKGBUILD =)

#6 2015-11-28 18:12:54

Re: Pleas verify my first PKGBUILD =)

#7 2015-11-28 18:21:03

Re: Pleas verify my first PKGBUILD =)

Board footer