libmpt: PKGBUILD for peer review [now in AUR]

eddy · 2006-04-24 21:53:23

Hi there
--Please move if not in right place--
This the first package that i have made, and am looking for some feedback if it is good enough for aur submission. The package is libmtp, which is used to access and transfer files from a mp3 player that requires 'play for sure' from M$.

# Contributor: Kev
pkgname=libmtp
pkgver=0.0.3
pkgrel=1
pkgdesc="library to make use of mtp"
url="http://libmtp.sourceforge.net"
depends=()
source=(http://dl.sourceforge.net/sourceforge/$pkgname/$pkgname-$pkgver.tar.gz) 
md5sum=(d34ab5b24ea6aa9eb9cf0eff53f05102)

build() {
  cd $startdir/src/$pkgname-$pkgver
  ./configure
  make || return 1
  make DESTDIR=$startdir/pkg install
}

Configure with --prefix= for safety (not liable for any damage)
Otherwise i can say that it works with my zen microphoto. I can copy files to and from it from cui.
What do you guys think of it?
Cheers[/code]

elasticdog · 2006-04-24 22:10:40

Looks fine to me...although I believe the <code>md5sum</code> value is supposed to be in quotes:

md5sum=('d34ab5b24ea6aa9eb9cf0eff53f05102')

T-Dawg · 2006-04-24 22:33:17

moved to making packages.

The md5sum doesn't have to be in quotes but it is good practice to do so with all array values in the PKGBUILD. Especially in depends() where you could have a dep as foo>=1.0. The `>=' will screw with bash if not put in quotes.

eddy · 2006-04-24 23:17:24

Thx for the advice and explanation for the '. Will add the ' to the md5sum.
cheers

tomk · 2006-04-24 23:25:09

eddy wrote:

Configure with --prefix= for safety

I'm not sure what you mean by that, but you have to use --prefix=/usr - if you don't, it will install to /usr/local, which is not permitted.

A few more things:
- it's md5sums, even if there's only one.
- libmtp depends on libusb, just like libgphoto2. namcap told me that.
- a libmtp.la libtool file is created, which is not required, as Arch got rid of libtool a good while ago, so you need the libtool-slay command at the end of your build:

find $startdir/pkg -name '*.la' -exec rm {} ;

elasticdog · 2006-04-25 00:59:45

Hot damn tomk is the packaging master! Note to self: learn more about compiling stuff by hand...

eddy · 2006-04-25 01:00:26

thx tomk
i meant with that to install to another direcectory so that one could see what it installed; eg. --prefix=home/foo
were foo is any directory you want.(was not that clear i agree)
Thx for the namcap hint I had libusb library already installed before.

a libmtp.la libtool file is created, which is not required, as Arch got rid of libtool a good while ago, so you need the libtool-slay command at the end of your build

=>Will add that.
Really apreciate the help
Cheers

eddy · 2006-04-25 03:26:57

This looks great So here is my final PKGBUILD. I will post this when i get up to the aur, if there are no more comments/suggestions that are made.(might add maintainer and email but will do that when i wake up and have read the aur submission guidelines).

#Contributor: Kev
pkgname=libmtp
pkgver=0.0.3
pkgrel=1
pkgdesc="library to make use of mtp"
url="http://libmtp.sourceforge.net"
depends=(libusb)
source=(http://dl.sourceforge.net/sourceforge/$pkgname/$pkgname-$pkgver.tar.gz) 
md5sums=('d34ab5b24ea6aa9eb9cf0eff53f05102')

build() {
  cd $startdir/src/$pkgname-$pkgver
  ./configure --prefix=/usr
  make || return 1
  make DESTDIR=$startdir/pkg install
  find $startdir/pkg -name '*.la' -exec rm {} ;
}

Thanks for you guys help.
Cheers

WillySilly · 2006-04-25 03:34:48

Also for future reference you can use options=('NOLIBTOOL') to replace using find $startdir/pkg -name '*.la' -exec rm {} ;

elasticdog · 2006-04-25 04:49:15

WillySilly wrote:

Also for future reference you can use options=('NOLIBTOOL') to replace using find $startdir/pkg -name '*.la' -exec rm {} ;

Wow! I didn't know that...is it documented anywhere (it doesn't appear to be on the ABS entry of the wiki)? Any other cool options aside from 'NOLIBTOOL'?

tomk · 2006-04-25 06:18:59

options=('NOLIBTOOL') is not documented anywhere yet, elasticdog, and in particular not in the makepkg man page, with the other options= - that's why I did not suggest it.

elasticdog · 2006-04-25 20:25:48

:oops: Hmmm...never noticed the options section of the man page before. Although it's true that the 'NOLIBTOOL' option isn't listed there.

options
              This  array  allows  you  to  override   some   of
              makepkg's  default  behaviour  when building pack-
              ages.  To set an option, just include  the  option
              name in the options array.

                            Available Options:

                     FORCE  force  the package to be upgraded by
                            --sysupgrade, even if its  an  older
                            version.

                     KEEPDOCS
                            do  not  remove  /usr/share/doc  and
                            /usr/share/info directories.

                     NOSTRIP
                            do not strip debugging symbols  from
                            binaries and libraries.

eddy · 2006-04-26 00:31:24

Thx WillySilly
I have used tomk's method for this one, but will take your method into consideration for some other time.
Cheers

AndyRTR · 2006-04-26 05:24:51

tomk wrote:

options=('NOLIBTOOL') is not documented anywhere yet, elasticdog, and in particular not in the makepkg man page, with the other options= - that's why I did not suggest it.

Shouldn't we add options=('NOLIBTOOL') as a default option to /etc/makepkg.conf?

WillySilly · 2006-04-26 05:28:23

AndyRTR wrote:

tomk wrote:
options=('NOLIBTOOL') is not documented anywhere yet, elasticdog, and in particular not in the makepkg man page, with the other options= - that's why I did not suggest it.
Shouldn't we add options=('NOLIBTOOL') as a default option to /etc/makepkg.conf?

No, many things like KDE and other packages still need the .la files. The PKGBUILD option is best IMHO.

Arch Linux

#1 2006-04-24 21:53:23

libmpt: PKGBUILD for peer review [now in AUR]

#2 2006-04-24 22:10:40

Re: libmpt: PKGBUILD for peer review [now in AUR]

#3 2006-04-24 22:33:17

Re: libmpt: PKGBUILD for peer review [now in AUR]

#4 2006-04-24 23:17:24

Re: libmpt: PKGBUILD for peer review [now in AUR]

#5 2006-04-24 23:25:09

Re: libmpt: PKGBUILD for peer review [now in AUR]

#6 2006-04-25 00:59:45

Re: libmpt: PKGBUILD for peer review [now in AUR]

#7 2006-04-25 01:00:26

Re: libmpt: PKGBUILD for peer review [now in AUR]

#8 2006-04-25 03:26:57

Re: libmpt: PKGBUILD for peer review [now in AUR]

#9 2006-04-25 03:34:48

Re: libmpt: PKGBUILD for peer review [now in AUR]

#10 2006-04-25 04:49:15

Re: libmpt: PKGBUILD for peer review [now in AUR]

#11 2006-04-25 06:18:59

Re: libmpt: PKGBUILD for peer review [now in AUR]

#12 2006-04-25 20:25:48

Re: libmpt: PKGBUILD for peer review [now in AUR]

#13 2006-04-26 00:31:24

Re: libmpt: PKGBUILD for peer review [now in AUR]

#14 2006-04-26 05:24:51

Re: libmpt: PKGBUILD for peer review [now in AUR]

#15 2006-04-26 05:28:23

Re: libmpt: PKGBUILD for peer review [now in AUR]

Board footer