You are not logged in.

#1 2016-02-17 21:41:23

lykwydchykyn
Member
Registered: 2013-07-11
Posts: 91

[Review request] Tap-plugins-lv2-git

I'm working on a PKGBUILD for the LV2 port of Tom's Audio Processing Plugins (https://github.com/moddevices/tap-lv2).

I'm not so great at PKGBUILDs, but this one "works on my machine"™.

Please comment if you see any improvements I should make:

pkgname=tap-plugins-lv2-git
pkgver=r95.de26a3c
pkgrel=1
pkgdesc="LV2 port for the TAP (Tom's Audio Processing) plugins"
arch=('i686' 'x86_64')
url="https://github.com/moddevices/tap-lv2"
# Package-Version: 20150811.1308
license=('GPL')
groups=('audio')
depends=("lv2")
makedepends=()
checkdepends=()
optdepends=()
provides=()
conflicts=()
replaces=()
backup=()
options=()
install=
changelog=
source=("git+https://github.com/moddevices/tap-lv2.git")
noextract=()
md5sums=('SKIP')
_reponame="tap-lv2"


pkgver() {

  cd "${srcdir}"/"${_reponame}"
  printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short HEAD)"

}

#prepare() {
#}

build() {
  cd "$srcdir/${_reponame}"

  make INSTALL_PATH=/usr/lib/lv2
}

#check() {
#  cd "$srcdir/${_reponame}"
#
#  make -k check
#}

package() {
  cd "$srcdir/${_reponame}"

  make INSTALL_PATH=/usr/lib/lv2 DESTDIR="$pkgdir/" install
}

One thing I couldn't find was a list of dependencies.  I've browsed through the project's makefiles and READMEs, but couldn't find a list of requirements.  It compiled on my machine but I've got so much audio stuff I probably already have all the dependencies.

Last edited by lykwydchykyn (2016-02-17 21:45:01)

Offline

#2 2016-02-17 22:12:11

eschwartz
Fellow
Registered: 2014-08-08
Posts: 4,097

Re: [Review request] Tap-plugins-lv2-git

1) Get rid of the variables and functions you aren't using.

2) Try compiling in a clean chroot using makechrootpkg from devtools. It is what the official repositories use to build packages, in order to ensure dependencies are properly accounted for.
You can even have makechrootpkg install the package -- then chroot into it and test the package to make sure it has all its functionality.


Managing AUR repos The Right Way -- aurpublish (now a standalone tool)

Offline

#3 2016-02-17 22:50:54

lykwydchykyn
Member
Registered: 2013-07-11
Posts: 91

Re: [Review request] Tap-plugins-lv2-git

Thanks.  It seems I need to specify glibc as a depends, and lv2 and git as makedepends.  This is what I've got now:

pkgname=tap-plugins-lv2-git
pkgver=r95.de26a3c
pkgrel=1
pkgdesc="LV2 port for the TAP (Tom's Audio Processing) plugins"
arch=('i686' 'x86_64')
url="https://github.com/moddevices/tap-lv2"
# Package-Version: 20150811.1308
license=('GPL')
groups=('audio')
depends=("glibc")
makedepends=("git" "lv2")
source=("git+https://github.com/moddevices/tap-lv2.git")
md5sums=('SKIP')
_reponame="tap-lv2"


pkgver() {

  cd "${srcdir}"/"${_reponame}"
  printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short HEAD)"

}

build() {
  cd "$srcdir/${_reponame}"

  make INSTALL_PATH=/usr/lib/lv2
}

package() {
  cd "$srcdir/${_reponame}"

  make INSTALL_PATH=/usr/lib/lv2 DESTDIR="$pkgdir/" install
}

When I build it, I get this warning:

tap-plugins-lv2-git W: File (.BUILDINFO) exists in a non-standard directory.

Is that anything to be concerned about?
EDIT: Looks like a namcap bug: https://bugs.archlinux.org/task/47982

Last edited by lykwydchykyn (2016-02-17 22:52:18)

Offline

Board footer

Powered by FluxBB