Consider 'pull request' github model in AUR

Trilby · 2016-03-04 13:00:23

I agree with both of Awebb's comments. This seems like a lot of work (or even if it's just a little work) for nothing.

It doesn't matter what tools you come up with, fields you add, or technologies you invent: you can't fix stupid.

These ideas would have absolutely no impact at all on bad maintainers - they simply will not add these fields, tools, whatever. And these steps aren't needed for good maintainers - but they'd probably do them anyways. As for users, this would not benefit any users as - again - the packagers that follow these policies would already be following other policies, so this wouldn't help.

All this would really do is add a little extra work for only those maintainers who are already doing everything they are supposed to for the benefit of giving users of bad packages yet another way to fruitlessly vent their frustration.

Lone_Wolf · 2016-03-04 13:12:52

mkaczanowski wrote:

@Lone_Wolf how can you pin comment? I don't see it

Only maintainer / co-maintainer have that option .

progandy · 2016-03-04 13:26:55

I must agree with Awebb, if a maintainer doesn't react to an OOD notification, then a pull request doesn't help either. Orphan requests are mostly granted when there is no reaction to an OOD flag. A pull request doesn't change this waiting time.

By the way, I really don't understand why an interface for forks and/or pull requests is needed, but then I am fairly used to the git workflow and don't need handholding. A fork and a pull request can be created without needing a fancy web interface. You just need a public git repository where you can publish your changes.

git clone $URL_REPO_AUR_PKG # (create local fork)
git checkout -b $BRANCH_BUGFIX # (create branch for bugfixes)
... edit / add / commit ... 
git remote add $REPO_MY_FORK $URL_REPO_MY_FORK # (define public repository url, e.g. on github)
git push $REPO_MY_FORK # (publish changes)
git request-pull master $REPO_MY_FORK $BRANCH_BUGFIX # (create request template)
... send mail / comment ... # send pull request

Last edited by progandy (2016-03-04 13:37:58)

eschwartz · 2016-03-04 15:28:15

Lone_Wolf wrote:

mkaczanowski wrote:
@Lone_Wolf how can you pin comment? I don't see it
Only maintainer / co-maintainer have that option .

I co-maintain qbittorrent-git and I cannot pin a comment.

eschwartz · 2016-03-04 15:30:32

progandy wrote:

By the way, I really don't understand why an interface for forks and/or pull requests is needed, but then I am fairly used to the git workflow and don't need handholding. A fork and a pull request can be created without needing a fancy web interface. You just need a public git repository where you can publish your changes.

Exactly.
All the interface does is offer an easy one-click way to merge changes you would've known about and merged anyway.

Lone_Wolf · 2016-03-05 14:55:51

Eschwartz wrote:

Lone_Wolf wrote:
mkaczanowski wrote:
@Lone_Wolf how can you pin comment? I don't see it
Only maintainer / co-maintainer have that option .
I co-maintain qbittorrent-git and I cannot pin a comment.

I just tested and you're right.Seems only maintainer can pin comments, time for a feature request ?

mkaczanowski · 2016-03-05 17:09:26

@progandy Huh, didn't know about that. Seems to be useful
I would still have maintainer repo in URLs (sorry, as for me it should be there, rather looking into PKBUILD or comments).

@Lone_Wolf I am also co-maintainer of a package and I can't pin comment. Would that be possible to make pinning available for co-maintainers?

Awebb · 2016-03-05 22:57:22

Have I missed your mailing list post? Discussing this here is pointless.

jasonwryan · 2016-03-05 23:13:22

Awebb wrote:

Have I missed your mailing list post? Discussing this here is pointless.

This has been pointed out to OP a couple of times already... This is starting to feel like bikeshedding.

eschwartz · 2016-03-06 01:40:27

@Lone_Wolf, @mkaczanowski

It was determined that co-maintainers would not get to pin comments. The relevant mailing list post is HERE.

As has been pointed out several times, discussing it here is pointless, but feel free to ask on the mailing list if you feel strongly about this or anything else.

Arch Linux

#26 2016-03-04 13:00:23

Re: Consider 'pull request' github model in AUR

#27 2016-03-04 13:12:52

Re: Consider 'pull request' github model in AUR

#28 2016-03-04 13:26:55

Re: Consider 'pull request' github model in AUR

#29 2016-03-04 15:28:15

Re: Consider 'pull request' github model in AUR

#30 2016-03-04 15:30:32

Re: Consider 'pull request' github model in AUR

#31 2016-03-05 14:55:51

Re: Consider 'pull request' github model in AUR

#32 2016-03-05 17:09:26

Re: Consider 'pull request' github model in AUR

#33 2016-03-05 22:57:22

Re: Consider 'pull request' github model in AUR

#34 2016-03-05 23:13:22

Re: Consider 'pull request' github model in AUR

#35 2016-03-06 01:40:27

Re: Consider 'pull request' github model in AUR

Board footer