You are not logged in.

#1 2016-05-17 04:48:52

cmrx64
Member
Registered: 2013-02-18
Posts: 4
Website

PKGBUILD review request: asciidocfx

# Maintainer: Corey Richardson <corey@octayn.net>
pkgname=asciidocfx
pkgver=1.4.5
pkgrel=1
pkgdesc="Asciidoc Editor and Toolchain written with JavaFX 8"
arch=('any')
url="http://asciidocfx.com/"
license=('Apache')
groups=()
# NOTE: unbundle the maven dependencies eventually?
depends=('java-environment=8' 'java-openjfx>=8.u76')
makedepends=('maven>=3.3.9' 'java-environment-openjdk=8')
optdepends=()
provides=()
conflicts=()
replaces=()
backup=()
options=()
install=
changelog=
source=("https://github.com/asciidocfx/AsciidocFX/archive/v$pkgver.tar.gz"
        'asciidocfx')
noextract=()
md5sums=('13dab325992739e814cb557639b562b3'
         'c59a3472f37e2c20926c332aea4b94c9')

build() {
  cd "AsciidocFX-$pkgver"

  # "install" seemingly means "build and ready for installation"
  mvn clean install
}

package() {
  cd "AsciidocFX-$pkgver"

  mkdir -p "$pkgdir/usr/share/java/asciidocfx"
  mkdir -p "$pkgdir/usr/bin"
  mv -t "$pkgdir/usr/share/java/asciidocfx" target/appassembler/{conf,lib}
  install -m775 ../asciidocfx "$pkgdir/usr/bin/asciidocfx"
}

With the bin script:

#!/bin/sh
BASEDIR=/usr/share/java/asciidocfx
for name in $BASEDIR/lib/*.jar; do
  CP=$CP:$name
done

exec /usr/bin/java -cp $CP -Duser.language=en -Duser.country=US -XX:+UseG1GC \
  -Dapp.name="asciidocfx" \
  -Dapp.pid="$$" \
  -Dapp.repo="$BASEDIR/lib" \
  -Dapp.home="$BASEDIR" \
  -Dbasedir="$BASEDIR" \
  com.kodcu.boot.AppStarter \
  "$@"

Open question: should I go to any length to try and use Arch dependencies for some of the Maven dependencies? At least a few look like they have compatible versions. It's not clear to me how to convince maven to use the system deps, or if it's possible. I don't understand these tools, I am just forced to use them sometimes smile

Offline

#2 2016-05-17 10:06:51

mis
Member
Registered: 2016-03-16
Posts: 234

Re: PKGBUILD review request: asciidocfx

cmrx64 wrote:

Open question: should I go to any length to try and use Arch dependencies for some of the Maven dependencies?
.....
It's not clear to me how to convince maven to use the system deps, or if it's possible.

I'm not sure what you mean with this.

Another thing: You should remove all the unused variables
groups=()
optdepends=()
etc..

edit:
And it's considered good practice to use  install -dm755 instead of mkdir -p I think.

Last edited by mis (2016-05-17 10:13:56)

Offline

#3 2016-05-17 10:26:58

cmrx64
Member
Registered: 2013-02-18
Posts: 4
Website

Re: PKGBUILD review request: asciidocfx

mis wrote:
cmrx64 wrote:

Open question: should I go to any length to try and use Arch dependencies for some of the Maven dependencies?
.....
It's not clear to me how to convince maven to use the system deps, or if it's possible.

I'm not sure what you mean with this.

Maven will download and bundle all of the jars needed as dependencies (82 of them, taking up 36MiB). Some of those jars are available in Arch packages. Can Maven be made aware of them? If so, does it matter?

Offline

#4 2016-05-17 14:50:37

mis
Member
Registered: 2016-03-16
Posts: 234

Re: PKGBUILD review request: asciidocfx

Do you mean the files in the maven package?

Well ,all packages you put in depends=() and makedepends=() are Arch packages.
I still don't get what your question is. wink

Last edited by mis (2016-05-17 14:50:52)

Offline

#5 2016-05-18 22:45:35

Lone_Wolf
Member
From: Netherlands, Europe
Registered: 2005-10-04
Posts: 11,868

Re: PKGBUILD review request: asciidocfx

this is part of what mvn clean install does:

==> Starting build()...
[INFO] Scanning for projects...
Downloading: http://repo1.maven.org/maven2/org/springframework/boot/spring-boot-starter-parent/1.3.1.RELEASE/spring-boot-starter-parent-1.3.1.RELEASE.pom
Downloaded: http://repo1.maven.org/maven2/org/springframework/boot/spring-boot-starter-parent/1.3.1.RELEASE/spring-boot-starter-parent-1.3.1.RELEASE.pom (7 KB at 30.1 KB/sec)
Downloading: http://repo1.maven.org/maven2/org/springframework/boot/spring-boot-dependencies/1.3.1.RELEASE/spring-boot-dependencies-1.3.1.RELEASE.pom
Downloaded: http://repo1.maven.org/maven2/org/springframework/boot/spring-boot-dependencies/1.3.1.RELEASE/spring-boot-dependencies-1.3.1.RELEASE.pom (72 KB at 1465.2 KB/sec)
Downloading: http://repo1.maven.org/maven2/org/springframework/spring-framework-bom/4.2.4.RELEASE/spring-framework-bom-4.2.4.RELEASE.pom
Downloaded: http://repo1.maven.org/maven2/org/springframework/spring-framework-bom/4.2.4.RELEASE/spring-framework-bom-4.2.4.RELEASE.pom (5 KB at 161.3 KB/sec)
Downloading: http://repo1.maven.org/maven2/org/springframework/data/spring-data-releasetrain/Gosling-SR2A/spring-data-releasetrain-Gosling-SR2A.pom
Downloaded: http://repo1.maven.org/maven2/org/springframework/data/spring-data-releasetrain/Gosling-SR2A/spring-data-releasetrain-Gosling-SR2A.pom (5 KB at 127.4 KB/sec)
Downloading: http://repo1.maven.org/maven2/org/springframework/data/build/spring-data-build/1.7.3.RELEASE/spring-data-build-1.7.3.RELEASE.pom
Downloaded: http://repo1.maven.org/maven2/org/springframework/data/build/spring-data-build/1.7.3.RELEASE/spring-data-build-1.7.3.RELEASE.pom (3 KB at 81.2 KB/sec)
Downloading: http://repo1.maven.org/maven2/org/springframework/integration/spring-integration-bom/4.2.4.RELEASE/spring-integration-bom-4.2.4.RELEASE.pom
Downloaded: http://repo1.maven.org/maven2/org/springframework/integration/spring-integration-bom/4.2.4.RELEASE/spring-integration-bom-4.2.4.RELEASE.pom (9 KB at 258.4 KB/sec)
Downloading: http://repo1.maven.org/maven2/org/springframework/security/spring-security-bom/4.0.3.RELEASE/spring-security-bom-4.0.3.RELEASE.pom
Downloaded: http://repo1.maven.org/maven2/org/springframework/security/spring-security-bom/4.0.3.RELEASE/spring-security-bom-4.0.3.RELEASE.pom (5 KB at 128.5 KB/sec)
[INFO]                                                                         
[INFO] ------------------------------------------------------------------------
[INFO] Building AsciidocFX 1.4.5
[INFO] ------------------------------------------------------------------------
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.pom (4 KB at 5.2 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-plugins/22/maven-plugins-22.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-plugins/22/maven-plugins-22.pom (13 KB at 318.3 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/maven-parent/21/maven-parent-21.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/maven-parent/21/maven-parent-21.pom (26 KB at 627.8 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/apache/10/apache-10.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/apache/10/apache-10.pom (15 KB at 401.4 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.jar
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.jar (25 KB at 687.3 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-resources-plugin/2.6/maven-resources-plugin-2.6.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-resources-plugin/2.6/maven-resources-plugin-2.6.pom (8 KB at 240.1 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-plugins/23/maven-plugins-23.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-plugins/23/maven-plugins-23.pom (9 KB at 272.2 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/maven-parent/22/maven-parent-22.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/maven-parent/22/maven-parent-22.pom (30 KB at 806.8 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/apache/11/apache-11.pom
Downloaded: https://repo.maven.apache.org/maven2/org/apache/apache/11/apache-11.pom (15 KB at 438.3 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-resources-plugin/2.6/maven-resources-plugin-2.6.jar
Downloaded: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-resources-plugin/2.6/maven-resources-plugin-2.6.jar (29 KB at 900.8 KB/sec)
Downloading: https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-compiler-plugin/3.1/maven-compiler-plugin-3.1.pom

Disliking systemd intensely, but not satisfied with alternatives so focusing on taming systemd.


(A works at time B)  && (time C > time B ) ≠  (A works at time C)

Offline

#6 2016-05-21 10:31:50

mis
Member
Registered: 2016-03-16
Posts: 234

Re: PKGBUILD review request: asciidocfx

Ah, now I see. Thanks Lone_Wolf.

cmrx64 wrote:

Open question: should I go to any length to try and use Arch dependencies for some of the Maven dependencies? At least a few look like they have compatible versions. It's not clear to me how to convince maven to use the system deps, or if it's possible. I don't understand these tools, I am just forced to use them sometimes.

I don't know if it's possible. I'm not very familiar with java / maven as well. wink

Offline

#7 2016-06-11 13:00:05

Stefan Husmann
Member
From: Germany
Registered: 2007-08-07
Posts: 1,391

Re: PKGBUILD review request: asciidocfx

Java packaging really can be a mess, and there are no very comprehensive guidelines. So it might be best advice to follow what upstream wants us to do. In the tarballs they distribute all the libs are included  also, so you might have done a good job.

But unfortunately when I use your PKGBUILD to build and install the package and run asciidocfx, the program itself is not behaving very well. I took me only a few minutes to have a system crash where only a rude reboot helped me, because everything was hanging.

Offline

#8 2016-06-11 21:07:47

cmrx64
Member
Registered: 2013-02-18
Posts: 4
Website

Re: PKGBUILD review request: asciidocfx

Stefan Husmann wrote:

Java packaging really can be a mess, and there are no very comprehensive guidelines. So it might be best advice to follow what upstream wants us to do. In the tarballs they distribute all the libs are included  also, so you might have done a good job.

But unfortunately when I use your PKGBUILD to build and install the package and run asciidocfx, the program itself is not behaving very well. I took me only a few minutes to have a system crash where only a rude reboot helped me, because everything was hanging.

That's quite surprising to me. I've been using it pretty heavily (writing a book) and haven't experienced anything like that. Do you have any more information about the nature of the hang? Was it memory exhaustion/swap?

Offline

Board footer

Powered by FluxBB