Anyone else experiencing segfaults in Thunar upon renaming a file?

jwhendy · 2016-03-06 16:01:01

Been getting this for a while and just applied the patch. There are some here confused with how to do it, so just thought I'd write it out explicitly. This assumes:
- you've installed abs via pacman
- you've sync'd abs
- your tree lives in /var/abs

$ cd ~/some/dir/to/build
$ cp -r /var/abs/extra/thunar ./
$ cd thunar

# open some editor and paste in the contents from @WFV's post above; then save it (I used thunar.patch)

# this downloads and unpacks the sources, along with any needed dependencies
$ makepkg -so

# copy vs. move, as the src folder will get overwritten if you update or use the -c option when installing with makepkg
# also, just use tab completion... this happens to be the Thunar-x.x.xx version now but will change
$ cp thunar.patch ./src/Thunar-1.6.10/
$ cd src/Thunar-1.6.10/
$ patch -p1 < ./thunar.patch

# you should get this output; if you don't, you might not be in the right directory
# use `ls` to make sure you see the README, THANKS, and thunar.patch files
patching file thunar/thunar-file.c
Hunk #1 succeeded at 851 (offset -2 lines).
Hunk #2 succeeded at 3852 (offset -2 lines).
patching file thunar/thunar-folder.c

# go back to the build directory
$ cd .../../ 

# I tend to add the -c option so that I don't have a bloated build folder; just use -si if you don't care
$ makepkg -sic

I actually haven't used it enough to know if it solves my crashing issue upon renaming, but I have high hopes and am glad I found this thread!

jwhendy · 2016-03-06 18:12:10

Well, assuming I did that patch right, this did not fix it for me. I was just renaming files and thunar crashed on me. Seems to happen after maybe 3-5 in a row? Can someone double check the above, propose a way to toubleshoot, and/or let me know if this is supposed to require a reboot? With thunar closed, ps ax doesn't return any hits so I don't think there's a daemon process that's supposed to need restarting. Shot in the dark.

WFV · 2016-03-06 23:28:43

# open some editor and paste in the contents from @WFV's post above; then save it (I used thunar.patch)

Apologies jwhendy, I removed the diffs text but looks like your patch ran correctly, don't know what happened with final product. Try downloading the package from comment #48 and run makepkg. Otherwise here is my PKGBUILD using the patch from the xfce bug site:

# $Id: PKGBUILD 241211 2015-06-22 21:18:12Z foutrelis $
# Maintainer: Evangelos Foutras <evangelos@foutrelis.com>
# Contributor: Andrew Simmons <andrew.simmons@gmail.com>

pkgname=thunar
pkgver=1.6.10
pkgrel=2
pkgdesc="Modern file manager for Xfce"
arch=('i686' 'x86_64')
url="http://thunar.xfce.org"
license=('GPL2' 'LGPL2.1')
groups=('xfce4')
depends=('desktop-file-utils' 'libexif' 'hicolor-icon-theme' 'libnotify'
         'libgudev' 'gtk2' 'exo' 'libxfce4util' 'libxfce4ui' 'libpng')
makedepends=('intltool' 'xfce4-panel')
optdepends=('gvfs: for trash support, mounting with udisk and remote filesystems'
            'xfce4-panel: for trash applet'
            'tumbler: for thumbnail previews'
            'thunar-volman: manages removable devices'
            'thunar-archive-plugin: create and deflate archives'
            'thunar-media-tags-plugin: view/edit id3/ogg tags')
install=$pkgname.install
source=(http://archive.xfce.org/src/xfce/$pkgname/${pkgver%.*}/Thunar-$pkgver.tar.bz2 Deactivate-SEND_MOVED-code-paths.patch::http://bug-attachment.xfce.org/attachment.cgi?id=6530)
sha256sums=('7e9d24067268900e5e44d3325e60a1a2b2f8f556ec238ec12574fbea15fdee8a'
            '2461773024336a94fd70d7f2276aec0f9fc819cb8af96c8689e42c429014ea7d')

prepare() {
  cd "$srcdir/Thunar-$pkgver"
  patch -Np1 -i "$srcdir/Deactivate-SEND_MOVED-code-paths.patch"
 }

build() {
  cd "$srcdir/Thunar-$pkgver"

  ./configure \
    --prefix=/usr \
    --sysconfdir=/etc \
    --enable-gio-unix \
    --enable-dbus \
    --enable-gudev \
    --enable-notifications \
    --enable-exif \
    --enable-pcre \
    --disable-debug
  make
}

package() {
  cd "$srcdir/Thunar-$pkgver"
  make DESTDIR="$pkgdir" install
}

# vim:set ts=2 sw=2 et:

jwhendy · 2016-03-07 00:12:29

@WFV: so far so good! I wonder if it's how I applied the patch? I was just using what appears to be the full version of your two patches (I think it's the same from this xfce bug attachment) combined. Still said it successfully patched 2 files, though I definitely get different results (used patch -Np1 -i file(s) for both):

### via my original method
patching file thunar/thunar-file.c
Hunk #1 succeeded at 851 (offset -2 lines).
Hunk #2 succeeded at 3852 (offset -2 lines).
patching file thunar/thunar-folder.c

### with the linked tar.bz2 containing file.patch and folder.patch
patching file thunar/thunar-file.c
Hunk #1 succeeded at 851 (offset -2 lines).
patch unexpectedly ends in middle of line
Hunk #2 succeeded at 3852 with fuzz 1 (offset -2 lines).
(Stripping trailing CRs from patch; use --binary to disable.)
patching file thunar/thunar-folder.c
patch unexpectedly ends in middle of line
Hunk #1 succeeded at 569 with fuzz 2.

No idea. Maybe I just copied/pasted wrongly (definitely have had patches act strangely when not in the right indent/format). Anyway, thanks for the help; glad to not have it crashing

WFV · 2016-03-07 00:25:28

@ jwhendy, ok, good, yes that is the bug attachment, radioactive man helped me with that earlier. I initially manually patched it by opening the file.c and the folder.c files in the tarball, edited the lines per the diff files (changed the lines to read what the fix does), closed it and then ran makepkg. For one like that it was fairly quick to manually edit, and required no patching and no editing the PKGBUILD. It worked and thunar was fixed, but then I went and redid it by radioactiveman's advice so to learn about patching packages, and it works too.

Last edited by WFV (2016-03-07 00:26:40)

paleRider · 2016-03-20 23:12:44

Installing the package from #48 fixed the issue for me. Thanks a lot for that... on my end, Thunar was crashing approximately once every 5 renames.

Alad · 2016-04-06 16:53:01

I've imported thunar-git from AUR3 where this should be fixed:

https://aur.archlinux.org/packages/thunar-git/

punk_physicist · 2016-04-06 18:44:59

Alad wrote:

I've imported thunar-git from AUR3 where this should be fixed

I still have the problem with the git version of Thunar (installed from AUR).

Alad · 2016-06-12 10:37:21

Added the patch to the thunar-git package

jwhendy · 2016-06-13 16:03:27

@Alad: are you sure that's the necessary patch? Your patch appears to only be a partial of what WFV uploaded a bit back (which solved it for me). I think I tried with the patch I see on your package, and it didn't work. WFV posted a download on page 2 of this thread which contains two patches. Alternatively, They look to match this patch, which comes from this bug report.

I haven't tried yours yet, but just wanted to comment so you could take a look. Not sure if you've experienced the bugs/tested your new version? If so, I could be wrong; just wanted to add my past experience with this.

Alad · 2016-06-23 20:47:28

edit: looks like I used the right patch name, but wrong URI... fixed, thanks.

Last edited by Alad (2016-06-23 20:52:43)

monuvik · 2016-07-18 13:45:16

Been using Thunar for so many years and couldn't take it anymore.

https://github.com/wifiextender/no_thunar_rename_crash

jwhendy · 2016-07-18 19:41:59

@minuvik: did you try the thunar-git package? The patches worked for me*, and would seem a lot easier than creating a custom rename function to replace a rename function... just a suggestion!

*Well, technically they worked using the PKGBUILD from page 2 (WFV's post) on the standard package. Technically I haven't tried with thunar-git as it didn't update in a while. Standard package just updated recently and I got crashes again, so it's on my todo list to switch to thunar-git to try out that method. Just saying the patches should work find from previous experience.

indianahorst · 2016-07-20 19:41:44

Thunar-git doesn't work for me:

$ pacaur -Qs Thunar
local/thunar-archive-plugin 0.3.1-6 (xfce4-goodies)
    Create and extract archives in Thunar
local/thunar-git 1.6.10.r140.g6b51ff3-1 (xfce4-git)
    file manager for xfce
local/thunar-media-tags-plugin 0.2.1-2 (xfce4-goodies)
    Adds special features for media files to the Thunar File Manager
local/thunar-volman 0.8.1-2 (xfce4)
    Automatic management of removeable devices in Thunar

Thunar-git just crashed while renaming a file:

From dmesg:

Thunar[801]: segfault at 0 ip 00007f2646d11356 sp 00007ffd74124108 error 4 in libc-2.23.so[7f2646c95000+197000]

Last edited by indianahorst (2016-07-20 19:42:25)

Joel · 2016-07-22 14:49:02

monuvik wrote:

Been using Thunar for so many years and couldn't take it anymore.
https://github.com/wifiextender/no_thunar_rename_crash

Why not as thunar plugin?

hb860 · 2016-07-22 21:34:11

hb860 wrote:

Well, for those who like me has troubles with Thunar patching, I made a set of files, actually it is just an official PKGBUILD which run the appropriate patch for thunar-file.c and thunar-folder.c.
Just put them all in any folder you want and run
makepkg
in that folder.
The patched Thunar package will be created, install it using pacman -U ./package.xz
http://rghost.net/6LfjMpkTf

I just uploaded the required files to github as well
It is here: https://github.com/tkaserg/thunar-no-rename-crash
Just moving my collection of patches there, so I think it worth mentioning here.
Also, I noticed recently that Thunar was updated (recompiled) in Arch Linux repos.
I suggest you to recompile the package instead of using binary files I provided. I think it can give you issues since they compiled against the "outdated" libs.
I also recompiled them for myself.

Last edited by hb860 (2016-07-22 21:36:33)

jwhendy · 2016-07-22 21:49:25

I don't want to be a party pooper as folks are putting in some great effort, but I still think centralized "official" methods are better than creating new github repos for each person's thunar variant.

The file and folder patches originated from this xfce bug report, I believe. It's also sourced by the AUR thunar-git package. This is significantly improved vs. relying on remembering which person's github thunar project works, or uploading to a random file hosting site that might or might not exist in x days/weeks/months when someone finds this thread. The versions of file.patch and folder.patch I've seen look to match the sections of the linked full patch when I've encountered them in people's links. Please let me know if this is incorrect and something new has emerged.

I think better approaches would be:
- improve upon Alad's thunar-git package as an AUR solution if it doesn't work for you currently
- submit an Arch bug report to have them build the extra/thunar package with this patch

0strodamus · 2016-07-26 03:26:57

Here's a PKGBUILD I've been using for the last 6 months or so without any more crashes. I'm using all the upstream patches released from 1.6.4 to 1.6.10 excluding the ones that looked to me like culprits for the crashes. I just thought I would post this here in case someone else finds it useful.

# Maintainer: 0strodamus <0strodamus at cox dot net>
# Maintainer: Evangelos Foutras <evangelos@foutrelis.com>
# Contributor: Andrew Simmons <andrew.simmons@gmail.com>
#
# version built to downgrade Arch PKGBUILD 1.6.10-2 to 1.6.4
# with upstream patches that don't seem to cause crashes
#
# built without wallpaper plugin and startup notification

pkgname=thunar-old
_pkgname=thunar
pkgver=1.6.4
pkgrel=1
pkgdesc="Modern file manager for Xfce"
arch=('i686' 'x86_64')
url="http://thunar.xfce.org"
license=('GPL2' 'LGPL2.1')
groups=('xfce4')
depends=('desktop-file-utils' 'libexif' 'hicolor-icon-theme' 'libnotify'
         'udev' 'gtk2' 'exo' 'libxfce4util' 'libxfce4ui' 'libpng')
makedepends=('intltool' 'gtk-doc' 'xfce4-panel')
optdepends=('gvfs: for trash support, mounting with udisk and remote filesystems'
            'xfce4-panel: for trash applet'
            'tumbler: for thumbnail previews'
            'thunar-volman: manages removable devices'
            'thunar-archive-plugin: create and deflate archives'
            'thunar-media-tags-plugin: view/edit id3/ogg tags')
provides=('thunar')
conflicts=('thunar')
replaces=('thunar')
source=("http://archive.xfce.org/src/xfce/$_pkgname/1.6/Thunar-$pkgver.tar.bz2"
        "001-right-click-context-menu-with-wrong-icon-bug-10652.patch::http://git.xfce.org/users/hjudt/thunar/patch/?id=da6e0addf2c5fdbf458cbdb3f3dc025945e03458"
        "002-add-a-progressbar-to-the-freespace-indicator-in-the-properties-dialog.patch::http://git.xfce.org/xfce/thunar/patch/?id=e07d6d8ef624abad1f3f2e9e3b1b4398b09dfa62"
        "003-make-usage-free-string-more-clear-bug-11345.patch::http://git.xfce.org/xfce/thunar/patch/?id=7fde0c0a35dca940e763361216c1da263748adcb"
        "004-change-resize-style-in-thunar-wallpaper-plugin.patch::http://git.xfce.org/xfce/thunar/patch/?id=e4519197b35824a82d57c45b354a1e5fd2c80b25"
        "005-use-xfconf-and-handle-xfdesktops-single-workspace-bug-11047.patch::http://git.xfce.org/xfce/thunar/patch/?id=378c9bcae2afa0c723142e67bc9d47af33f8d323"
        "006-single-workspace-mode-true-is-the-default-bug-11047.patch::http://git.xfce.org/xfce/thunar/patch/?id=00ddf79a47a4f14354039e7081d78b3ced8764a2"
        "007-improve-keyboard-navigation-for-thunar-tree-view-bug-4519.patch::http://git.xfce.org/users/hjudt/thunar/patch/?id=63b935ca42cb583cd64da99560aa7fce8d85d77b"
        "008-do-not-execute-but-only-open-shell-scripts-by-default-bug-7596.patch::http://git.xfce.org/users/hjudt/thunar/patch/?id=ed2274884c25e4e689982c7756d21b5c230d03bc"
        "009-fix-endless-rename-loop-in-case-of-error-on-the-properties-dialog-bug-11557.patch::http://git.xfce.org/xfce/thunar/patch/?id=2733416ce2ddc6118126a12f7c951830592b8f13"
        "010-improve-check-for-shell-scripts-and-add-hidden-option-for-bug-7596.patch::http://git.xfce.org/users/hjudt/thunar/patch/?id=8b2fd5738e8f2e64b37e3bd3f5073845091e13c7"
        "011-fix-updating-custom-actions-bug-11749.patch::http://git.xfce.org/users/hjudt/thunar/patch/?id=d19eccf82cf56e0470c4c0f55a86b4c3d1bb9276"
        "012-secure-threading-in-the-idle-thumbnail-loading.patch::http://git.xfce.org/xfce/thunar/patch/?id=6e883379e32403a4ef540f5999376ff31b388218"
        "013-dont-use-deprecated-function.patch::http://git.xfce.org/xfce/thunar/patch/?id=c0d3a2b3297b17cfa02b00ad6ad2b6d333e5e8b6"
        "014-fix-icon-name-for-folders-and-a-memory-leak-bug-11608.patch::http://git.xfce.org/users/hjudt/thunar/patch/?id=c6d983403e686ed42579cf08d66329fea54947c3"
        "015-fix-some-gtk-stock-icon-usages-resulting-in-missing-icons-bug-11608.patch::http://git.xfce.org/xfce/thunar/patch/?id=eaeb66a587de0e9cc79c3ff902949877eedf6d32"
        "016-respect-the-view-new-folders-using-preference-bug-11606.patch::http://git.xfce.org/xfce/thunar/patch/?id=c10e1ce9039245659edb2d6c0daab7b73078071b"
        "017-bump-default-size-of-file-properties-dialog-a-bit.patch::http://git.xfce.org/xfce/thunar/patch/?id=3d9bc5c685497c3cf674fb37ed2c25aad2e8ec52"
        "018-removed-gnu-extension-i-from-sed.patch::http://git.xfce.org/xfce/thunar/patch/?id=d57c68f3f83a0ddc078465d17c3f5e982de359bd"
        "019-fix-startup-id-handling-for-launch-requests-over-d-bus-bug-9646.patch::http://git.xfce.org/xfce/thunar/patch/?id=03ed0b6fff9a740f2f8971770ba03d0d4f6af718"
        "020-thunar-thunar-dbus-service-infos-xml-corrections.patch::http://git.xfce.org/xfce/thunar/patch/?id=f780cd41417742445a4b76918da52383bbcae0ba"
        "021-remove-duplicate-break-statement-in-thunar-standard-view.patch::http://git.xfce.org/xfce/thunar/patch/?id=a89c83ff1d3a471dc654eb754ea36d482048e897"
        "022-fix-gdk-critical-error.patch::http://git.xfce.org/xfce/thunar/patch/?id=0f5aa4d038886d5c39306f0f95ca8babf4bc3586"
        "023-fix-typo-in-thunar-clipboard-manager.patch::http://git.xfce.org/xfce/thunar/patch/?id=5734f1291710e1b520473c748265a865cfc673b1"
        "024-fix-typo-busy-pulse-in-thunar-shortcuts-model-c.patch::http://git.xfce.org/xfce/thunar/patch/?id=b11cc715a06d99022d6e308e27d166cd030a510d"
        "025-restore-file-selection-when-changing-sort-order-bug-9886.patch::http://git.xfce.org/xfce/thunar/patch/?id=079712fb0472b4cf5add1c206164b90f18554abe"
        "026-remember-and-restore-file-selection-on-view-changes.patch::http://git.xfce.org/xfce/thunar/patch/?id=07bb05707192f56eecdc46a9b976093540fd90b3"
        "027-improve-mouse-wheel-zoom-behaviour.patch::http://git.xfce.org/xfce/thunar/patch/?id=e01e135b749243ae13bb7905f619b248750f5f27"
        "028-implement-functions-for-copying-the-history-of-a-view.patch::http://git.xfce.org/xfce/thunar/patch/?id=b6ace36ceb84c9a1e8b4c616ae65862c50854e6e"
        "029-keep-the-history-across-view-changes-bug-10171.patch::http://git.xfce.org/xfce/thunar/patch/?id=ad8dd9c351ded0fd0d2c15fba40ec0fc9c6e4598"
        "030-make-new-tabs-inherit-the-history-of-the-origin-view-bug-5538.patch::http://git.xfce.org/xfce/thunar/patch/?id=aa5f8fca0e6e965a9592da30c36d2fa4afe44746"
        "031-make-new-windows-inherit-the-history-of-the-origin-view-bug-5538.patch::http://git.xfce.org/xfce/thunar/patch/?id=39baae0d7470884f8f6b7a6da263bb0bba4d2b3a"
        "032-fix-typos-and-grammar-mistakes-in-a-few-comments.patch::http://git.xfce.org/xfce/thunar/patch/?id=704f6127dc77e5e93b08c8589cde5ecc35da2f69"
        "033-update-the-location-bar-after-reload-bug-10518.patch::http://git.xfce.org/xfce/thunar/patch/?id=c4304a63a39dee18fda78027ca576cf292f3a27f"
        "034-for-folders-copied-always-append-copy-x-to-the-end-of-their-names-bug-11862.patch::http://git.xfce.org/xfce/thunar/patch/?id=e232de51d70cacfa67afaed4962c0a43ebca5697"
        "035-remove-unmounted-files-from-history-when-going-back-or-forward.patch::http://git.xfce.org/xfce/thunar/patch/?id=bf52f14ac84adf396cb007222017a2188e18d09b"
        "036-always-select-the-proper-toplevel-item-in-the-thunar-tree-view.patch::http://git.xfce.org/xfce/thunar/patch/?id=4abf5549f60e568c76a7bcf0fe20b5ec42271386"
        "037-revert-workaround-for-desktop-toplevel-item-in-the-tree-view.patch::http://git.xfce.org/xfce/thunar/patch/?id=a920087f9dae42b45d18e48e1a772458efbb9c39"
        "038-fix-tree-view-opening-mounted-devices-in-new-tab.patch::http://git.xfce.org/xfce/thunar/patch/?id=0aa296f5fa364600a3065673d08eace3290e9847"
        "039-fix-wrong-network-icon-shown-in-tree-view.patch::http://git.xfce.org/xfce/thunar/patch/?id=faff718b7cdc5cee2597f71e63102384ab21776a"
        "040-remember-the-last-used-application-when-opening-files.patch::http://git.xfce.org/xfce/thunar/patch/?id=5df98970639d472733910a391ddf186497bf8d03"
        "041-remember-chosen-application-in-the-chooser-dialog-as-last-used.patch::http://git.xfce.org/xfce/thunar/patch/?id=4fb5e8b12be02390e2c01e691c73a30a16e77ad6"
        "042-disable-Set-as-default-application-by-default-in-the-chooser-dialog.patch::http://git.xfce.org/xfce/thunar/patch/?id=51b7e607aaf854d970a6241760b2852f5ec8ef10"
        "043-fix-thunarbulkrename-script-not-supporting-spaces-bug-9713.patch::http://git.xfce.org/xfce/thunar/patch/?id=a438997fe7fbeaf62c0cb3ee674eaf00a17c4a8f")
sha256sums=('40efc74349313c20cef2047842a06ad8dfc8522ed792a087e9fb4618ad309dae'
            'ffefd4ac4be74f5ff55a40264ebcda4c8e9ca74809ab1d4a70b39036b85b8376'
            '26dc412323409e6c17c4b5c808cb5e06e35b4e60431073d30b2c35867690d9ad'
            '1ecd47d0d8f82419ff724e7b0e645bc15f43debf70671a7438622f77ef6f5220'
            '2fa545382fee72554863602b76c16e17b2ddf6d8d0009e688df20941dbfb7b31'
            '7d7583f8a6f06b9765798827e60558bc33d33930dee8d2d0148338c9b5ec1a2c'
            'fcb8b38d17ae08ec10c598db262a7f23126eff42ecaad554bef2bf9767ea9803'
            'b1fb0fcc367dda3996e8f485348d21df9505f3b29190fe3c0215e2caa4c704f4'
            '162760114f68867f7b5e4bd0af20f896d16733f7e543e1210d37f57ab0df9c8f'
            '2494290bc1ae6b1d16432377952c403c6fbb169447f78688ede4c33d3f59ba47'
            '9c4dbc04fc0b276b43d10ef1da783cd5293fd2e9d770f9738e871fdc9ede8f10'
            '581727a061aa14a43c2896bae8c0d9a4d1f075e45f9950e3911a93c68fa3cffe'
            '53f38a7a6ad155cdbb2f8c05490b456c0b0336446abc3b2b10d249f459f437f3'
            'd97e567e8f3d5ae6eaac3e5b60d9503af3e17ac4c96ec3e49ed689655b0ae004'
            '10558d7cfc9b98c79f8acad36cb54b3aebf36f784d0c216fdd45513520f66772'
            'f95b6969d5dc51201a6253a392d758c0da4c2daa921f147d5c0aab227675cf04'
            'df8d92a4895a6fc207d162c304ffa61244670023c8f21d77371d44c9f63aad86'
            'a23249721b32d197546f25724e4858f6e3510940b190cbf9a8fe073ed90af324'
            '80b113d8b6af2528a6d8cc7fefb2dd76defaa0693c50c3503e0ea400003fd880'
            '73b139233707517fd068244a9f5233e0ad655674394b3ea619047fc32d1e8cd5'
            '75c6a5a69e0c753876aa91b31fbe781d2c3b58ccbe9b1ec84dc9469bc2d249e8'
            '2481f2015584f6a49bdbb58e4dddea1c7193fe4a7715cef8be59e7dde09df411'
            '88c2b7f656fbe2cba10a63982263ba4e029a2abda20e8e41e5de90b46a0e14f7'
            '279eeaa5fd40d95f5ecb50db8f9ce8e3d692c8fb586d0bb6a022400c3c62bf33'
            '80c60025876a09ef493c638d67964e00a0b8cd81d15efeebe5c2307e0ced6b12'
            '88500011696bb178c03dbf37b01abc5ea104286d170054cb44a2f95d204c4c4e'
            'a9103aafe9e3b6a869aba84da08a992c6f5e0d1fcbda2e5943dcfb24cb087be5'
            '62c582245e6c1d7dfcb392ecca723520aeb61e082a92aa3c826f2601e831a381'
            '29baa7dba3a0e9a82992268bccadf5090d2f23e0c35f6ab828981df1ed11f674'
            '248506a5f5033edc326a98026745c1d11d8331301fa41c03cef17f8ecd768025'
            '02e6c046681ab8b946136d548d775ae1d6444715549bc858479ff9c752cc7998'
            '62b38ff642663a7898a7e7a74289fbf69a2257cbd2e700ad140775ee6255270d'
            'cff8665345aa22cf6b4cd055d328d86afc8487f936d7a0fab316987626102fca'
            'd80c5b139e7014906cc13fb6cb38d191019d28007989ed3ab08955a036078093'
            'cc2f743a357a7e14e36699ced021ee3ea07d40f94a181ea6e4183bfb6f0ce59b'
            '2c4840edbe7e76dc3fc67952739a41a8ffde9a2ab2a507325692750b9c75a017'
            '14802e730d39c2622826112107d9be6c78e2d53f5b87b3c96eef1d2c208598f0'
            '73ebe9ca9f25e4f3a63e90bd3a8973c99a3230256b2b511c35ab03a9bbcbfa66'
            '722174673652499af8f07f57117dfdf859d0350acc4fc09c2ea2bd5f66ba0b50'
            '7c8ffeb936b1d47440a2f7f020bd48bad426a8f1ba7768727324e17c1cfe7251'
            'd8723efd223d475634ca57b28ce932d26474cf899fec44657bcb7f8559f1bebc'
            'e27afc2bd056fbf037d7f3ba21478248c27e4702dc79390a67148a2887c78b6f'
            'e7603e8e013f333cd9150f1e04c8271fb4d2cecd56ec9bb867b6ad623980626c'
            'c0b90cd8f7073116df529b5629c05d498a6b38ae965a337e33013e637e2a7cf1')

prepare() {
  cd "$srcdir/Thunar-$pkgver"
  patch -Np1 -i ../001-right-click-context-menu-with-wrong-icon-bug-10652.patch
  patch -Np1 -i ../002-add-a-progressbar-to-the-freespace-indicator-in-the-properties-dialog.patch
  patch -Np1 -i ../003-make-usage-free-string-more-clear-bug-11345.patch
  patch -Np1 -i ../004-change-resize-style-in-thunar-wallpaper-plugin.patch
  patch -Np1 -i ../005-use-xfconf-and-handle-xfdesktops-single-workspace-bug-11047.patch
  patch -Np1 -i ../006-single-workspace-mode-true-is-the-default-bug-11047.patch
  patch -Np1 -i ../007-improve-keyboard-navigation-for-thunar-tree-view-bug-4519.patch
  patch -Np1 -i ../008-do-not-execute-but-only-open-shell-scripts-by-default-bug-7596.patch
  patch -Np1 -i ../009-fix-endless-rename-loop-in-case-of-error-on-the-properties-dialog-bug-11557.patch
  patch -Np1 -i ../010-improve-check-for-shell-scripts-and-add-hidden-option-for-bug-7596.patch
  patch -Np1 -i ../011-fix-updating-custom-actions-bug-11749.patch
  patch -Np1 -i ../012-secure-threading-in-the-idle-thumbnail-loading.patch
  patch -Np1 -i ../013-dont-use-deprecated-function.patch
  patch -Np1 -i ../014-fix-icon-name-for-folders-and-a-memory-leak-bug-11608.patch
  patch -Np1 -i ../015-fix-some-gtk-stock-icon-usages-resulting-in-missing-icons-bug-11608.patch
  patch -Np1 -i ../016-respect-the-view-new-folders-using-preference-bug-11606.patch
  patch -Np1 -i ../017-bump-default-size-of-file-properties-dialog-a-bit.patch
  patch -Np1 -i ../018-removed-gnu-extension-i-from-sed.patch
  patch -Np1 -i ../019-fix-startup-id-handling-for-launch-requests-over-d-bus-bug-9646.patch
  patch -Np1 -i ../020-thunar-thunar-dbus-service-infos-xml-corrections.patch
  patch -Np1 -i ../021-remove-duplicate-break-statement-in-thunar-standard-view.patch
  patch -Np1 -i ../022-fix-gdk-critical-error.patch
  patch -Np1 -i ../023-fix-typo-in-thunar-clipboard-manager.patch
  patch -Np1 -i ../024-fix-typo-busy-pulse-in-thunar-shortcuts-model-c.patch
  patch -Np1 -i ../025-restore-file-selection-when-changing-sort-order-bug-9886.patch
  patch -Np1 -i ../026-remember-and-restore-file-selection-on-view-changes.patch
  patch -Np1 -i ../027-improve-mouse-wheel-zoom-behaviour.patch
  patch -Np1 -i ../028-implement-functions-for-copying-the-history-of-a-view.patch
  patch -Np1 -i ../029-keep-the-history-across-view-changes-bug-10171.patch
  patch -Np1 -i ../030-make-new-tabs-inherit-the-history-of-the-origin-view-bug-5538.patch
  patch -Np1 -i ../031-make-new-windows-inherit-the-history-of-the-origin-view-bug-5538.patch
  patch -Np1 -i ../032-fix-typos-and-grammar-mistakes-in-a-few-comments.patch
  patch -Np1 -i ../033-update-the-location-bar-after-reload-bug-10518.patch
  patch -Np1 -i ../034-for-folders-copied-always-append-copy-x-to-the-end-of-their-names-bug-11862.patch
  patch -Np1 -i ../035-remove-unmounted-files-from-history-when-going-back-or-forward.patch
  patch -Np1 -i ../036-always-select-the-proper-toplevel-item-in-the-thunar-tree-view.patch
  patch -Np1 -i ../037-revert-workaround-for-desktop-toplevel-item-in-the-tree-view.patch
  patch -Np1 -i ../038-fix-tree-view-opening-mounted-devices-in-new-tab.patch
  patch -Np1 -i ../039-fix-wrong-network-icon-shown-in-tree-view.patch
  patch -Np1 -i ../040-remember-the-last-used-application-when-opening-files.patch
  patch -Np1 -i ../041-remember-chosen-application-in-the-chooser-dialog-as-last-used.patch
  patch -Np1 -i ../042-disable-Set-as-default-application-by-default-in-the-chooser-dialog.patch
  patch -Np1 -i ../043-fix-thunarbulkrename-script-not-supporting-spaces-bug-9713.patch
}

build() {
  cd "$srcdir/Thunar-$pkgver"

  ./configure \
    --prefix=/usr \
    --sysconfdir=/etc \
    --libexecdir=/usr/lib \
    --localstatedir=/var \
    --disable-static \
    --enable-gio-unix \
    --enable-dbus \
    --disable-startup-notification \
    --enable-gudev \
    --enable-notifications \
    --enable-exif \
    --enable-pcre \
    --enable-gtk-doc \
    --disable-debug \
    --disable-wallpaper-plugin
  make
}

package() {
  cd "$srcdir/Thunar-$pkgver"

  make DESTDIR=${pkgdir} install
  sed -i 's:x-directory/gnome-default-handler;::' \
    "$pkgdir/usr/share/applications/Thunar-folder-handler.desktop"
}

Alad · 2016-07-26 14:58:16

Might as well use a git tag and git cherry-pick, if you're going this route. Though a git bisect, and git revert commits that broke, would be more helpful.

Last edited by Alad (2016-07-26 14:59:45)

rocketx86 · 2016-07-31 11:36:16

EDIT: Unfortunately this does not resolve the rename problem. I am still able to crash Thunar.

After several hours of debugging and testing, I uncovered an assertion failure in thunar-io-jobs.c in debug mode.

I have produced the following patch with a change to thunar_io_jobs_rename_file(...) and uploaded to bugzilla.xfce.org for further review.

If your still having trouble you may want to give this a try, but please use at your own risk until it is tested further.

--- Thunar-1.6.10/thunar/thunar-io-jobs.c	2015-05-22 13:25:36.000000000 +0000
+++ Thunar-1.6.10-fix/thunar/thunar-io-jobs.c	2016-08-01 11:07:09.016666668 +0000
@@ -1307,7 +1307,12 @@
 {
   _thunar_return_val_if_fail (THUNAR_IS_FILE (file), NULL);
   _thunar_return_val_if_fail (g_utf8_validate (display_name, -1, NULL), NULL);
-
+  
+  if (!THUNAR_IS_FILE (file))
+    {
+      return NULL;
+    }
+  
   return thunar_simple_job_launch (_thunar_io_jobs_rename, 2, 
                                    THUNAR_TYPE_FILE, file, 
                                    G_TYPE_STRING, display_name);

Last edited by rocketx86 (2016-08-02 18:21:12)

alex.forencich · 2017-01-24 02:04:42

I have seen this periodically on every machine of mine that runs Arch with XFCE. And I just got two back-to-back crashes today. I presume this has yet to be fixed upstream?

toz · 2017-01-24 02:10:32

alex.forencich wrote:

I presume this has yet to be fixed upstream?

https://bugzilla.xfce.org/show_bug.cgi?id=12264

Try thunar-git from the AUR, it includes the "0001-Deactivate-SEND_MOVED-code-paths" patch which has fixed the crashing on my system.

werkman2 · 2017-01-25 16:48:19

0strodamus wrote:

I don't know if it's related, but I'm experiencing thunar crashes during file move operations. It's been happening fairly frequently (although intermittently) since the upgrade to glib2-2.46.0-2. Downgrading to glib2-2.44.1-1 resolves the issue. glib2 from testing didn't help with my crashes. I just posted a bug report.

installing thunar-git from aur solved this for me.

it appears that the creator of this pkgbuild applied a patch that adressed the crash when renaming files

alex.forencich · 2017-02-07 19:13:14

Interesting. I suppose I'll have to try tunar-git. Another thing that I have noticed on occasion are renamed folders/files appearing twice immediately after renaming. Navigating to a different folder and back makes this 'ghost' disappear.

toz · 2017-02-07 20:09:50

alex.forencich wrote:

Another thing that I have noticed on occasion are renamed folders/files appearing twice immediately after renaming. Navigating to a different folder and back makes this 'ghost' disappear.

Its being addressed in the upstream bug report. Looks like they are zeroing in on a comprehensive fix.

Arch Linux

#51 2016-03-06 16:01:01

Re: Anyone else experiencing segfaults in Thunar upon renaming a file?

#52 2016-03-06 18:12:10

Re: Anyone else experiencing segfaults in Thunar upon renaming a file?

#53 2016-03-06 23:28:43

Re: Anyone else experiencing segfaults in Thunar upon renaming a file?

#54 2016-03-07 00:12:29

Re: Anyone else experiencing segfaults in Thunar upon renaming a file?

#55 2016-03-07 00:25:28

Re: Anyone else experiencing segfaults in Thunar upon renaming a file?

#56 2016-03-20 23:12:44

Re: Anyone else experiencing segfaults in Thunar upon renaming a file?

#57 2016-04-06 16:53:01

Re: Anyone else experiencing segfaults in Thunar upon renaming a file?

#58 2016-04-06 18:44:59

Re: Anyone else experiencing segfaults in Thunar upon renaming a file?

#59 2016-06-12 10:37:21

Re: Anyone else experiencing segfaults in Thunar upon renaming a file?

#60 2016-06-13 16:03:27

Re: Anyone else experiencing segfaults in Thunar upon renaming a file?

#61 2016-06-23 20:47:28

Re: Anyone else experiencing segfaults in Thunar upon renaming a file?

#62 2016-07-18 13:45:16

Re: Anyone else experiencing segfaults in Thunar upon renaming a file?

#63 2016-07-18 19:41:59

Re: Anyone else experiencing segfaults in Thunar upon renaming a file?

#64 2016-07-20 19:41:44

Re: Anyone else experiencing segfaults in Thunar upon renaming a file?

#65 2016-07-22 14:49:02

Re: Anyone else experiencing segfaults in Thunar upon renaming a file?

#66 2016-07-22 21:34:11

Re: Anyone else experiencing segfaults in Thunar upon renaming a file?

#67 2016-07-22 21:49:25

Re: Anyone else experiencing segfaults in Thunar upon renaming a file?

#68 2016-07-26 03:26:57

Re: Anyone else experiencing segfaults in Thunar upon renaming a file?

#69 2016-07-26 14:58:16

Re: Anyone else experiencing segfaults in Thunar upon renaming a file?

#70 2016-07-31 11:36:16

Re: Anyone else experiencing segfaults in Thunar upon renaming a file?

#71 2017-01-24 02:04:42

Re: Anyone else experiencing segfaults in Thunar upon renaming a file?

#72 2017-01-24 02:10:32

Re: Anyone else experiencing segfaults in Thunar upon renaming a file?

#73 2017-01-25 16:48:19

Re: Anyone else experiencing segfaults in Thunar upon renaming a file?

#74 2017-02-07 19:13:14

Re: Anyone else experiencing segfaults in Thunar upon renaming a file?

#75 2017-02-07 20:09:50

Re: Anyone else experiencing segfaults in Thunar upon renaming a file?

Board footer