You are not logged in.

#1 2016-10-22 18:29:40

mrpatton75
Member
Registered: 2013-03-24
Posts: 4

Hiri Email Client AUR package request

This new email client looks very interesting, however I am having a hard time getting the hiri.sh script to complete the build.  I was wandering if somebody on here with more experience might consider building an AUR package for it.  Below is the URL to the application.

https://www.hiri.com/product/

Thanks

Offline

#2 2016-10-25 14:13:24

JayJay_92
Member
Registered: 2016-10-25
Posts: 2

Re: Hiri Email Client AUR package request

I'm tinkering with it and should have a AUR package ready for it soon. I'll post a link here when it's done.

Offline

#3 2016-10-25 20:00:49

mrpatton75
Member
Registered: 2013-03-24
Posts: 4

Re: Hiri Email Client AUR package request

Awesome, thank you!!!!  I can't wait to try it out.  We really need more clients that support Exchange / Office 365, IMHO.

Offline

#4 2016-10-26 14:38:30

JayJay_92
Member
Registered: 2016-10-25
Posts: 2

Re: Hiri Email Client AUR package request

It is done: https://aur.archlinux.org/packages/hiri/

My first AUR package, feedback welcome :-)

Offline

#5 2016-10-26 16:20:23

mrpatton75
Member
Registered: 2013-03-24
Posts: 4

Re: Hiri Email Client AUR package request

Excellent job!!!!  Installed perfectly!  Thank you very much.

Offline

#6 2016-10-26 21:25:42

eschwartz
Fellow
Registered: 2014-08-08
Posts: 4,097

Re: Hiri Email Client AUR package request

Why are you using a pointless wrapper script rather than symlinking the upstream-provided hiri.sh launcher script?

Also, you were correct to install a copy of the icon in /usr/share/icons. But once you have done so, you can and should use "Icon=hiri" to automatically use the right icon in the desktop file.

Finally, please remove that install file. Ever since pacman 5 we use pacman hooks to handle mime/desktop/gtk-icon-cache updates, and the corresponding sections of install files have been removed from all repo packages: https://www.archlinux.org/todo/hooks-part-1/
All AUR maintainers were supposed to likewise remove those install files, though I have no stats on how many did...
In most cases that gets rid of the install file entirely, a worthy goal. wink

..

Minor nit. Please use in the sources array:
"$pkgname-$pkgver.tar.gz::https://feedback.hiri.com/downloads/Hiri.tar.gz"

Since upstream does not provide versioned downloads, it is up to you to make sure people don't accidentally keep the old version. wink
i.e. PKGBUILD policy is each package and package version should have a unique source download name, because some people keep sources in a persistent, central SRCDEST (see `man makepkg.conf`).

...

Random comment. What is up with making a copy of the system _ssl.cpython-35m-x86_64-linux-gnu.so and replacing the copy they distribute for python34?
(Mixing and matching different versions of things is always fraught with risk.) I would think they delivered a prebuilt binary package which worked...

Last edited by eschwartz (2016-10-26 21:35:26)


Managing AUR repos The Right Way -- aurpublish (now a standalone tool)

Offline

#7 2016-10-27 12:00:34

GordonGR
Member
From: Thessaloniki, Greece
Registered: 2011-11-07
Posts: 276

Re: Hiri Email Client AUR package request

First package, huh? Congrats big_smile

Eschwartz wrote:

Random comment. What is up with making a copy of the system _ssl.cpython-35m-x86_64-linux-gnu.so and replacing the copy they distribute for python34?

And, at any rate, why is this done in the build() function? It should be in package().


Intel(R) Celeron(R) CPU E3400 @ 2.60GHz, x86_64. AURs.

“No one without the knowledge of geometry may enter.“ Plato.

Offline

Board footer

Powered by FluxBB