Arch Linux

zhoangngan

Member

Registered: 2017-05-11

Posts: 2

Website

PKGBUILD review request: rseye

Hi, can someone please review my PKGBUILD at https://github.com/hoangngan82/RSEye/bl … r/PKGBUILD ?
Thanks

# Maintainer: Hoang-Ngan Nguyen zhoangngan@gmail.com
pkgname=rseye-git
_pkgname=rseye
pkgver=20170510.0
pkgrel=1
pkgdesc="Freeze screen regularly to help prevent RSI and protect the eyes."
arch=('i686' 'x86_64')
url="https://github.com/hoangngan82/$_pkgname"
license=('MIT')
depends=(libxrender)
makedepends=(git gcc)
source=("git+https://github.com/hoangngan82/$_pkgname.git")
md5sums=('SKIP')

pkgver() {
  cd "${srcdir}/${_pkgname}"
  git log -1 --format='%cd.%h' --date=short | tr -d -
}

build() {
  cd "${srcdir}/$_pkgname"
  make
}

package() {
  install -D "$srcdir/$_pkgname/rseye" "$pkgdir/usr/bin/$_pkgname"
  install -Dm644 "$srcdir/$_pkgname/LICENSE" "$pkgdir/usr/share/licenses/$pkgname/LICENSE"
}

Trilby

Inspector Parrot

Registered: 2011-11-29

Posts: 29,532

Website

Re: PKGBUILD review request: rseye

Looks good.  You can/should remove gcc from the make depends as that is part of base-devel.  You should also consider using the pkgver format recommended in the wiki:

printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short HEAD)"

And on a very pedantic stylistic note, you use {} around your variables inconsistently - but this has no effect on functionality in this case.

P.S. I like the name RSEye.

---

"UNIX is simple and coherent..." - Dennis Ritchie, "GNU's Not UNIX" -  Richard Stallman

zhoangngan

Member

Registered: 2017-05-11

Posts: 2

Website

Re: PKGBUILD review request: rseye

Thank you very much. I updated my PKGBUILD per your comments. And thanks for the P.S. line