Arch Linux

winksaville

Member

Registered: 2015-09-21

Posts: 40

PKGBUILD review request: ponyc-rpm-bin

Please review the renamed ponyc-rpm to ponyc-rpm-bin.
This also include support for signatures by adding validpgpkeys. Here is the diff:

$ git diff HEAD^ -- PKGBUILD
diff --git a/PKGBUILD b/PKGBUILD
index e8c6c97..71b0611 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -1,5 +1,5 @@
 # Maintainer: Wink Saville <wink@saville.com>
-pkgname=ponyc-rpm
+pkgname=ponyc-rpm-bin
 _ver="0.20.0"
 _ver_sig="4003.0b2a2d2"
 pkgver="${_ver}_${_ver_sig}"
@@ -11,8 +11,11 @@ license=('BSD')
 depends=('zlib' 'ncurses5-compat-libs')
 provides=("ponyc=$_ver")
 conflicts=('ponyc')
-source_x86_64=("https://dl.bintray.com/pony-language/ponyc-rpm/ponyc-${_ver}-${_ver_sig}.x86_64.rpm")
-sha256sums_x86_64=('0b7dd70759603535061a19d47d12f8059656880dcb9d00550dd833c515125fcf')
+source_x86_64=("https://dl.bintray.com/pony-language/ponyc-rpm/ponyc-${_ver}-${_ver_sig}.x86_64.rpm"
+               "https://dl.bintray.com/pony-language/ponyc-rpm/ponyc-${_ver}-${_ver_sig}.x86_64.rpm.asc")
+sha256sums_x86_64=('0b7dd70759603535061a19d47d12f8059656880dcb9d00550dd833c515125fcf'
+                   '034db15e4e931606279e43b8d2a8c790a800b4ea9950960a6c39c0d46ce05323')
+validpgpkeys=('8756C4F765C9AC3CB6B85D62379CE192D401AB61')
 source=("https://raw.githubusercontent.com/ponylang/ponyc/${_ver}/LICENSE")
 sha256sums=('c22151b202623f11638a8f6e3eb07c5767b941b75e7585f2e270d5b87f72758a')
 

Here is the PKGBUILD:

$ cat PKGBUILD 
# Maintainer: Wink Saville <wink@saville.com>
pkgname=ponyc-rpm-bin
_ver="0.20.0"
_ver_sig="4003.0b2a2d2"
pkgver="${_ver}_${_ver_sig}"
pkgrel=1
pkgdesc="An actor model, capabilities, high performance programming language (bintray rpm binaries)"
arch=('x86_64')
url="https://www.ponylang.org/"
license=('BSD')
depends=('zlib' 'ncurses5-compat-libs')
provides=("ponyc=$_ver")
conflicts=('ponyc')
source_x86_64=("https://dl.bintray.com/pony-language/ponyc-rpm/ponyc-${_ver}-${_ver_sig}.x86_64.rpm"
               "https://dl.bintray.com/pony-language/ponyc-rpm/ponyc-${_ver}-${_ver_sig}.x86_64.rpm.asc")
sha256sums_x86_64=('0b7dd70759603535061a19d47d12f8059656880dcb9d00550dd833c515125fcf'
                   '034db15e4e931606279e43b8d2a8c790a800b4ea9950960a6c39c0d46ce05323')
validpgpkeys=('8756C4F765C9AC3CB6B85D62379CE192D401AB61')
source=("https://raw.githubusercontent.com/ponylang/ponyc/${_ver}/LICENSE")
sha256sums=('c22151b202623f11638a8f6e3eb07c5767b941b75e7585f2e270d5b87f72758a')

package() {
  cp -a "usr" "$pkgdir/"
  install -Dm644 "LICENSE" "$pkgdir/usr/share/licenses/$pkgname/LICENSE"
}

winksaville

Member

Registered: 2015-09-21

Posts: 40

Re: PKGBUILD review request: ponyc-rpm-bin

Ping

2ManyDogs

Forum Fellow

Registered: 2012-01-15

Posts: 4,645

Re: PKGBUILD review request: ponyc-rpm-bin

Ping

Please don't do that.

Lone_Wolf

Member

From: Netherlands, Europe

Registered: 2005-10-04

Posts: 11,911

Re: PKGBUILD review request: ponyc-rpm-bin

source_x86_64=("https://dl.bintray.com/pony-language/ponyc-rpm/ponyc-${_ver}-${_ver_sig}.x86_64.rpm"
               "https://dl.bintray.com/pony-language/ponyc-rpm/ponyc-${_ver}-${_ver_sig}.x86_64.rpm.asc")
sha256sums_x86_64=('0b7dd70759603535061a19d47d12f8059656880dcb9d00550dd833c515125fcf'
                   '034db15e4e931606279e43b8d2a8c790a800b4ea9950960a6c39c0d46ce05323')
validpgpkeys=('8756C4F765C9AC3CB6B85D62379CE192D401AB61')
source=("https://raw.githubusercontent.com/ponylang/ponyc/${_ver}/LICENSE")
sha256sums=('c22151b202623f11638a8f6e3eb07c5767b941b75e7585f2e270d5b87f72758a')

I'd change the order of those lines and rewrite the source_x86_64 a bit for clarity

validpgpkeys=('8756C4F765C9AC3CB6B85D62379CE192D401AB61')
source=("https://raw.githubusercontent.com/ponylang/ponyc/${_ver}/LICENSE")
sha256sums=('c22151b202623f11638a8f6e3eb07c5767b941b75e7585f2e270d5b87f72758a')

source_x86_64=(https://dl.bintray.com/pony-language/ponyc-rpm/ponyc-${_ver}-${_ver_sig}.x86_64.rpm{,.asc})
sha256sums_x86_64=('0b7dd70759603535061a19d47d12f8059656880dcb9d00550dd833c515125fcf'
                   '034db15e4e931606279e43b8d2a8c790a800b4ea9950960a6c39c0d46ce05323')

---

Disliking systemd intensely, but not satisfied with alternatives so focusing on taming systemd.

(A works at time B)  && (time C > time B ) ≠  (A works at time C)

winksaville

Member

Registered: 2015-09-21

Posts: 40

Re: PKGBUILD review request: ponyc-rpm-bin

OK, one minor tweak. I've been told to always use strings for "parameters" so I changed source_x86_64 to:

source_x86_64=("https://dl.bintray.com/pony-language/ponyc-rpm/ponyc-${_ver}-${_ver_sig}.x86_64.rpm"{,.asc})