You are not logged in.

#1 2018-05-17 04:44:54

Winston-Wolfe
Member
Registered: 2013-06-01
Posts: 49

Just submitted my first package. Please take a look if all looks good.

https://aur.archlinux.org/packages/indi … letin-git/

It installs fine on my KDE system.

One thing that looks off to me is in the Package Details, Git Clone URL also shows 'ssh://aur@aur.archlinux.org/indicator-bulletin-git.git'

I haven't seen that on other packages. Is it ok?

Edit: I fixed it with:

git remote set-url origin https://aur.archlinux.org/indicator-bulletin-git.git

Last edited by Winston-Wolfe (2018-05-17 05:39:10)

Offline

#2 2018-05-17 06:12:17

Eschwartz
Trusted User/Bug Wrangler
Registered: 2014-08-08
Posts: 1,849

Re: Just submitted my first package. Please take a look if all looks good.

You'll notice the https one is marked as read-only. wink That's because only the package maintainer is explicitly shown the push url! There's nothing to fix...

As for your package...

- It's a git package with a git source, which means you need a makedepends on git.

- You failed to quote ${srcdir} in your prepare function.

- MIT licenses need to be installed, see https://wiki.archlinux.org/index.php/PKGBUILD#license

- Using install without specifying -m644 results in default executable files. But you use this to install the desktop file too... this is ugly. I'd also simplify the whole thing with install -Dm644 source /path/to/destination/file, instead of explicitly calling install a third time to create the directories with -d.
(This is not always obvious, because BSD install does not support it, so portable Makefiles will usually use install -d /path/to/destination/ && install m644 source /path/to/destination/file. However, PKGBUILDs are not portable anyway...)

- You're mixing tabs and spaces, the install -d command I pointed out as something to get rid of is preceded by a tab whereas the file in general uses 4 spaces for indentation.

Online

#3 2018-05-17 06:19:32

Winston-Wolfe
Member
Registered: 2013-06-01
Posts: 49

Re: Just submitted my first package. Please take a look if all looks good.

Thank you, I will make those changes tomorrow.

I appreciate the explanations.

Offline

Board footer

Powered by FluxBB