Arch Linux

Titus

Member

From: Izmir

Registered: 2006-05-11

Posts: 120

Website

could you please control?

for splumber game i try to prepare a PKGBUILD it is shown below, could you please check this PKGBUILD ?

# $Id: PKGBUILD,v 1.12 2003/11/06 08:26:13 dorphell Exp $
#Contributor:Tutku Dalmaz <tutkudalmaz>
pkgname=splumber
pkgver=1.1.0
pkgrel=1
pkgdesc="Space Plumber is a 3D game"
url="http://www.triptico.com/splumber/"
licence="GPL"
depends=('')
source=("http://freshmeat.net/redir/spaceplumber/9840/url_tgz/$pkgname-$pkgver-rc1.tar.gz")
md5sums=('4987e10a90ca956736c37d771fa5e331')

build() {
  cd $startdir/src/$pkgname-$pkgver-rc1
  ./config.sh
  make || return 1
  install -d $startdir/pkg/usr/local/bin
  make DESTDIR=$startdir/pkg  datadir=$startdir/pkg/usr/local/bin install

}

---

In a world without walls,who need windows?

Snowman

Developer/Forum Fellow

From: Montreal, Canada

Registered: 2004-08-20

Posts: 5,212

Re: could you please control?

some comments :
1. Remove the $Id line. It has no use here.
2. No depends? Did you ran namcap on the PKGBUILD and package?
3.  Use the source directly from the project's home page:
http://www.triptico.com/download/splumb … rc1.tar.gz
The freashmeat link just redirect you to them anyway.
4. Don't install files in /usr/local. It is not used in Arch. Install the files in /usr. You'll need to modify the last 2 lines.

Cerebral

Forum Fellow

From: Waterloo, ON, CA

Registered: 2005-04-08

Posts: 3,108

Website

Re: could you please control?

A few things to add from snowman's list:

1) Running namcap splumber*.pkg.tar.gz after you make it will come up with a couple of depends - list them in the depends line.  Even if, however, there were no depends, this is incorrect syntax.  An empty depends list looks like this:

depends=()

- the way you have it will cause problems with pacman.

2) To build on snowman's #4 - look at the options you get when you run ./config.sh --help from the source directory - the --prefix flag will help.

3) I looked in the Makefile - datadir is never used.  Why did you add datadir=... to your install line?

4) Since the package version really is 1.1.0-rc1, you'd probably want the pkgver variable to reflect that.  I suggest an underscore.

In any case, since I was playing around with it myself, here's how I would write the PKGBUILD.  You should however pay attention to the pointers Snowman and I have given you - they'll help you build packages in the future, and not all the time will there be someone who'll 'fix' the PKGBUILD for ya.

#Contributor:Tutku Dalmaz <tutkudalmaz> 
pkgname=splumber 
pkgver=1.1.0_rc1
pkgrel=1 
pkgdesc="Space Plumber is a 3D game" 
url="http://www.triptico.com/splumber/" 
licence="GPL" 
depends=('esd' 'libxext') 
source=("http://www.triptico.com/download/$pkgname-${pkgver/_/-}.tar.gz")
md5sums=('4987e10a90ca956736c37d771fa5e331') 

build() { 
  cd $startdir/src/$pkgname-${pkgver/_/-}
  ./config.sh --prefix=/usr
  make || return 1 
  install -d $startdir/pkg/usr/{bin,share}
  make DESTDIR=$startdir/pkg install 
}

Titus

Member

From: Izmir

Registered: 2006-05-11

Posts: 120

Website

Re: could you please control?

thanks for your warnings and explanations i 'll be more careful about PKGBUILDs

---

In a world without walls,who need windows?