Error after upgrade of gitlab-shell to 8.4.0

Goldman60 · 2018-10-13 03:35:38

After painlessly running gitlab since version 9 on Arch I upgraded to gitlab-shell 8.4.0 tonight any ssh connections are met with the following error:

ssh -T gitlab@******
Failed to read config, falling back to gitlab-shell-ruby
Failed to exec("gitlab-shell-ruby"): no such file or directory

The config is present where I would expect it to be and nothing was manually changed aside from the upgrade and system restart

Goldman60 · 2018-10-13 04:33:38

Haha! Solved my issue

At some point in the past I set the gitlab user's shell in /etc/passwd to the path to the gitlab-shell executable. This worked for a long time until gitlab-shell 8.4.0, for whatever reason this upgrade broke that. I restored function by deleting the shell from /etc/passwd

lahwaacz · 2018-10-15 15:36:59

The gitlab-shell in /etc/passwd was not set by you, but systemd-sysusers: https://git.archlinux.org/svntogit/comm … tlab-shell

To restore the original behaviour, set gitlab-shell-ruby instead of gitlab-shell as the shell in /etc/passwd. Since 8.4.0 this appeared in /etc/webapps/gitlab-shell/config.yml, though I have no idea how that is supposed to work or if the gitlab-shell reimplementation in Go is actually usable.

# Migration to Go: anything listed here has two implementations. Use these flags
# to try the new implementations out, or to revert to the old behaviour if there
# problems arise.
migration:
  enabled: false
  features: []

ejiek · 2018-10-16 19:41:35

There is a problem with path resolution in go implementation. So it's not able to find config file or ruby executable.

Opened a merge request.

Svenstaro · 2018-10-18 02:12:21

Please report a bug if there is a problem with the package.

ejiek · 2018-10-18 06:30:09

sorry, was going to but got too busy.
Filed a bug.

ejiek · 2018-10-22 13:08:29

ejiek wrote:

There is a problem with path resolution in go implementation. So it's not able to find config file or ruby executable.
Opened a merge request.

There is no response from upstream yet.
Patch merged by Sven-Hendrik Haase in 8.4.0-2 (Archlinux package). (Works, thanks!)

We can mark this thread solved.

Arch Linux

#1 2018-10-13 03:35:38

Error after upgrade of gitlab-shell to 8.4.0

#2 2018-10-13 04:33:38

Re: Error after upgrade of gitlab-shell to 8.4.0

#3 2018-10-15 15:36:59

Re: Error after upgrade of gitlab-shell to 8.4.0

#4 2018-10-16 19:41:35

Re: Error after upgrade of gitlab-shell to 8.4.0

#5 2018-10-18 02:12:21

Re: Error after upgrade of gitlab-shell to 8.4.0

#6 2018-10-18 06:30:09

Re: Error after upgrade of gitlab-shell to 8.4.0

#7 2018-10-22 13:08:29

Re: Error after upgrade of gitlab-shell to 8.4.0

Board footer