PKGBUILD review request (python/psrecord) [SOLVED]

graysky · 2019-01-30 18:40:21

Can someone savvy with python please review my PKGBUILD for psrecord? Upstream only publishes install instructions using pip and I don't want to package with pip. Thanks!

https://aur.archlinux.org/packages/psrecord/

Last edited by graysky (2019-01-31 19:48:04)

eschwartz · 2019-01-31 03:10:25

The package looks mostly fine, and the issues I see are mostly unrelated to pip/python.

As per https://wiki.archlinux.org/index.php/PKGBUILD#license the license is not "custom" anything, it is simply the BSD license.
You should use $pkgver in the source array rather than requiring updated versions to touch multiple parts of the file.

Why is python-matplotlib a makedepends and optdepends? It doesn't look like it is needed at build or install time at all, but I assume it is needed for pytest to run, in which case it should be a checkdepends.

graysky · 2019-01-31 19:47:55

Great feedback, thanks for the review. Corrected in 1.1-3.

Piri · 2019-01-31 20:00:22

I don't want to nitpick here, there are just some things I noticed and I'd like to better my understanding of python packaging in Arch.

Shouldn't the package be called "python-psrecord" since it is a Python module?
https://wiki.archlinux.org/index.php/Py … age_naming

The wiki entry also suggests using the "--skip-build" in package() , since it has already been built in the build().
This does not really seem that important though, since some repos packages seem to don't do that either (e.g. python-numpy).
Should one do that or not?

graysky · 2019-01-31 20:17:28

Piri wrote:

I don't want to nitpick here, there are just some things I noticed and I'd like to better my understanding of python packaging in Arch.
Shouldn't the package be called "python-psrecord" since it is a Python module?
https://wiki.archlinux.org/index.php/Py … age_naming

...is it a python library or a standalone program that requires python? For example, deluge is one such example. Perhaps I am misunderstanding the definition of a python library used on the page Piri linked.

Last edited by graysky (2019-01-31 20:17:50)

Piri · 2019-01-31 20:24:24

Oh no, I misunderstood I thought it was a library. I should have taken a closer look at the README, sorry!

eschwartz · 2019-01-31 20:35:36

psrecord is a command-line utility and its implementation language does not matter. The entire project amounts to a single 234-line `psrecord.main` module with no documented API, that saves stuff to a file. I cannot fathom when it would be used as a library by anything other than its own wrapper script which runs the main() function.

Arch Linux

#1 2019-01-30 18:40:21

PKGBUILD review request (python/psrecord) [SOLVED]

#2 2019-01-31 03:10:25

Re: PKGBUILD review request (python/psrecord) [SOLVED]

#3 2019-01-31 19:47:55

Re: PKGBUILD review request (python/psrecord) [SOLVED]

#4 2019-01-31 20:00:22

Re: PKGBUILD review request (python/psrecord) [SOLVED]

#5 2019-01-31 20:17:28

Re: PKGBUILD review request (python/psrecord) [SOLVED]

#6 2019-01-31 20:24:24

Re: PKGBUILD review request (python/psrecord) [SOLVED]

#7 2019-01-31 20:35:36

Re: PKGBUILD review request (python/psrecord) [SOLVED]

Board footer