You are not logged in.

#1 2019-03-24 21:36:32

agrewal
Member
Registered: 2018-11-23
Posts: 20

PKGBUILD review request for cl-named-readtables-git

PKGBUILD:

# Maintainer: Aman Grewal <agrewal at protonmail dot com>

pkgname=cl-named-readtables
_pkgname=${pkgname#cl-}
pkgver=0.9.r20.g985b162
pkgrel=1
pkgdesc="Provides a namespace for readtables"
arch=('any')
url="https://melisgl.github.io/mgl-pax-world/named-readtables-manual.html"
license=('BSD')
source=("git+https://github.com/melisgl/named-readtables.git")
md5sums=('SKIP')

pkgver() {
  cd "${_pkgname}"
  git describe --long | sed 's/\([^-]*-g\)/r\1/;s/-/./g'
}

package() {
  cd ${_pkgname}
  install -Dm644 LICENSE "$pkgdir"/usr/share/licenses/$pkgname/LICENSE
  install -d "$pkgdir"/usr/share/common-lisp/source/${_pkgname}/src
  install -d "$pkgdir"/usr/share/common-lisp/systems
  
  install -m 644 -t "$pkgdir"/usr/share/common-lisp/source/${_pkgname}/src ./src/*.lisp
  install -m 644 -t "$pkgdir"/usr/share/common-lisp/source/${_pkgname} ${_pkgname}.asd

  cd "$pkgdir"/usr/share/common-lisp/systems
  ln -s ../source/${_pkgname}/${_pkgname}.asd .
}

Offline

#2 2019-03-24 21:57:17

Trilby
Inspector Parrot
Registered: 2011-11-29
Posts: 21,249
Website

Re: PKGBUILD review request for cl-named-readtables-git


"UNIX is simple and coherent..." - Dennis Ritchie, "GNU's Not UNIX" -  Richard Stallman

Offline

#3 2019-03-24 22:46:06

agrewal
Member
Registered: 2018-11-23
Posts: 20

Re: PKGBUILD review request for cl-named-readtables-git

Added git as a makedepends, updated package name to cl-named-readtables-git, and removed unnecessary quotes and braces.

PKGBUILD:

# Maintainer: Aman Grewal <agrewal at protonmail dot com>

pkgname=cl-named-readtables-git
_pkgname=named-readtables
pkgver=0.9.r20.g985b162
pkgrel=1
pkgdesc="Provides a namespace for readtables"
arch=('any')
url="https://melisgl.github.io/mgl-pax-world/named-readtables-manual.html"
license=('BSD')
makedepends=('git')
source=("git+https://github.com/melisgl/named-readtables.git")
md5sums=('SKIP')

pkgver() {
  cd $_pkgname
  git describe --long | sed 's/\([^-]*-g\)/r\1/;s/-/./g'
}

package() {
  cd $_pkgname
  install -Dm644 LICENSE "$pkgdir"/usr/share/licenses/$pkgname/LICENSE
  install -d "$pkgdir"/usr/share/common-lisp/source/$_pkgname/src
  install -d "$pkgdir"/usr/share/common-lisp/systems
  
  install -m 644 -t "$pkgdir"/usr/share/common-lisp/source/$_pkgname/src ./src/*.lisp
  install -m 644 -t "$pkgdir"/usr/share/common-lisp/source/$_pkgname $_pkgname.asd

  cd "$pkgdir"/usr/share/common-lisp/systems
  ln -s ../source/$_pkgname/$_pkgname.asd .
}

Offline

#4 2019-03-25 15:38:20

Lone_Wolf
Member
From: Netherlands, Europe
Registered: 2005-10-04
Posts: 6,779

Re: PKGBUILD review request for cl-named-readtables-git

I'd use https://github.com/melisgl/named-readtables for url= , not a link to dumentation

Nothing seems to be build/compiled in this package, are these like header files ?


Multi-init booting with apg Openrc and systemd coexisting
Automounting : not needed, i prefer pmount
Aur helpers : makepkg + my own local repo === rarely need them

Offline

#5 2019-03-25 17:57:52

Trilby
Inspector Parrot
Registered: 2011-11-29
Posts: 21,249
Website

Re: PKGBUILD review request for cl-named-readtables-git

Lone_Wolf, it's lisp scripts.

But that does highlight (at least one) missing dependency.  This certainly requires a lisp interpreter.  Which lisp variant is this for?  Be sure to add the appropriate interpreter to the depends array.


"UNIX is simple and coherent..." - Dennis Ritchie, "GNU's Not UNIX" -  Richard Stallman

Offline

#6 2019-03-25 18:01:51

agrewal
Member
Registered: 2018-11-23
Posts: 20

Re: PKGBUILD review request for cl-named-readtables-git

It's a library for common lisp. It's source code that you import/load into your own programs.

Offline

#7 2019-03-26 10:10:43

Lone_Wolf
Member
From: Netherlands, Europe
Registered: 2005-10-04
Posts: 6,779

Re: PKGBUILD review request for cl-named-readtables-git

Thanks Trilby & agrewal .

Maybe add lisp and/or library  to pkgdesc ?


Multi-init booting with apg Openrc and systemd coexisting
Automounting : not needed, i prefer pmount
Aur helpers : makepkg + my own local repo === rarely need them

Offline

Board footer

Powered by FluxBB