You are not logged in.

#1 2019-05-24 10:44:39

schard
Member
From: Hannover
Registered: 2016-05-06
Posts: 361
Website

repotool - A tool to maintain repositories

repotool is a tool to maintain pacman repositories.
GitHub | AUR

Offline

#2 2019-05-24 11:33:50

Alad
Wiki Admin/IRC Op/TU
From: Bagelstan
Registered: 2014-05-04
Posts: 1,950
Website

Re: repotool - A tool to maintain repositories

Some comments:

https://github.com/conqp/repotool/blob/ … ool.py#L16

I suppose this is some remainder from an earlier version, since "pkgpath" seems unused?

https://github.com/conqp/repotool/blob/ … ool.py#L45

This is going to be slow with large amounts of packages; you can either do a direct comparison on "=" (most common case which does not require calling vercmp) or use pyalpm. In particular: https://github.com/jelly/pyalpm/blob/6b … .c#L71-L78

Also typos: "Cehcks".

https://github.com/conqp/repotool/blob/ … ol.py#L132

Similar though I suppose "isolate" is not called as often. cf. https://docs.python.org/3/library/tarfile.html instead of going through pacman for pkgbase/version.

https://github.com/conqp/repotool/blob/ … ol.py#L102

.db.tar.xz is not the only valid repo-add extension; it's better to resolve the .db symbolic link.

https://github.com/conqp/repotool/blob/ … ol.py#L112
https://github.com/conqp/repotool/blob/ … ol.py#L134

Similarly .pkg.tar.xz is not the only valid package extension. You can't immediately find out the extension from a repository alone though.

https://github.com/conqp/repotool/blob/ … ol.py#L126

I'd consider adding a warning that an existing signature was found. That way it's clear that something else than repotool signed the package.

https://github.com/conqp/repotool/blob/ … ol.py#L153

I assume this runs repo-add with the system UTF-8 locale, which may cause issues with some tools like expac/pacutils. See https://bugs.archlinux.org/task/49342

It would also be worthwhile to test how repotool behaves with arbitrary repository names. As far as I know, all characters apart from \n (newline) and / (path separator) are possible.

Last edited by Alad (2019-05-24 11:45:20)


Mods are just community members who have the occasionally necessary option to move threads around and edit posts. -- Trilby
Honest Alad's Package Emporium—Now with added bugs! (Grand reopening: December 1st 2018)

Offline

#3 2019-05-24 12:00:42

schard
Member
From: Hannover
Registered: 2016-05-06
Posts: 361
Website

Re: repotool - A tool to maintain repositories

Thanks for the feedback. I'll definitely solve the typos and bugs.
Regarding pkgpath, it is intended for future use. You are, however, correct, that it is currently not used for the CLI tools.
Regarding the version comparison: Yes, invoking the vercmp subprocess on a huge amount  of packages will slow things down.
An earlier version just checked whether the current package is not the package added and removed all other packages regardless of their version.
Maybe this already was sufficient and I overengineered things here.
And yes, the program expects UTF-8 locales. Newlines and slashes should not be part of the repo name for obvious reasons.
Regarding that I assume some common sense from the user wink

Offline

Board footer

Powered by FluxBB