Arch Linux

karlch

Member

Registered: 2015-06-14

Posts: 105

[SOLVED] PKGBUILD review request (vimiv-qt-git)

I would like to add a PKGBUILD for vimiv-qt-git to the AUR. As I am not very experienced with writing these, any comments would be appreciated.

PKGBUILD

# Maintainer: Christian Karl <karlch at protonmail dot com>

pkgname=vimiv-qt-git
pkgrel=1
pkgver=r973.ca70c6e
pkgdesc='An image viewer with vim-like keybindings'
arch=('any')
url='https://github.com/karlch/vimiv-qt'
license=('GPL3')
depends=('python-pyqt5')
makedepends=('git' 'python-setuptools')
optdepends=('qt5-svg: for svg support' 'python-piexif: for exif support')
conflicts=('vimiv')
provides=('vimiv')
source=("$pkgname::git+${url}.git")
md5sums=('SKIP')

pkgver() {
    cd "$srcdir/$pkgname"

    printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short HEAD)"
}

package() {
    cd "$srcdir/$pkgname"

    make -f misc/Makefile DESTDIR="$pkgdir" install
}

The MAKEFILE used can be found here.

Thanks in advance for any comments or suggestions

EDIT:
I have uploaded the package to the AUR, happy to hear if there are any issues.

Last edited by karlch (2019-11-09 23:41:14)

---

github