You are not logged in.

#1 2019-07-29 22:23:56

matmoul
Member
Registered: 2015-08-31
Posts: 13

octopi, octopi-dev : need feedbacks...

Hi everyone, after some trouble on octopi, I've provided the resolution of alpm_octopi_utils.

After that, I've adopted alpm_octopi_utils and octopi package.

Now I'm looking at Manjaro and octopi is more recent but the last official release is 0.9.0.

To prevent unwanted changes, I've made a new package octopi-dev,

You can try it and give me feedbacks, this will become the future package when a new release was ready (https://github.com/aarnt/octopi/issues/384)...

For notification, you need to choose octopi-notifier-qt5 or octopi-notifier-frameworks for Plasma5.

Offline

#2 2019-07-29 22:51:27

c00ter
Member
From: Alaskan in Washington State
Registered: 2014-08-28
Posts: 269

Re: octopi, octopi-dev : need feedbacks...

Why must it be built with any notifier? There's updates daily; this is Arch. Why make it required? Who needs or want the additional overhead?


UNIX was not designed to stop you from doing stupid things, because that would also stop you from doing clever things. -- Doug Gwyn

Offline

#3 2019-07-29 23:05:37

matmoul
Member
Registered: 2015-08-31
Posts: 13

Re: octopi, octopi-dev : need feedbacks...

@c00ter Thanks for your feedback,

For the notifier it's a problem because it has two notifiers the qt5 release that work with all qt desktop (xfce has a optional dep) and the frameworks release that support the new Knotifier for Plasma5, but the two notifiers are in conflict.
It seem best to use two package than editing the PKGBUILD that is the current method...

In the dev release and with octopi-notifier-frameworks, on Plasma5, now the notification icon is displayed when new update are available...

And for the other, how y say on my first post, this is the base for the future releases of octopi 0.10.0,

Offline

#4 2019-07-29 23:18:07

loqs
Member
Registered: 2014-03-06
Posts: 8,169

Re: octopi, octopi-dev : need feedbacks...

namcap issues with octopi-dev (f8ac9b6d71f9bfa685fa5d02a25b1196a4941521)

Checking PKGBUILD
PKGBUILD (octopi-dev) W: Non standard variable 'pkggit' doesn't start with an underscore
PKGBUILD (octopi-dev) W: PKGBUILD uses internal makepkg 'msg' subroutine
PKGBUILD (octopi-dev) E: Child package octopi-dev does not have a valid package() function
Checking octopi-dev-0.9.0-2-x86_64.pkg.tar.xz
octopi-dev E: Dependency desktop-file-utils detected and not included (needed for update-desktop-database)
octopi-dev W: Dependency qt5-base included but already satisfied
octopi-dev W: Dependency included and not needed ('qt5-declarative')
octopi-dev W: Dependency pacman included but already satisfied
pkgbase=octopi-dev

It is not a split package and this confuses namcap / makepkg

_gitsha256='2eac6062b3589700b0d0e37c601f5bff4ad49dc59847be5950777d7e5a09685c'

Why not just put it in the checksum array?

conflicts=('octopi-git' 'octopi-kde-git' 'octopi-notifier-noknotify')

Did you miss octopi from the array?

  msg "Starting build..."

Why the need for such message and as namcap noted it is not inteded for PKGBUILDs to use makecap's internal functions.

  make -j $cpucount

Why not respect the value set in $MAKEFLAGS?

Offline

#5 2019-07-29 23:31:03

matmoul
Member
Registered: 2015-08-31
Posts: 13

Re: octopi, octopi-dev : need feedbacks...

@loqs Thanks, I've skipped namcap :-(

Your feedbacks is good...

Some errors have been inherited from the current package, I will try to do better.

Offline

#6 2019-07-30 01:02:01

matmoul
Member
Registered: 2015-08-31
Posts: 13

Re: octopi, octopi-dev : need feedbacks...

@loqs I pushed a new code but namcap always say :
PKGBUILD (octopi-dev) E: Child package octopi-dev does not have a valid package() function
I don't find how I can resolve this issue...

From this change all unresolved issue that you presented need more explain!

Offline

#7 2019-07-30 01:39:40

loqs
Member
Registered: 2014-03-06
Posts: 8,169

Re: octopi, octopi-dev : need feedbacks...

diff --git a/PKGBUILD b/PKGBUILD
index f73d082..754579d 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -1,7 +1,6 @@
 # Maintainer: MatMoul <matmoul@gmail.com>
 
-pkgbase=octopi-dev
-pkgname=('octopi-dev')
+pkgname='octopi-dev'
 pkgver=0.9.0
 pkgrel=2
 pkgdesc="A powerful Pacman frontend using Qt5 libs"
@@ -19,7 +18,7 @@ optdepends=('octopi-notifier-qt5: Notifier for Octopi using Qt5 libs'
             'yay: for AUR support'
             'pacmanlogviewer: to view pacman log files')
 provides=('octopi' 'octopi-repoeditor' 'octopi-cachecleaner')
-conflicts=('octopi-git' 'octopi-kde-git' 'octopi-notifier-noknotify')
+conflicts=('octopi' 'octopi-git' 'octopi-kde-git' 'octopi-notifier-noknotify')
 
 _pkggit=octopi
 _gitcommit=31060ae2b2f7c496c95b2262b8219c39b65e45be

Edit:
Second diff (applies after first) a cosmetic change to shorten the PKGBUILD by using for loops

diff --git a/PKGBUILD b/PKGBUILD
index 754579d..c333bcf 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -26,6 +26,8 @@ _gitcommit=31060ae2b2f7c496c95b2262b8219c39b65e45be
 source=("octopi-${pkgver}-${pkgrel}.tar.gz::https://github.com/aarnt/octopi/archive/${_gitcommit}.tar.gz")
 sha256sums=('2eac6062b3589700b0d0e37c601f5bff4ad49dc59847be5950777d7e5a09685c')
 
+_subdirs=(helper repoeditor cachecleaner sudo)
+
 prepare() {
   cd "${srcdir}/${_pkggit}-${_gitcommit}"
   
@@ -40,41 +42,23 @@ build() {
   qmake-qt5 PREFIX=/usr QMAKE_CFLAGS="${CFLAGS}" QMAKE_CXXFLAGS="${CXXFLAGS}" QMAKE_LFLAGS="${LDFLAGS}" octopi.pro -spec linux-clang
   make
 
-  cd helper
-  echo "Building octopi-helper..."
-  qmake-qt5 PREFIX=/usr QMAKE_CFLAGS="${CFLAGS}" QMAKE_CXXFLAGS="${CXXFLAGS}" QMAKE_LFLAGS="${LDFLAGS}" octopi-helper.pro -spec linux-clang
-  make
-
-  cd ../repoeditor
-  echo "Building octopi-repoeditor..."
-  qmake-qt5 PREFIX=/usr QMAKE_CFLAGS="${CFLAGS}" QMAKE_CXXFLAGS="${CXXFLAGS}" QMAKE_LFLAGS="${LDFLAGS}" octopi-repoeditor.pro -spec linux-clang
-  make
-
-  cd ../cachecleaner
-  echo "Building octopi-cachecleaner..."
-  qmake-qt5 PREFIX=/usr QMAKE_CFLAGS="${CFLAGS}" QMAKE_CXXFLAGS="${CXXFLAGS}" QMAKE_LFLAGS="${LDFLAGS}" octopi-cachecleaner.pro -spec linux-clang
-  make
-
-  cd ../sudo
-  echo "Building octopi-sudo..."
-  qmake-qt5 PREFIX=/usr QMAKE_CFLAGS="${CFLAGS}" QMAKE_CXXFLAGS="${CXXFLAGS}" QMAKE_LFLAGS="${LDFLAGS}" octopi-sudo.pro -spec linux-clang
-  make
+  for _subdir in ${_subdirs[@]}; do
+    pushd $_subdir
+    echo "Building octopi-$_subdir..."
+    qmake-qt5 PREFIX=/usr QMAKE_CFLAGS="${CFLAGS}" QMAKE_CXXFLAGS="${CXXFLAGS}" QMAKE_LFLAGS="${LDFLAGS}" "octopi-$_subdir.pro" -spec linux-clang
+    make
+    popd
+  done
 }
 
 package() {
   cd "${srcdir}/${_pkggit}-${_gitcommit}"
   
   make INSTALL_ROOT="${pkgdir}" install
-  
-  cd helper
-  make INSTALL_ROOT="${pkgdir}" install
-  
-  cd ../repoeditor
-  make INSTALL_ROOT="${pkgdir}" install
-  
-  cd ../cachecleaner
-  make INSTALL_ROOT="${pkgdir}" install
-  
-  cd ../sudo
-  make INSTALL_ROOT="${pkgdir}" install
+
+  for _subdir in ${_subdirs[@]}; do
+    pushd $_subdir
+    make INSTALL_ROOT="${pkgdir}" install
+    popd
+  done
 }

Last edited by loqs (2019-07-30 02:14:43)

Offline

#8 2019-08-01 18:03:16

Morganamilo
Member
Registered: 2017-12-05
Posts: 69

Re: octopi, octopi-dev : need feedbacks...

Also you should just conflict with octopi. I assume octopi-git and co. provide octopi.

Offline

#9 2019-08-03 00:12:26

matmoul
Member
Registered: 2015-08-31
Posts: 13

Re: octopi, octopi-dev : need feedbacks...

@loqs The for loop with the "_subdirs" array is a good solution, I'll implement it...
@Morganamilo It seem you're right, I'll implement it too...

Offline

#10 2019-08-03 00:24:13

matmoul
Member
Registered: 2015-08-31
Posts: 13

Re: octopi, octopi-dev : need feedbacks...

@loqs I don't know very well popd, is this required here? And why?

Offline

#11 2019-08-03 11:22:12

loqs
Member
Registered: 2014-03-06
Posts: 8,169

Re: octopi, octopi-dev : need feedbacks...

pushd and popd are bash builtins for storing / changing the working directory in this instance you could replace them with cd $_subdir and cd ..
The change back to one directory higher is needed so the pushd (cd) at the start of the loop will work.
More details on the use of pushd and popd in the bash manpage.

Offline

#12 2019-08-05 18:55:40

matmoul
Member
Registered: 2015-08-31
Posts: 13

Re: octopi, octopi-dev : need feedbacks...

@loqs Thanks, your little explanation reminds me when I learn these two cmd without finding a good use.
Now I can use them in a useful context ...

Offline

#13 2019-08-06 21:09:39

matmoul
Member
Registered: 2015-08-31
Posts: 13

Re: octopi, octopi-dev : need feedbacks...

I pushed the changes on the same release...

Before providing a new release, I would ask if @loqs and @Morganamilo would like to be added as contributors?

Offline

Board footer

Powered by FluxBB