You are not logged in.

#1 2020-04-18 11:04:36

yaa110
Member
Registered: 2020-04-18
Posts: 2

PKGBUILD review request: nomino-bin

nomino is a batch rename utility written in Rust.

# Maintainer: yaa110 <yaa110@gmail.com>

pkgname=nomino-bin
_pkgname=nomino
pkgver=0.1.4
pkgrel=2
arch=('x86_64')
url="https://github.com/yaa110/nomino"
license=("MIT")

pkgdesc='Batch rename utility for developers'

source=("LICENSE::https://raw.githubusercontent.com/yaa110/$_pkgname/master/LICENSE-MIT")
source_x86_64=("https://github.com/yaa110/$_pkgname/releases/download/$pkgver/$_pkgname-linux-64bit")
sha512sums=("169b314c09dffe76c8bf31929a61e58358c66516c17629cb257e0d44101b78d3949ee6d9951bb813cd6348d8626a0c8f638f6f874db446dce87cfa1de24d39ba")
sha512sums_x86_64=("f787a969fc8a60fdb28b9ce18095d5431f6eda7be47fd25eb9364e10e406dfcf55d8271ed8428311c409a042cd4de9563e905f79765176f789909d2f8691836a")
depends=('gcc-libs')
conflicts=('nomino')
provides=('nomino')

package() {
    install -Dm755 "$srcdir/$_pkgname-linux-64bit" "$pkgdir/usr/bin/$_pkgname"
    install -Dm644 "$srcdir/LICENSE" "$pkgdir/usr/share/licenses/$pkgname/LICENSE"
}

Last edited by yaa110 (2020-04-18 11:16:52)

Offline

#2 2020-04-18 11:28:09

ayekat
Member
Registered: 2011-01-17
Posts: 1,385
Website

Re: PKGBUILD review request: nomino-bin

Is there a reason to create a -bin package instead of compiling the sources directly? -bin packages should IMHO only be used for e.g. fully/partially/quasi closed-source upstream, or as an alternative if building takes a lot of time (e.g. web browsers). This does not seem to be the case here (I'm not a TU, though, so I might be wrong about the purpose of -bin packages). There is also no non-bin package in the AUR, so I guess it would be more valuable to have that first.

Then again, upstream here doesn't appear to properly explain how the project can be built to begin with (although, I guess people familiar with Rust might still know how to build it properly).
It only suggests `curl -sSf https://sh.rustup.rs | sh`, which is the kind of instructions that should be ignored.

Furthermore, why is the pkgrel 2? Or has an older variant of this PKGBUILD already been released elsewhere?

--edit: Alright, I just saw that you immediately followed this up by another post for the non-bin package.
Btw, that other package doesn't need to conflict with this one here. See https://wiki.archlinux.org/index.php/PKGBUILD#conflicts for more details.

Last edited by ayekat (2020-04-18 11:31:23)


{,META,RE}PKGBUILDSpacman-hacks (includes makemetapkg and remakepkg) │ dotfiles

Offline

#3 2020-04-19 06:12:56

eschwartz
Trusted User/Bug Wrangler
Registered: 2014-08-08
Posts: 3,309

Re: PKGBUILD review request: nomino-bin

The sources should be renamed, because "nomino-linux-64bit" will conflict with new versions unless you add the $pkgver in there, and "LICENSE" will conflict with any other PKGBUILD when the user uses a shared $SRCDEST.


Managing AUR repos The Right Way -- aurpublish (now a standalone tool)

Offline

Board footer

Powered by FluxBB