You are not logged in.

#1 2020-10-09 14:22:18

Asuranceturix
Member
Registered: 2020-10-08
Posts: 3

PKGBUILD review request: adobe-reader-11

Hi, I've tried to package Adobe Acrobat XI to run under Wine because I am unaware of any native alternative for interactively inserting visible digital signatures into PDFs. I've read and tried to follow the "Wine package guidelines" but I'd like some peer review before uploading it to the AUR, if it is acceptable. Being several files, I don't know whether I should post them directly here, so I have set up a public repo at https://github.com/Asuranceturix/adobe-reader-11 . Thanks for the help!

Offline

#2 2020-10-09 17:01:09

loqs
Member
Registered: 2014-03-06
Posts: 11,917

Re: PKGBUILD review request: adobe-reader-11

Should the license not be custom https://wwwimages2.adobe.com/www.adobe. … 7_1357.pdf instead of freeware?
.desktop files,  launcher scripts,  patches e.t.c. are all allowed in AUR.

I can not offer advice on the rest as I do not use wine.

Offline

#3 2020-10-09 17:47:24

Asuranceturix
Member
Registered: 2020-10-08
Posts: 3

Re: PKGBUILD review request: adobe-reader-11

loqs wrote:

Should the license not be custom https://wwwimages2.adobe.com/www.adobe. … 7_1357.pdf instead of freeware?

Certainly, I just took the "freeware" from Wikipedia, but if "custom" is what is used in these cases on the AUR I will.

loqs wrote:

.desktop files,  launcher scripts,  patches e.t.c. are all allowed in AUR.

I meant here in the forum, that I don't know whether it is more comfortable to paste several relatively long listings or just link to the repository. Happy to edit the post if the custom here is the former.

Thanks for your input!

Offline

#4 2020-10-09 17:56:19

loqs
Member
Registered: 2014-03-06
Posts: 11,917

Re: PKGBUILD review request: adobe-reader-11

PKGBUILD#license covers the steps needed for a custom license.

Offline

#5 2020-10-10 01:43:17

Asuranceturix
Member
Registered: 2020-10-08
Posts: 3

Re: PKGBUILD review request: adobe-reader-11

Ok, I fixed the license bit as suggested and updated the repo. I also parameterized the name of the package and associated scripts because I don't know whether this is the preferred naming scheme for AUR.

Offline

Board footer

Powered by FluxBB