You are not logged in.
link: https://github.com/unmellow/agregore-browser-aur
haven't posted it to AUR yet I'm getting namcap errors but it is not clear to me how I would fix it
I would like to add that the installer works (slowly) for me so I'm not sure if i need to fix the errors
Last edited by unmellow (2021-01-26 20:41:58)
Offline
Offline
Please read...
https://wiki.archlinux.org/index.php/No … guidelines
Why not just copy the binary to /usr/bin instead? Then you don't need the sh file.
Offline
Are the twenty nine thousand files copied from ${_pkgname}/release/linux-unpacked/* all needed? Particularly ones for other architectures and source code.
Edit:
Why the lib32-gcc-libs dependency?
Last edited by loqs (2021-01-26 21:31:06)
Offline
Are the twenty nine thousand files copied from ${_pkgname}/release/linux-unpacked/* all needed? Particularly ones for other architectures and source code.
Edit:
Why the lib32-gcc-libs dependency?
lib32-gcc-libs is needed by one of the binary's in node-modules i did it this way out of lazyness
Offline
Please read...
https://wiki.archlinux.org/index.php/No … guidelinesWhy not just copy the binary to /usr/bin instead? Then you don't need the sh file.
I assumed the binary depended on the files in the linux-unpacked directory let me test it though
Offline
Electron-based browser, very insecure...
Since it contains compiled ELF files, one of your namcap warnings was probably pointing out this cannot be arch=(any) and must instead be arch=(x86_64).
Also, it should be installed to /usr/lib/agregore-browser/ not /usr/share/agregore-browser/
Also, did you consider trying to use the system electron? https://wiki.archlinux.org/index.php/El … guidelines
srcdir and pkgdir variables must be quoted every time. They can contain any path name, and may have spaces in them.
Per the instructions at https://wiki.archlinux.org/index.php/VC … elines#Git please remove the "v" in the version.
Managing AUR repos The Right Way -- aurpublish (now a standalone tool)
Offline
Electron-based browser, very insecure...
Since it contains compiled ELF files, one of your namcap warnings was probably pointing out this cannot be arch=(any) and must instead be arch=(x86_64).
Also, it should be installed to /usr/lib/agregore-browser/ not /usr/share/agregore-browser/
Also, did you consider trying to use the system electron? https://wiki.archlinux.org/index.php/El … guidelines
srcdir and pkgdir variables must be quoted every time. They can contain any path name, and may have spaces in them.
Per the instructions at https://wiki.archlinux.org/index.php/VC … elines#Git please remove the "v" in the version.
I did everything except the system electron thing I'll do that last
havent commited yet wasn't building assumed i added a bug need to delete everything real quick will commit soon tm
Last edited by unmellow (2021-01-27 00:24:26)
Offline
Electron-based browser, very insecure...
Since it contains compiled ELF files, one of your namcap warnings was probably pointing out this cannot be arch=(any) and must instead be arch=(x86_64).
Also, it should be installed to /usr/lib/agregore-browser/ not /usr/share/agregore-browser/
Also, did you consider trying to use the system electron? https://wiki.archlinux.org/index.php/El … guidelines
srcdir and pkgdir variables must be quoted every time. They can contain any path name, and may have spaces in them.
Per the instructions at https://wiki.archlinux.org/index.php/VC … elines#Git please remove the "v" in the version.
if I'm not mistaken i made every change except the electron one correct? will do the rest tomorrow thanks!
(i know piping sed into sed is not the correct way to do this but i copy pasted that from another aur package and don't know how to change it)
Last edited by unmellow (2021-01-27 00:41:21)
Offline
(i know piping sed into sed is not the correct way to do this but i copy pasted that from another aur package and don't know how to change it)
There is an example showing how to remove a prefix in the link eschwartz provided.
Offline
unmellow wrote:(i know piping sed into sed is not the correct way to do this but i copy pasted that from another aur package and don't know how to change it)
There is an example showing how to remove a prefix in the link eschwartz provided.
I should read links lol thanks
Offline
Also, did you consider trying to use the system electron? https://wiki.archlinux.org/index.php/El … guidelines
OK it is using system electron.. but the way I did it is probably not best practice
(npm install in the install script)
I tried modifying electron-builder but i got infinite recursion E.G.
${srcdir}/agregore-browser/release/linux-unpacked/release/linux-unpacked/release etc...
this happened during build If you want the actual output I can get it just ask
Last edited by unmellow (2021-01-27 19:37:06)
Offline
eschwartz wrote:
Also, did you consider trying to use the system electron? https://wiki.archlinux.org/index.php/El … guidelines
OK it is using system electron.. but the way I did it is probably not best practice
(npm install in the install script)I tried modifying electron-builder but i got infinite recursion E.G.
${srcdir}/agregore-browser/release/linux-unpacked/release/linux-unpacked/release etc...this happened during build If you want the actual output I can get it just ask
IDK why but my builds will no longer start I don't know why and I give up thanks for everything
Offline
I'm very confused, since this isn't remotely anything like what the wiki guidelines I linked to recommend.
Maybe if you tried actually following the wiki page, you'd have more luck getting a system electron to work?
Managing AUR repos The Right Way -- aurpublish (now a standalone tool)
Offline
@eschwartz I tried following Electron_package_guidelines using the CLI approach, the dist argument to --dir was rejected so I removed that.
The produced package is very similar to that produced by unmellow's first PKGBUILD, both include 2900+ files. Are those all needed?
# Maintainer: Unmellow <name2020@googlemail.commerce>
_pkgname=agregore-browser
pkgname=agregore-browser-git
pkgver=1.0.0.30.r3.gdc755dc
pkgrel=1
pkgdesc="A minimal browser for the distributed web"
arch=('x86_64')
url="https://github.com/AgregoreWeb/agregore-browser"
license=(AGPL)
makedepends=('git' 'npm')
depends=('electron' 'python3' 'nodejs')
source=("git+https://github.com/AgregoreWeb/agregore-browser/"
"agregore-browser.desktop"
"agregore-browser.sh")
sha1sums=('SKIP'
'94f52aba0d484b95180774fd5a23a19cca9d5dde'
'4b4467fef75406e8e669422b85e68c8f15b3beaf')
pkgver() {
cd "$_pkgname"
# cutting off 'v' prefix that presents in the git tag
git describe --long | sed 's/^v//;s/\([^-]*-g\)/r\1/;s/-/./g'
}
build() {
cd "${srcdir}/${_pkgname}"
# use system electron version
# see: https://wiki.archlinux.org/index.php/Electron_package_guidelines
electronDist=$(dirname $(realpath $(which electron)))
electronVer=$(electron --version | tail -c +2)
sed -i '/ "electron": /d' ./package.json
HOME="$srcdir/.electron-gyp" npm install --cache "${srcdir}/npm-cache"
./node_modules/.bin/electron-builder --linux --x64 -c.electronDist=$electronDist -c.electronVersion=$electronVer --dir
}
package() {
### builded
install -d "${pkgdir}/usr/lib/agregore-browser"
cp -r "${srcdir}/${_pkgname}/"release/linux-unpacked/* "${pkgdir}/usr/lib/agregore-browser/"
### tools
install -Dm644 "${srcdir}/agregore-browser.desktop" "${pkgdir}/usr/share/applications/agregore-browser.desktop"
install -Dm755 "${srcdir}/agregore-browser.sh" "${pkgdir}/usr/bin/agregore-browser"
### LICENSE
install -Dm644 "${_pkgname}/LICENSE" "$pkgdir/usr/share/licenses/$pkgname/LICENSE"
}
# vim:set ts=2 sw=2 et:
Offline
@eschwartz I tried following Electron_package_guidelines using the CLI approach, the dist argument to --dir was rejected so I removed that.
The produced package is very similar to that produced by unmellow's first PKGBUILD, both include 2900+ files. Are those all needed?# Maintainer: Unmellow <name2020@googlemail.commerce> _pkgname=agregore-browser pkgname=agregore-browser-git pkgver=1.0.0.30.r3.gdc755dc pkgrel=1 pkgdesc="A minimal browser for the distributed web" arch=('x86_64') url="https://github.com/AgregoreWeb/agregore-browser" license=(AGPL) makedepends=('git' 'npm') depends=('electron' 'python3' 'nodejs') source=("git+https://github.com/AgregoreWeb/agregore-browser/" "agregore-browser.desktop" "agregore-browser.sh") sha1sums=('SKIP' '94f52aba0d484b95180774fd5a23a19cca9d5dde' '4b4467fef75406e8e669422b85e68c8f15b3beaf') pkgver() { cd "$_pkgname" # cutting off 'v' prefix that presents in the git tag git describe --long | sed 's/^v//;s/\([^-]*-g\)/r\1/;s/-/./g' } build() { cd "${srcdir}/${_pkgname}" # use system electron version # see: https://wiki.archlinux.org/index.php/Electron_package_guidelines electronDist=$(dirname $(realpath $(which electron))) electronVer=$(electron --version | tail -c +2) sed -i '/ "electron": /d' ./package.json HOME="$srcdir/.electron-gyp" npm install --cache "${srcdir}/npm-cache" ./node_modules/.bin/electron-builder --linux --x64 -c.electronDist=$electronDist -c.electronVersion=$electronVer --dir } package() { ### builded install -d "${pkgdir}/usr/lib/agregore-browser" cp -r "${srcdir}/${_pkgname}/"release/linux-unpacked/* "${pkgdir}/usr/lib/agregore-browser/" ### tools install -Dm644 "${srcdir}/agregore-browser.desktop" "${pkgdir}/usr/share/applications/agregore-browser.desktop" install -Dm755 "${srcdir}/agregore-browser.sh" "${pkgdir}/usr/bin/agregore-browser" ### LICENSE install -Dm644 "${_pkgname}/LICENSE" "$pkgdir/usr/share/licenses/$pkgname/LICENSE" } # vim:set ts=2 sw=2 et:
so i literally just stole this and added some
finds for deletion it seems to work and is little bit smaller
I might be able to get more space but I'm working on that
thanks loqi!
Last edited by unmellow (2021-02-07 06:59:03)
Offline