PKGBULID review request: Wonderwall Wallpaper Manager

keshavbhatt · 2022-02-02 21:17:03

Hi, I'm making a PKGBUILD for my application "Wonderwall Wallpaper Manager"

Project: https://snapcraft.io/wonderwall

This is the PKGBUILD I created is located here: https://github.com/keshavbhatt/WonderWa … D/PKGBUILD

Please note that the PKGBUILD needs a few helper scripts that can be found in the repo here: https://github.com/keshavbhatt/WonderWa … n/PKGBUILD.
I build a local package with makepkg and installed it on my system everything works fine.

# Maintainer: Keshav Bhatt <keshavnrj@gmail.com>

pkgname=wonderwall
pkgver=7.0
pkgrel=1
pkgdesc="WonderWall is a Powerful Desktop Wallpaper manager for Linux and Windows Desktop"
arch=('x86_64')
url="https://snapcraft.io/wonderwall"
license=('PROPRIETARY')
options=('!strip')
depends=(
  'brotli'
  'bzip2'
  'double-conversion'
  'e2fsprogs'
  'freetype2'
  'gcc-libs'
  'glib2'
  'glibc'
  'graphite'
  'harfbuzz'
  'hyphen'
  'icu'
  'keyutils'
  'krb5'
  'libcap'
  'libelf'
  'libffi'
  'libgcrypt'
  'libglvnd'
  'libgpg-error'
  'libjpeg-turbo'
  'libpng'
  'libunwind'
  'libwebp'
  'libxau'
  'libxcb'
  'libxdmcp'
  'libxml2'
  'libxslt'
  'lz4'
  'md4c'
  'openssl'
  'orc'
  'pcre'
  'pcre2'
  'qt5-base'
  'qt5-declarative'
  'qt5-webkit'
  'sqlite'
  'woff2'
  'xz'
  'zlib'
  'zstd'
)

makedepends=('squashfs-tools' 'jq')
sha256sums=('a6c0061deecb245d8009b48720ee737645515ac8ba52495993494c5c217f4306'
            'ca267d51f998533fad921b8f69e81a79f2383862dcb007cac6d3358db00d1a91'
            'fb53d00bf9d57f00c644c81bae0f97fd921a6d387720461cff144918356965ab'
            '073d9958368a1abe4385a8c63ce2f346e823a6772f4c8064b96561a7c1d8e04f')

DLAGENTS+=("snap::${BASH_SOURCE[0]%/*}/snap-dlagent.sh %u %o")
source=("${pkgname}-${pkgver}.squashfs::snap://api.snapcraft.io/v2/snaps/info/wonderwall"
  snap-dlagent.sh
  "${pkgname}.desktop"
  "${pkgname}.sh"
)

prepare() {
  cd "${srcdir}"

  msg2 "Extraction..."
  unsquashfs ${pkgname}-${pkgver}.squashfs
}

package() {
  cd "${srcdir}"

  mkdir -p "${pkgdir}/opt/"
  cp -r squashfs-root "${pkgdir}/opt/${pkgname}"
  install -Dm755 wonderwall.sh \
    "${pkgdir}/usr/bin/${pkgname}"
  install -Dm644 squashfs-root/meta/gui/icon.png \
    "${pkgdir}/usr/share/pixmaps/${pkgname}.png"
  install -Dm644 "${pkgname}.desktop" \
    "${pkgdir}/usr/share/applications/${pkgname}.desktop"
}

This is my first ever attempt to publish an app in AUR, my other projects are also here but maintained by other people.

Thanks.

Last edited by keshavbhatt (2022-02-02 21:21:23)

Trilby · 2022-02-02 22:08:06

The PKGBUILD says "PROPRIETARY" in the license field, but the license in the repo is an MIT license. Which is it? Is this an open source project - in other words, is the source available somewhere? If not, I'm not sure if the MIT license can be used (I can't actually verify at the moment whether an author needs to make source available to use the MIT license, but it's certainly expected and not doing so breaks expected de-facto standards). If it is open source, why require a custom DLAGENT to extract from a snap? Just build it from source.

Arch Linux

#1 2022-02-02 21:17:03

PKGBULID review request: Wonderwall Wallpaper Manager

#2 2022-02-02 22:08:06

Re: PKGBULID review request: Wonderwall Wallpaper Manager

Board footer