You are not logged in.

#1 2022-02-06 05:21:45

WTechNinja
Member
Registered: 2020-11-16
Posts: 7

PKGBUILD review request: manga-cli-git

It's my first PKGBUILD, Mostly stolen from openlp-git.

# Maintainer: Walter Broemeling <wallebroem at gmail dot com>

pkgname=manga-cli-git
pkgver=r2.31d744c
pkgrel=1
pkgdesc="A Bash script for reading mangas via the terminal"
arch=('any')
url='https://github.com/7USTIN/manga-cli'
license=('GPL3')
depends=('sh' 'coreutils' 'curl' 'sed' 'awk' 'diffutils' 'patch' 'imagemagick' 'zathura')
makedepends=("git")
source=('git+https://github.com/7USTIN/manga-cli.git')
sha256sums=('SKIP')


pkgver() {
  cd "${srcdir}"/manga-cli
  printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short HEAD)"
}

package() {
  cd "${srcdir}"/manga-cli
  install -Dm755 "$srcdir/manga-cli/manga-cli" "$pkgdir/usr/bin/manga-cli"
}

Anything need fixing?

Last edited by WTechNinja (2022-02-06 17:04:05)

Offline

#2 2022-02-06 15:29:09

0b100100
Member
Registered: 2021-09-04
Posts: 9

Re: PKGBUILD review request: manga-cli-git

First off, welcome to the community :-)

Looking at other PKGBUILDs gives a good impression how packages can be built...
But nothing beats the up-to-date wiki which should be the first place to obtain information.

Some fixes:
1. The license should be 'GPL3'
2. Packages should never be installed to /usr/local/bin/, please change it to /usr/bin/
3. The dependencies are probably missing 'sh' or 'bash'

Offline

#3 2022-02-06 17:06:19

WTechNinja
Member
Registered: 2020-11-16
Posts: 7

Re: PKGBUILD review request: manga-cli-git

Thank you! Fixed those, and I updated the post. I doublechecked that the script runs under sh, and then added it.
Edit: I moved the files and now something's broken, I'll keep messing with things...

Last edited by WTechNinja (2022-02-06 17:15:02)

Offline

#4 2022-02-06 19:19:45

0b100100
Member
Registered: 2021-09-04
Posts: 9

Re: PKGBUILD review request: manga-cli-git

Looks good.

Just played with the program myself and I saw it also depends on a pdf plugin for zathura.
Either zathura-pdf-mupdf or zathura-pdf-poppler could be added as another dependencies.

However, in this particular case I'm not sure what to take as both packages provide a pdf plugin but conflict with each other.
The ideal case would be if both packages contain a provides array like "provides=('zathura-pdf')".
In this case you could just add "zathura-pdf" as a dependency to let the user decide which package to install.

I would ask the current package manager of both packages if he would change his packages accordingly.

Offline

#5 2022-02-06 19:26:18

WTechNinja
Member
Registered: 2020-11-16
Posts: 7

Re: PKGBUILD review request: manga-cli-git

Ah, good catch. I'll send him an email and see what happens.

Offline

#6 2022-02-06 23:47:43

WTechNinja
Member
Registered: 2020-11-16
Posts: 7

Re: PKGBUILD review request: manga-cli-git

Well, forget this, someone beat me to it. When I first looked at it there  was no package, but there is one now. If the maintainer of the zathura plugins responds and adds the provides line, I'll send the current maintainer of anime-cli-git an email letting him know he can use that. Thanks for everything, it's all solid experience.

Offline

#7 2022-02-07 20:18:39

0b100100
Member
Registered: 2021-09-04
Posts: 9

Re: PKGBUILD review request: manga-cli-git

Argh, this is an unlucky coincidence.

Sure, this will definitely help to improve the PKGBUILD. You could also make use of the comment function on the AUR package page.

You are welcome.

Offline

Board footer

Powered by FluxBB