You are not logged in.

#1 2022-05-21 08:20:00

AkechiShiro
Member
Registered: 2017-01-22
Posts: 6

Package review request : Metacall-git

Hi,

I'm a bit new at writing and fixing packages, this is a new software I've packaged in the AUR, I would like to know the quality of my current PKGBUILD, and if there is anything I can make better feel free to suggest, I'll do my best to make it cleanest as possible.

# Maintainer: Lahfa Samy <'akechishiro-aur' at domain 'lahfa.xyz'>
pkgname=metacall-git
pkgver=v0.5.20.r12.g2a4a9ee1
pkgrel=1
pkgdesc='A CLI for a library providing inter-language foreign function interface calls'
arch=('x86_64')
url='https://github.com/metacall/core'
license=('Apache')
makedepends=('cmake' 'git') # Build deps
optdepends=('dotnet-sdk-bin: C# support' 
            'python: Python3 support' 
            'ruby: Ruby support' 
            'clang: C support' 
            'jre-openjdk-headless: JAVA support' 
            'nodejs: NodeJS support' 
            'typescript: TypeScript support') # optional runtime deps
provides=('metacall')
source=(${pkgname}::git+${url})
sha256sums=('SKIP')

pkgver() {
  cd "${pkgname}"
  git describe --long --tags | sed 's/\([^-]*-g\)/r\1/;s/-/./g'
}

build() {
    METACALL_LOADER_C="${METACALL_LOADER_C:=off}"
    METACALL_LOADER_CS="${METACALL_LOADER_CS:=off}"
    METACALL_LOADER_COB="${METACALL_LOADER_COB:=off}"
    METACALL_LOADER_JAVA="${METACALL_LOADER_JAVA:=off}"
    METACALL_LOADER_FILE="${METACALL_LOADER_FILE:=off}"
    METACALL_LOADER_NODE="${METACALL_LOADER_NODE:=off}"
    METACALL_LOADER_JS="${METACALL_LOADER_JS:=off}"
    METACALL_LOADER_PY="${METACALL_LOADER_PY:=off}"
    METACALL_LOADER_RB="${METACALL_LOADER_RB:=off}"
    METACALL_LOADER_TS="${METACALL_LOADER_TS:=off}"
    cmake -B build -S "${pkgname}" \
        -DCMAKE_BUILD_TYPE='Release' \
        -DCMAKE_INSTALL_PREFIX='/usr' \
        -DOPTION_BUILD_LOADERS_C=$METACALL_LOADER_C \
        -DOPTION_BUILD_LOADERS_COB=$METACALL_LOADER_COB \
        -DOPTION_BUILD_LOADERS_JAVA=$METACALL_LOADER_JAVA \
        -DOPTION_BUILD_LOADERS_NODE=$METACALL_LOADER_NODE \
        -DOPTION_BUILD_LOADERS_JS=$METACALL_LOADER_JS \
        -DOPTION_BUILD_LOADERS_PY=$METACALL_LOADER_PY \
        -DOPTION_BUILD_LOADERS_RB=$METACALL_LOADER_RB \
        -DOPTION_BUILD_LOADERS_TS=$METACALL_LOADER_TS \
        -DOPTION_BUILD_LOADERS_MOCK=off \
        -Wno-dev
    cmake --build build
}

# Check are not working fine for now as such they are disabled.
#check() {
#    cd build
#    ctest --output-on-failure
#}

package() {
    DESTDIR="$pkgdir" cmake --install build
    printf "\033[0;31m In order to have a specific language support, rebuild the environnement variable \"METACALL_LOADER_language=on\" set.\n"
    printf "\033[0;31m See https://github.com/metacall/core/blob/develop/docs/README.md#21-loaders-backends for current available loaders.\n"
}

Offline

#2 2022-05-21 11:50:53

Scimmia
Fellow
Registered: 2012-09-01
Posts: 9,281

Re: Package review request : Metacall-git

There is no concept of 'build time optional' in a PKGBUILD. This means all of your optional deps are wrong. Using env variables to choose doesn't work, either, as packages should be (and often are) built in a chroot/container.

Why dotnet-sdk-bin instead of dotnet-sdk in Community?

Last edited by Scimmia (2022-05-21 11:52:06)

Offline

#3 2022-05-21 12:29:59

AkechiShiro
Member
Registered: 2017-01-22
Posts: 6

Re: Package review request : Metacall-git

Oh, I thought it was possible to use build time optional ENV variables as for this package it is used for langage purposes for instance : https://aur.archlinux.org/cgit/aur.git/ … or-browser

I choose dotnet-sdk-bin because it has probably fewer dependencies than dotnet-sdk, but I think in my case I may actually need dotnet-sdk.

The issue with the package metacall is that unless I have a "build time optional" options, I can't just give out metacall-{python,dotnet,c,nodejs,java}-git.

Actually, all these need are probably dynamic libraries, so it might actually be a way to package metacall without the "build time optional" in Arch Linux, I'll be checking with upstream maintainers if that's a possible solution for an evolution of the quality of the package.

Offline

Board footer

Powered by FluxBB