unzip dependency?

Dusty · 2004-03-29 19:07:54

Mr Green just tested a package I've built, and got this error:

==> Found jd4xarch.patch in build dir
==> Found jd4x.sh in build dir
==> Validating source files with MD5sums
jd4x-src-v0.2b13.tar.gz ... Passed
looks-1_2_1.zip ... Passed
jd4xarch.patch ... Passed
jd4x.sh ... Passed
==> Extracting Sources...
==> tar --use-compress-program=gzip -xf jd4x-src-v0.2b13.tar.gz
==> unzip -qqo looks-1_2_1.zip
/usr/bin/makepkg: line 473: unzip: command not found
==> ERROR: Failed to extract looks-1_2_1.zip
==> Aborting...

pacman -Sy unzip and then rerunning makepkg fixed the problem. My question is if unzip should be a make dependency for the package I've built.

I actually think that makepkg should depend on unzip, if it uses unzip to access files stored in the zip format. It automatically unzips (or untars) packages, so it needs unzip to operate, no?

Is this a feature or a bug; should I report it?

Dusty

contrasutra · 2004-03-29 20:13:18

I think you should just make "unzip" a makedepend.

Xentac · 2004-03-30 16:05:49

We, the developers, have just talked about this. Because makepkg uses unzip to uncompress the file and it's not strictly part of the build system, it doesn't need to be part of the PKGBUILD.

There are assumptions that can be made with PKGBUILDs, and having unzip to unzip source files is one of them.

Dusty · 2004-03-30 16:29:52

So basically the next person to get this error should just pacman -S unzip and keep shut?

Xentac · 2004-03-30 16:32:33

Yup.

Arch Linux

#1 2004-03-29 19:07:54

unzip dependency?

#2 2004-03-29 20:13:18

Re: unzip dependency?

#3 2004-03-30 16:05:49

Re: unzip dependency?

#4 2004-03-30 16:29:52

Re: unzip dependency?

#5 2004-03-30 16:32:33

Re: unzip dependency?

Board footer