Arch Linux

GANPI

Member

Registered: 2023-02-11

Posts: 20

PKGBUILD review: pcsx2

This is my first pack and it's for personal use.

My question is what dependencies should be added?. All dependencies in the list are what namcap shows except qt6-svg. Im not sure whether to add all the dependencies that namcap shows or exclude some like:

• curl

• dbus

• gcc-libs

• glibc

• hicolor-icon-theme

• systemd-libs

• xz

• zlib

# Maintainer: GANPI <¿@?>
pkgname=pcsx2
pkgver=1.7.4883
_appimage=$pkgname-v$pkgver-linux-appimage-x64-Qt.AppImage
pkgrel=3
pkgdesc="A Sony PlayStation 2 emulator"
arch=(x86_64)
url=https://$pkgname.net/
license=(GPL3 LGPL3)
depends=(
	bash
	curl
	dbus
	gcc-libs
	glibc
	hicolor-icon-theme
	libaio
	libglvnd
	libpng
	libxrandr
	qt6-base
	qt6-svg
	sdl2
	systemd-libs
	xz
	zlib
)
source=(https://github.com/PCSX2/$pkgname/releases/download/v$pkgver/$_appimage)
sha256sums=(66ad18cc67af7f0edadcc6d0ef0a9781baeb9136baf7580989a920179390666d)

_domain=net.$pkgname.PCSX2

prepare() {
	chmod +x $_appimage
	./$_appimage --appimage-extract

	cd squashfs-root/

	# Script that run the bin
	printf "%b#! /usr/bin/env bash\n\nexec /opt/$pkgname/usr/bin/$pkgname" > $srcdir/$pkgname

	# Change the value of "Exec" and "Icon"
	sed -i "9s/.*/Exec=$pkgname/; 10s/.*/Icon=$pkgname/" $_domain.desktop
}

package() {
	cd squashfs-root/

	# binary
	install -Dm755 usr/bin/$pkgname-qt $pkgdir/opt/$pkgname/usr/bin/$pkgname

	# resources/ translations/
	cp -r usr/bin/resources/ $pkgdir/opt/$pkgname/usr/bin/

	install -Dm644 usr/bin/translations/$pkgname* -t $pkgdir/opt/$pkgname/usr/bin/translations/

	# libpcap.so.0.8
	install -Dm644 usr/lib/libpcap.so.0.8 -t $pkgdir/opt/$pkgname/usr/lib/

	# script
	install -Dm755 $srcdir/$pkgname -t $pkgdir/usr/bin/

	# .desktop
	install -Dm644 $_domain.desktop -t $pkgdir/usr/share/applications/

	# icon
	install -Dm644 PCSX2.png $pkgdir/usr/share/icons/hicolor/512x512/apps/$pkgname.png

	# metainfo
	install -Dm644 usr/share/metainfo/$_domain.appdata.xml -t $pkgdir/usr/share/metainfo/
}}

Trilby

Inspector Parrot

Registered: 2011-11-29

Posts: 30,105

Website

Re: PKGBUILD review: pcsx2

This would at least need a -bin suffix on pkgname.  Why are you using the appimage for this rather than building it from source?

---

"UNIX is simple and coherent" - Dennis Ritchie; "GNU's Not Unix" - Richard Stallman

Allan

Pacman

From: Brisbane, AU

Registered: 2007-06-09

Posts: 11,449

Website

Re: PKGBUILD review: pcsx2

The dependencies look fine.  You could technically remove glibc, gcc-libs, xz, systemd-libs, and zlib as they are covered by the base package, but it does not hurt to be explicit here.

---

PGP Key: F99FFE0FEAE999BD | I develop pacman - buy me a drink!

GANPI

Member

Registered: 2023-02-11

Posts: 20

Re: PKGBUILD review: pcsx2

This would.... Why are you using the appimage for this rather than building it from source?

The processor temperature gets too high when compiling pcsx2 and other packages and I decided to use the binaries as the first option and the compilation as the second option.

Irets

Member

Registered: 2019-02-01

Posts: 143

Re: PKGBUILD review: pcsx2

Something to consider is you can reduce the amount of threads used by the compiler.
The drawback is that it takes longer.