You are not logged in.

Pages: 1

#1 2024-02-13 19:43:36

train
Member
Registered: 2007-03-17
Posts: 38

[SOLVED] PKGBUILD review: python-scrolltext

Hi,

i'd like to add new python package to the AUR. It's a small leisure kind of "game"/"utility" project.

Please find the PKGBUILD here:

https://gist.github.com/jimdeekepler/94 … 435f47fdfd

Any comments welcome. How to proceed from here? (first-timer here)

BR.

Last edited by train (2024-02-17 08:50:00)

Offline

#2 2024-02-13 21:33:47

loqs
Member
Registered: 2014-03-06
Posts: 17,488

Re: [SOLVED] PKGBUILD review: python-scrolltext

url="https://github.com/jimdee/python-scrolltext"

Should it not be https://github.com/jimdeekepler/python-scrolltext

license=('GPL')

https://github.com/jimdeekepler/python- … in/LICENSE can be either SPDX identifierGPL-3.0-only GPL-3.0-or-later

depends=()

The package does not use python to run?

Offline

#3 2024-02-13 23:49:16

train
Member
Registered: 2007-03-17
Posts: 38

Re: [SOLVED] PKGBUILD review: python-scrolltext

Thank you for you input. I've updated the gist. Can you have another look please?

Offline

#4 2024-02-14 19:46:24

loqs
Member
Registered: 2014-03-06
Posts: 17,488

Re: [SOLVED] PKGBUILD review: python-scrolltext

Minor nit:

echo "$source"

Everything else looks fine.

Offline

#5 2024-02-14 20:17:01

Scimmia
Fellow
Registered: 2012-09-01
Posts: 11,614

Re: [SOLVED] PKGBUILD review: python-scrolltext

The python- prefix in the pkgname is used for libraries, doesn't seem like it should be used here.

Edit: Ref https://wiki.archlinux.org/title/Python … age_naming

Last edited by Scimmia (2024-02-14 20:21:56)

Offline

#6 2024-02-15 21:53:46

train
Member
Registered: 2007-03-17
Posts: 38

Re: [SOLVED] PKGBUILD review: python-scrolltext

Updated the PKGBUILD. Also added a log from local makepkg run.

So far, there are these issues:
- WARNING  pyproject.toml does not contain a tool.setuptools_scm section
- ERROR    listing git files failed - pretending there aren't any

Any suggestions for those?

Offline

#7 2024-02-15 23:31:52

loqs
Member
Registered: 2014-03-06
Posts: 17,488

Re: [SOLVED] PKGBUILD review: python-scrolltext

I can not reproduce the issue in a clean chroot:

$ cat PKGBUILD
# Maintainer: Jim Dee Kepeler <jimdee at github dot comm>
pkgname=scrolltext
_name=${pkgname#python-}
pkgver=0.0.6
pkgrel=1
pkgdesc="Simple scrolltext terminal application"
arch=('any')
url="https://github.com/jimdeekepler/python-scrolltext"
license=('GPL-3.0-or-later')
depends=('python')
makedepends=('python-build' 'python-installer' 'python-setuptools' 'python-wheel')
source=("https://files.pythonhosted.org/packages/source/${_name::1}/$_name/$_name-$pkgver.tar.gz")
sha256sums=('a2c13abf8ed3d9198458dfcb1f10244b3749ef7420edae800f4e88963e1faac2')

build() {
  cd "$_name-$pkgver"
  python -m build --wheel --no-isolation
}

package() {
  cd "$_name-$pkgver"
  python -m installer --destdir="$pkgdir" dist/*.whl
}
$ pkgctl build
==> Updating pacman database cache
:: Synchronizing package databases...
 core downloading...
 extra downloading...
 multilib downloading...
==> Building scrolltext
  ->   repo: extra
  ->   arch: x86_64
  -> worker: builduser-0
==> Building scrolltext for [extra] (x86_64)
:: Synchronizing package databases...
 core downloading...
 extra downloading...
:: Starting full system upgrade...
 there is nothing to do
==> Building in chroot for [extra] (x86_64)...
==> Synchronizing chroot copy [/var/lib/archbuild/extra-x86_64/root] -> [builduser-0]...done
==> Making package: scrolltext 0.0.6-1 (Thu Feb 15 23:23:41 2024)
==> Retrieving sources...
  -> Downloading scrolltext-0.0.6.tar.gz...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 16859  100 16859    0     0   112k      0 --:--:-- --:--:-- --:--:--  112k
==> Validating source files with sha256sums...
    scrolltext-0.0.6.tar.gz ... Passed
==> Making package: scrolltext 0.0.6-1 (Thu Feb 15 23:23:44 2024)
==> Checking runtime dependencies...
==> Installing missing dependencies...
resolving dependencies...
looking for conflicting packages...

Package (2)  New Version  Net Change

core/libnsl  2.0.1-1        0.07 MiB
core/python  3.11.7-1      75.28 MiB

Total Installed Size:  75.35 MiB

:: Proceed with installation? [Y/n] 
checking keyring...
checking package integrity...
loading package files...
checking for file conflicts...
:: Processing package changes...
installing libnsl...
installing python...
Optional dependencies for python
    python-setuptools: for building Python packages using tooling that is
    usually bundled with Python
    python-pip: for installing Python packages using tooling that is usually
    bundled with Python
    python-pipx: for installing Python software not packaged on Arch Linux
    sqlite: for a default database integration [installed]
    mpdecimal: for decimal
    xz: for lzma [installed]
    tk: for tkinter
==> Checking buildtime dependencies...
==> Installing missing dependencies...
resolving dependencies...
looking for conflicting packages...

Package (22)                     New Version  Net Change

extra/python-annotated-types     0.6.0-1        0.11 MiB
extra/python-autocommand         2.2.2-4        0.08 MiB
extra/python-fastjsonschema      2.19.1-1       0.30 MiB
extra/python-inflect             7.0.0-2        0.39 MiB
extra/python-jaraco.context      4.3.0-3        0.04 MiB
extra/python-jaraco.functools    4.0.0-1        0.07 MiB
extra/python-jaraco.text         3.12.0-1       0.09 MiB
extra/python-more-itertools      10.1.0-1       0.63 MiB
extra/python-ordered-set         4.1.0-4        0.07 MiB
extra/python-packaging           23.2-1         0.53 MiB
extra/python-platformdirs        4.1.0-1        0.23 MiB
extra/python-pydantic            2.6.1-1        4.88 MiB
extra/python-pydantic-core       1:2.16.2-1     5.56 MiB
extra/python-pyproject-hooks     1.0.0-5        0.09 MiB
extra/python-tomli               2.0.1-3        0.11 MiB
extra/python-trove-classifiers   2024.1.31-1    0.11 MiB
extra/python-typing_extensions   4.9.0-1        0.37 MiB
extra/python-validate-pyproject  0.13-1         0.29 MiB
extra/python-build               1.0.3-1        0.68 MiB
extra/python-installer           0.7.0-3        0.82 MiB
extra/python-setuptools          1:69.0.3-1     4.68 MiB
extra/python-wheel               0.42.0-1       0.28 MiB

Total Installed Size:  20.40 MiB

:: Proceed with installation? [Y/n] 
checking keyring...
checking package integrity...
loading package files...
checking for file conflicts...
:: Processing package changes...
installing python-packaging...
installing python-pyproject-hooks...
installing python-build...
Optional dependencies for python-build
    python-virtualenv: Use virtualenv for build isolation
installing python-installer...
installing python-more-itertools...
installing python-jaraco.functools...
installing python-jaraco.context...
installing python-autocommand...
installing python-annotated-types...
installing python-typing_extensions...
installing python-pydantic-core...
installing python-pydantic...
Optional dependencies for python-pydantic
    mypy: for type validation with mypy
    python-dotenv: for .env file support
    python-email-validator: for email validation
    python-hypothesis: for hypothesis plugin when using legacy v1
installing python-inflect...
installing python-jaraco.text...
installing python-ordered-set...
installing python-platformdirs...
installing python-tomli...
installing python-fastjsonschema...
installing python-trove-classifiers...
installing python-validate-pyproject...
installing python-setuptools...
installing python-wheel...
Optional dependencies for python-wheel
    python-keyring: for wheel.signatures
    python-xdg: for wheel.signatures
==> Retrieving sources...
  -> Found scrolltext-0.0.6.tar.gz
==> WARNING: Skipping all source file integrity checks.
==> Extracting sources...
  -> Extracting scrolltext-0.0.6.tar.gz with bsdtar
==> Starting build()...
* Getting build dependencies for wheel...
running egg_info
writing scrolltext.egg-info/PKG-INFO
writing dependency_links to scrolltext.egg-info/dependency_links.txt
writing entry points to scrolltext.egg-info/entry_points.txt
writing top-level names to scrolltext.egg-info/top_level.txt
reading manifest file 'scrolltext.egg-info/SOURCES.txt'
adding license file 'LICENSE'
writing manifest file 'scrolltext.egg-info/SOURCES.txt'
* Building wheel...
running bdist_wheel
running build
running build_py
creating build
creating build/lib
creating build/lib/scrolltext
copying scrolltext/utils.py -> build/lib/scrolltext
copying scrolltext/getchtimeout.py -> build/lib/scrolltext
copying scrolltext/cli.py -> build/lib/scrolltext
copying scrolltext/linescroller.py -> build/lib/scrolltext
copying scrolltext/__init__.py -> build/lib/scrolltext
copying scrolltext/cursestext.py -> build/lib/scrolltext
running egg_info
writing scrolltext.egg-info/PKG-INFO
writing dependency_links to scrolltext.egg-info/dependency_links.txt
writing entry points to scrolltext.egg-info/entry_points.txt
writing top-level names to scrolltext.egg-info/top_level.txt
reading manifest file 'scrolltext.egg-info/SOURCES.txt'
adding license file 'LICENSE'
writing manifest file 'scrolltext.egg-info/SOURCES.txt'
installing to build/bdist.linux-x86_64/wheel
running install
running install_lib
creating build/bdist.linux-x86_64
creating build/bdist.linux-x86_64/wheel
creating build/bdist.linux-x86_64/wheel/scrolltext
copying build/lib/scrolltext/utils.py -> build/bdist.linux-x86_64/wheel/scrolltext
copying build/lib/scrolltext/getchtimeout.py -> build/bdist.linux-x86_64/wheel/scrolltext
copying build/lib/scrolltext/cli.py -> build/bdist.linux-x86_64/wheel/scrolltext
copying build/lib/scrolltext/linescroller.py -> build/bdist.linux-x86_64/wheel/scrolltext
copying build/lib/scrolltext/__init__.py -> build/bdist.linux-x86_64/wheel/scrolltext
copying build/lib/scrolltext/cursestext.py -> build/bdist.linux-x86_64/wheel/scrolltext
running install_egg_info
Copying scrolltext.egg-info to build/bdist.linux-x86_64/wheel/scrolltext-0.0.6-py3.11.egg-info
running install_scripts
creating build/bdist.linux-x86_64/wheel/scrolltext-0.0.6.dist-info/WHEEL
creating '/build/scrolltext/src/scrolltext-0.0.6/dist/.tmp-_58ixu7h/scrolltext-0.0.6-py3-none-any.whl' and adding 'build/bdist.linux-x86_64/wheel' to it
adding 'scrolltext/__init__.py'
adding 'scrolltext/cli.py'
adding 'scrolltext/cursestext.py'
adding 'scrolltext/getchtimeout.py'
adding 'scrolltext/linescroller.py'
adding 'scrolltext/utils.py'
adding 'scrolltext-0.0.6.dist-info/LICENSE'
adding 'scrolltext-0.0.6.dist-info/METADATA'
adding 'scrolltext-0.0.6.dist-info/WHEEL'
adding 'scrolltext-0.0.6.dist-info/entry_points.txt'
adding 'scrolltext-0.0.6.dist-info/top_level.txt'
adding 'scrolltext-0.0.6.dist-info/RECORD'
removing build/bdist.linux-x86_64/wheel
Successfully built scrolltext-0.0.6-py3-none-any.whl
==> Entering fakeroot environment...
==> Starting package()...
==> Tidying install...
  -> Removing libtool files...
  -> Purging unwanted files...
  -> Removing static library files...
  -> Stripping unneeded symbols from binaries and libraries...
  -> Compressing man and info pages...
==> Checking for packaging issues...
==> Creating package "scrolltext"...
  -> Generating .PKGINFO file...
  -> Generating .BUILDINFO file...
  -> Generating .MTREE file...
  -> Compressing package...
==> Leaving fakeroot environment.
==> Finished making: scrolltext 0.0.6-1 (Thu Feb 15 23:23:46 2024)
==> Installing package scrolltext with pacman -U...
loading packages...
resolving dependencies...
looking for conflicting packages...

Package (1)  New Version  Net Change

scrolltext   0.0.6-1        0.07 MiB

Total Installed Size:  0.07 MiB

:: Proceed with installation? [Y/n] 
checking keyring...
checking package integrity...
loading package files...
checking for file conflicts...
:: Processing package changes...
installing scrolltext...
resolving dependencies...
looking for conflicting packages...

Package (7)                      New Version  Net Change

core/elfutils                    0.190-2        3.57 MiB
core/licenses                    20240206-1     1.54 MiB
extra/pyalpm                     0.10.6-5       0.20 MiB
extra/python-boolean.py          4.0-2          0.39 MiB
extra/python-license-expression  30.2.0-1       1.13 MiB
extra/python-pyelftools          0.30-1         2.13 MiB
extra/namcap                     3.5.2-1        0.98 MiB

Total Installed Size:  9.94 MiB

:: Proceed with installation? [Y/n] 
checking keyring...
checking package integrity...
loading package files...
checking for file conflicts...
:: Processing package changes...
installing elfutils...
installing licenses...
installing pyalpm...
installing python-boolean.py...
installing python-license-expression...
installing python-pyelftools...
installing namcap...
Checking PKGBUILD
PKGBUILD (scrolltext) W: Description should not contain the package name.
Checking scrolltext-0.0.6-1-any.pkg.tar.zst
scrolltext W: Description should not contain the package name.
==> Running checkpkg
error: target not found: scrolltext
==> WARNING: Skipped checkpkg due to missing repo packages
==> Generating .SRCINFO...done

Was python-setuptools-scm installed on the system when the messages were produced?

Offline

#8 2024-02-17 07:48:04

train
Member
Registered: 2007-03-17
Posts: 38

Re: [SOLVED] PKGBUILD review: python-scrolltext

Yes, python-setuptools-scm was installed. After removing it, the build does not show the forementioned issues.

Thanks to all.

Offline

Pages: 1

Board footer

Powered by FluxBB