You are not logged in.

#1 2024-02-15 16:15:34

umireon
Member
Registered: 2024-02-15
Posts: 2

PKGBUILD review: obs-ocr

Hi there,

I am a maintainer of an OBS plugin named obs-ocr and I want to add this plugin to AUR like obs-backgroundremoval (I'm also a maintainer of obs-backgroundremoval and its AUR definitions).
The PKGBUILD for obs-ocr which I have wrote is available on the following gist.

https://gist.github.com/umireon/2306ac0 … cd8314f6a4

Are there anything that should be fixed before I will register this PKGBUILD to AUR?

Thanks in advance!

Best,

Offline

#2 2024-02-16 11:25:33

Lone_Wolf
Member
From: Netherlands, Europe
Registered: 2005-10-04
Posts: 11,908

Re: PKGBUILD review: obs-ocr

cmake defaults to generating "Unix makefiles" which will be built by (gnu) make .

Incase you want to use ninja for building, you'll have to change the used generator.

see https://cmake.org/cmake/help/latest/man … ors.7.html for details about the cmake generators.


Disliking systemd intensely, but not satisfied with alternatives so focusing on taming systemd.


(A works at time B)  && (time C > time B ) ≠  (A works at time C)

Offline

#3 2024-02-16 12:18:17

loqs
Member
Registered: 2014-03-06
Posts: 17,304

Re: PKGBUILD review: obs-ocr

build() {
  cmake -B build -S $_source-source -DCMAKE_INSTALL_PREFIX='/usr' -DCMAKE_BUILD_TYPE=Release -DENABLE_FRONTEND_API=ON -DENABLE_QT=ON -DUSE_SYSTEM_OPENCV=ON -DUSE_SYSTEM_TESSERACT=ON
  cmake --build build
}

package() {
    DESTDIR="$pkgdir" cmake --install build
}

Reduces uses of $_source-source by one and makes cmake aware of the prefix during build().  Please see CMake_package_guidelines#Template.

Last edited by loqs (2024-02-16 12:18:44)

Offline

#4 2024-02-18 13:16:56

umireon
Member
Registered: 2024-02-15
Posts: 2

Re: PKGBUILD review: obs-ocr

Thank you for all your feedback!

I have revised the PKGBUILD according to your recommendation. Does this new PKGBUILD look good?

https://gist.github.com/umireon/2306ac0 … cd8314f6a4

Best

Offline

Board footer

Powered by FluxBB