You are not logged in.

#1 2024-08-18 07:55:31

Sving1024
Member
Registered: 2024-06-16
Posts: 27
Website

New PKGBUILD for albert offical plugins

Hi!
I've just write a new pkgbuild for the offical plugins of albert and want to submit to aur. Here's the PKGBUILD

# Maintainer: Sving1024 <piano5432@outlook.com>
pkgname=albert-python-plugins-git
pkgver=r438.522196f
pkgrel=1
pkgdesc="albert offical python plugins"
arch=(x86_64)
url="https://github.com/albertlauncher/python"
license=('custom')
depends=('albert')
source=("${pkgname}::git+${url}.git")
sha256sums=('SKIP')

pkgver() {
    cd "$pkgname"
    printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short=7 HEAD)"
}

package() {
	mkdir -p "${pkgdir}/usr/share/albert/python/plugins/"
	cp -rf "${srcdir}/python/." "${pkgdir}/usr/share/albert/python/plugins/"
	rm -rf "${pkgdir}/usr/share/albert/python/plugins/README.md"
	rm -rf "${pkgdir}/usr/share/albert/python/plugins/CONTRIBUTING.md"
}

I am worried about if i missed something. If I really do, please point it out. That will be a great help.

Offline

#2 2024-08-19 12:04:11

Lone_Wolf
Administrator
From: Netherlands, Europe
Registered: 2005-10-04
Posts: 12,939

Re: New PKGBUILD for albert offical plugins

These appear to be python plugins, so you should list python as a dependency .

https://github.com/albertlauncher/pytho … /README.md indicates these are user plugins.
The locations it mentions to put them all start with ~ , are you sure the program will find them in /usr/share/albert/python/plugins ?


Disliking systemd intensely, but not satisfied with alternatives so focusing on taming systemd.

clean chroot building not flexible enough ?
Try clean chroot manager by graysky

Offline

#3 2024-08-19 12:43:28

Trilby
Inspector Parrot
Registered: 2011-11-29
Posts: 30,330
Website

Re: New PKGBUILD for albert offical plugins

You need to properly list the licenses - it is not a custom license.  Most of the plugins list MIT as the license, but there are also a couple BSD 2/3 licenses.  Each distinct license should be listed in the LICENSE field, and the license files should be installed with the package - although it looks like this should be reported upstream as none of the plugins actually includes an actual license (only one "archived" non-functional plugin actually includes a license).

Last edited by Trilby (2024-08-19 12:44:45)


"UNIX is simple and coherent" - Dennis Ritchie; "GNU's Not Unix" - Richard Stallman

Offline

#4 2024-08-19 14:56:04

Sving1024
Member
Registered: 2024-06-16
Posts: 27
Website

Re: New PKGBUILD for albert offical plugins

Lone_Wolf wrote:

These appear to be python plugins, so you should list python as a dependency .

https://github.com/albertlauncher/pytho … /README.md indicates these are user plugins.
The locations it mentions to put them all start with ~ , are you sure the program will find them in /usr/share/albert/python/plugins ?

Thanks for your reply.
Python is now listed as a dependency. The program do load the plugins in /usr/share/albert/python/plugins.  They metions that ~/.local/share/albert/python/plugins is the userspace equivalent of /usr/share/albert/python/plugins in the discord channel. It is reported upstream that the path should appears in readme.md.

Offline

#5 2024-08-19 15:01:24

Sving1024
Member
Registered: 2024-06-16
Posts: 27
Website

Re: New PKGBUILD for albert offical plugins

Trilby wrote:

You need to properly list the licenses - it is not a custom license.  Most of the plugins list MIT as the license, but there are also a couple BSD 2/3 licenses.  Each distinct license should be listed in the LICENSE field, and the license files should be installed with the package - although it looks like this should be reported upstream as none of the plugins actually includes an actual license (only one "archived" non-functional plugin actually includes a license).

Thank for your reply.

Now I added BSD and MIT to the license array,and the missing of license files is reported upstream.

Offline

Board footer

Powered by FluxBB