Arch Linux

Erwin Iosef

Member

Registered: 2024-05-22

Posts: 67

[SOLVED]First-time AUR package review and help

Hello people, I created my first AUR package today! It's a fork of papirus-icons but for Plasma. Took a template from papirus-icon-theme-git(Thanks yochananmarqos!) and modified it for my package, ran it through namcap for both the package and PKGBUILD with no errors, and now I'd like any advice or criticism regarding the PKGBUILD if possible. Also please check out my package if you're interested. Thank you!
Here is the package

Also any quality-of-life stuff I should know about, any automation stuff to get started with? Many thanks for your inputs.

EDIT: Is there a way I can pull only certain files/folders from git and not the whole repo? I'd like to save time for compression and git pulling if possible by pulling only the necessary icons.

Last edited by Erwin Iosef (2025-01-17 12:23:44)

Scimmia

Fellow

Registered: 2012-09-01

Posts: 12,323

Re: [SOLVED]First-time AUR package review and help

I really wish you had posted before uploading to the AUR, you made one error that won't be so easy to fix. By having "pkgbase=papirus-icon-theme-plasma-fork", you are using the wrong repo and taking the release namespace for a -git package.
Next, please read https://wiki.archlinux.org/title/VCS_package_guidelines
Those optdepends make no sense. An icon theme can't make use of them.
"depends=('gtk-update-icon-cache')" hasn't been needed for many years now. This was a thing when install scripts were used instead of hooks.
"options+=(!strip)" makes no sense on an icon theme, or on an "arch=('any')" package in general. There's no symbols to be stripped.
"echo "POSTINSTALL: Remember to clean your sources to free space!"" This isn't the PKGBUILD's responsibility, and is a bad idea for a VCS package anyway. You'd have to redownload everything every update if you do that.

Head_on_a_Stick

Member

From: The Wirral

Registered: 2014-02-20

Posts: 8,738

Website

Re: [SOLVED]First-time AUR package review and help

For git packages you need to set pkgver with a function: https://wiki.archlinux.org/title/VCS_pa … elines#Git

There's no need to define pkgbase if you're only making a single (non-split) package, same goes for the prepare_$pkgname() function — that should be a plain prepare() section.

The optdepends should go before the packaging functions if this is just a single package.

---

Para todos todo, para nosotros nada

Erwin Iosef

Member

Registered: 2024-05-22

Posts: 67

Re: [SOLVED]First-time AUR package review and help

I really wish you had posted before uploading to the AUR, you made one error that won't be so easy to fix. By having "pkgbase=papirus-icon-theme-plasma-fork", you are using the wrong repo and taking the release namespace for a -git package.

You're right as I discovered a slew of faults in the pkgbuild and I'm working to resolve them, it was hasty of me I admit, I removed the pkgbase section as Head_on_a_Stick said it wasn't needed. I hope that fixes it. EDIT: It didn't.

Right now, I'm focusing on making the pkgbuild usable as it conflicts with papirus-icon-theme from the official repo but I'm having trouble trying to tell pacman to replace/remove the latter package before installing, I could use some needed help on this.

echo "POSTINSTALL: Remember to clean your sources to free space!"" This isn't the PKGBUILD's responsibility, and is a bad idea for a VCS package anyway. You'd have to redownload everything every update if you do that.

Right and I removed the specific line.
The dependency is present in the official repo and the AUR one I copied the PKGBUILD from though.

Last edited by Erwin Iosef (2025-01-14 16:21:34)

Erwin Iosef

Member

Registered: 2024-05-22

Posts: 67

Re: [SOLVED]First-time AUR package review and help

I just realized my blunder involving the pkgbase. Should I delete the package and start with a new one?

Scimmia

Fellow

Registered: 2012-09-01

Posts: 12,323

Re: [SOLVED]First-time AUR package review and help

That is probably the simplest way to deal with it.

Erwin Iosef

Member

Registered: 2024-05-22

Posts: 67

Re: [SOLVED]First-time AUR package review and help

Before I do can you please take a look at the PKGBUILD(I just updated it) again and tell me if there's any more problems remaining to happen(apart from the depends and opts, I'll deal with them)? Thank you so much for your inputs, you've been very helpful and I appreciate them.

Last edited by Erwin Iosef (2025-01-14 16:46:02)

Erwin Iosef

Member

Registered: 2024-05-22

Posts: 67

Re: [SOLVED]First-time AUR package review and help

Finally I got it fixed. It's here now https://aur.archlinux.org/packages/papi … a-fork-git with successful install. With that finished my remaining questions is, is there anyway I could specifically pull certain parts of a git repo to conserve space or is there no way around it?

Head_on_a_Stick

Member

From: The Wirral

Registered: 2014-02-20

Posts: 8,738

Website

Re: [SOLVED]First-time AUR package review and help

The pkgver() function is still missing. It is required for -git packages. Please actually read the link I supplied in my last post.

---

Para todos todo, para nosotros nada

Erwin Iosef

Member

Registered: 2024-05-22

Posts: 67

Re: [SOLVED]First-time AUR package review and help

The pkgver() function is still missing. It is required for -git packages. Please actually read the link I supplied in my last post.

I did read it and I'm sorry I didn't reply, I planned on figuring it out later. I spent all my time on fixing the package install but I'll look into the versioning soon when I have time, any more advice/info you can offer? Thank you so much as well!

Head_on_a_Stick

Member

From: The Wirral

Registered: 2014-02-20

Posts: 8,738

Website

Re: [SOLVED]First-time AUR package review and help

any more advice/info you can offer?

Don't publish packages until you're sure they are good quality. I would have thought the point of opening a thread here is to ensure the package is of good quality and that being the case you really should have waited before pushing it (IMO).

---

Para todos todo, para nosotros nada

Erwin Iosef

Member

Registered: 2024-05-22

Posts: 67

Re: [SOLVED]First-time AUR package review and help

any more advice/info you can offer?

Don't publish packages until you're sure they are good quality. I would have thought the point of opening a thread here is to ensure the package is of good quality and that being the case you really should have waited before pushing it (IMO).

Good point and I agree, I just wanted an excuse to use the AUR and learn things. And btw I added the pkgver(), maybe you can check the package out now when you're interested
Thanks so much for your advice. Marking as solved now.

Head_on_a_Stick

Member

From: The Wirral

Registered: 2014-02-20

Posts: 8,738

Website

Re: [SOLVED]First-time AUR package review and help

Your pkgver() looks fine to me

---

Para todos todo, para nosotros nada