Arch Linux

SleepingGiant08

Member

From: Ellicott City, MD USA

Registered: 2007-01-10

Posts: 124

dwm bottom stack patch and upgrade

I am sure this is an easy question, but I have no clue. I am trying to apply the bottom-stack patch to dwm. I issue:

patch -p1 < dwm-3.5-bstack.diff

and get this:

missing header for unified diff at line 3 of patch
can't find file to patch at input line 3
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|--- /usr/local/src/dwm/dwm-3.5-virgin/client.c    2007-02-14 09:52:44.000000000 -0500
|+++ client.c    2007-02-14 10:06:52.000000000 -0500
--------------------------
File to patch:

I am using dwm 3.6.1 if that matters..... Also, how do I upgrade to dwm 3.7? Just copy my config.h and config.mk?

Thanks,
Julian

Last edited by SleepingGiant08 (2007-02-26 19:56:12)

---

Registered Linux User #439761

smoon

Member

Registered: 2005-08-22

Posts: 468

Website

Re: dwm bottom stack patch and upgrade

Try

patch -p1 < dwm-3.5-bstack.diff

Note the less than sign (<).

SleepingGiant08

Member

From: Ellicott City, MD USA

Registered: 2007-01-10

Posts: 124

Re: dwm bottom stack patch and upgrade

Yeah sorry I did that...edited first post.

---

Registered Linux User #439761

phrakture

Arch Overlord

From: behind you

Registered: 2003-10-29

Posts: 7,879

Website

Re: dwm bottom stack patch and upgrade

you sure -p1 is in order? try -p0

---

http://phraktured.net

smoon

Member

Registered: 2005-08-22

Posts: 468

Website

Re: dwm bottom stack patch and upgrade

Yep. Actually, if I had read the error message of your post I should've noticed that this is not the problem.

Maybe adjusting the value for -p will help, but I guess the problem is that the patch is for an older version of dwm.

SleepingGiant08

Member

From: Ellicott City, MD USA

Registered: 2007-01-10

Posts: 124

Re: dwm bottom stack patch and upgrade

patch -p0 did not work, still get the same error. Maybe its the version....
does this matter???

/usr/local/src/dwm/dwm-3.5-virgin/client.c

Should I change to my location?

---

Registered Linux User #439761

phrakture

Arch Overlord

From: behind you

Registered: 2003-10-29

Posts: 7,879

Website

Re: dwm bottom stack patch and upgrade

No.  That's what the -p argument does.  It strips path information.

For instance, if the patch wants to touch file "foo/bar/x" and you have "bar/x", -p1 will strip "foo" from the path to make it work... -p0 strips nothing, -p2 would strip both "foo" and "bar".

---

http://phraktured.net

codemac

Member

From: Cliche Tech Place

Registered: 2005-05-13

Posts: 794

Website

Re: dwm bottom stack patch and upgrade

No seriously, learn about mercurial's quilt interface.

It'll handle this exact type of situation gracefully inside of the vcs that arg uses for dwm.

---

http://codemac.net

Stalwart

Member

From: Latvia, Riga

Registered: 2005-10-18

Posts: 445

Website

Re: dwm bottom stack patch and upgrade

You can't apply 3.5 patches to any newer versions - code was refactored. Read mailing list for details

P.S. I'm still on 3.5

---

IRC: Stalwart @ FreeNode
Skype ID: thestalwart
WeeChat-devel nightly packages for i686

SleepingGiant08

Member

From: Ellicott City, MD USA

Registered: 2007-01-10

Posts: 124

Re: dwm bottom stack patch and upgrade

You can't apply 3.5 patches to any newer versions - code was refactored. Read mailing list for details

P.S. I'm still on 3.5

O well.... Thanks for all the help anyways guys

---

Registered Linux User #439761

skymt

Member

Registered: 2006-11-27

Posts: 443

Re: dwm bottom stack patch and upgrade

The bottom stack patch has been updated for 3.7 now, it just hasn't hit the wiki yet.

finferflu

Forum Fellow

From: Manchester, UK

Registered: 2007-06-21

Posts: 1,899

Website

Re: dwm bottom stack patch and upgrade

Ok, let me bring this up again.
I'm on dwm 4.4.1 trying to apply a patch, but I have no clue about what this dwm-modified directory is.
I quote from the dwm official website:

cd modified-dwm-directory/..
diff -up original-dwm-directory modified-dwm-directory > dwm-X.Y-yourpatchname.diff

where X.Y is a dwm tag name or version number.

Now, what I have done is creating a new directory, and then trying to execute those commands indicated in the howto, but I don't get any result (no patch.diff is generated - I guess that's what it's outh to happen), with any patch... I have also tried to execute the following commands indicated in the howto (obviously with the right variables):

cd dwm-directory
patch -p1 < path/to/patch.diff

but I get this error:

patch: **** Only garbage was found in the patch input.

Could anyone kindly help me, since I'm very new to patching?

Thanks

Last edited by finferflu (2007-08-28 17:47:26)

---

Have you Syued today?
Free music for free people! | Earthlings

"Perfection is achieved, not when there is nothing more to add, but when there is nothing left to take away." -- A. de Saint-Exupery

shining

Pacman Developer

Registered: 2006-05-10

Posts: 2,043

Re: dwm bottom stack patch and upgrade

Ok, let me bring this up again.
I'm on dwm 4.4.1 trying to apply a patch, but I have no clue about what this dwm-modified directory is.
I quote from the dwm official website:

cd modified-dwm-directory/..
diff -up original-dwm-directory modified-dwm-directory > dwm-X.Y-yourpatchname.diff

where X.Y is a dwm tag name or version number.

Now, what I have done is creating a new directory, and then trying to execute those commands indicated in the howto, but I don't get any result (no patch.diff is generated - I guess that's what it's outh to happen), with any patch... I have also tried to execute the following commands indicated in the howto (obviously with the right variables):

The modified directory is the one _you_ modified. These instructions are for creating a patch ...

cd dwm-directory
patch -p1 < path/to/patch.diff

but I get this error:

patch: **** Only garbage was found in the patch input.

Could anyone kindly help me, since I'm very new to patching?

Thanks

Then get the patch correctly.

---

pacman roulette : pacman -S $(pacman -Slq | LANG=C sort -R | head -n $((RANDOM % 10)))

finferflu

Forum Fellow

From: Manchester, UK

Registered: 2007-06-21

Posts: 1,899

Website

Re: dwm bottom stack patch and upgrade

Thanks shining, it's a bit clearer now, but not enough for me: so, I take one of those patches from the website, like for example this one: dwm-4.4-bstack.diff and what do I do with it in order to create the patch?

As I said, I have never patched anything, so creating a patch is even a step further for me...

Thanks a lot

---

Have you Syued today?
Free music for free people! | Earthlings

"Perfection is achieved, not when there is nothing more to add, but when there is nothing left to take away." -- A. de Saint-Exupery

shining

Pacman Developer

Registered: 2006-05-10

Posts: 2,043

Re: dwm bottom stack patch and upgrade

Thanks shining, it's a bit clearer now, but not enough for me: so, I take one of those patches from the website, like for example this one: dwm-4.4-bstack.diff and what do I do with it in order to create the patch?

Why would you want to create a patch... The author of dwm-4.4-bstack.diff already did it for you.
Just follow the instructions for applying a patch, and that's it.

Because dwm is customized through editing its source code, it's pointless to make binary packages of it. This keeps its userbase small and elitist. No novices asking stupid questions.

Nice dream.

---

pacman roulette : pacman -S $(pacman -Slq | LANG=C sort -R | head -n $((RANDOM % 10)))

finferflu

Forum Fellow

From: Manchester, UK

Registered: 2007-06-21

Posts: 1,899

Website

Re: dwm bottom stack patch and upgrade

Ok, I'm very sorry, I really didn't get it. But that's how you start learning, by being ashamed in public places

However I now realize that most of the patches are not working with the new version of dwm (4.4.1), I guess I'll just have to wait...

Thanks, and sorry again for the lame questions...

---

Have you Syued today?
Free music for free people! | Earthlings

"Perfection is achieved, not when there is nothing more to add, but when there is nothing left to take away." -- A. de Saint-Exupery

iphitus

Forum Fellow

From: Melbourne, Australia

Registered: 2004-10-09

Posts: 4,927

Re: dwm bottom stack patch and upgrade

Ok, I'm very sorry, I really didn't get it. But that's how you start learning, by being ashamed in public places

However I now realize that most of the patches are not working with the new version of dwm (4.4.1), I guess I'll just have to wait...

Thanks, and sorry again for the lame questions...

If you get that error about garbage, you've usually messed up the patch in some way, often by copy-pasting. If you can, get the raw email, and cut the mail from around the patch.

James

finferflu

Forum Fellow

From: Manchester, UK

Registered: 2007-06-21

Posts: 1,899

Website

Re: dwm bottom stack patch and upgrade

Thanks iphitus, however I have merely downloaded them, right clicking on the link and selecting "save link as". I didn't get them from the mailing list, but from the website: http://www.suckless.org/wiki/dwm/patches

---

Have you Syued today?
Free music for free people! | Earthlings

"Perfection is achieved, not when there is nothing more to add, but when there is nothing left to take away." -- A. de Saint-Exupery

shining

Pacman Developer

Registered: 2006-05-10

Posts: 2,043

Re: dwm bottom stack patch and upgrade

Thanks iphitus, however I have merely downloaded them, right clicking on the link and selecting "save link as". I didn't get them from the mailing list, but from the website: http://www.suckless.org/wiki/dwm/patches

Not sure what you did originally for getting this error, but you probably messed up something
But after that, you got it working right, it's just that some parts were rejected because not all patches are synced to 4.4.1 , right?
If so, either fix them yourself, or just wait.

Or you could also have a look at this :
http://www.suckless.org/pipermail/dwm/2 … 03367.html

---

pacman roulette : pacman -S $(pacman -Slq | LANG=C sort -R | head -n $((RANDOM % 10)))

finferflu

Forum Fellow

From: Manchester, UK

Registered: 2007-06-21

Posts: 1,899

Website

Re: dwm bottom stack patch and upgrade

What I did was using the diff file provided on the website and use the instructions:

cd dwm-directory
patch -p1 < path/to/patch.diff

However, today I have found an upgraded patch I was looking forward to install, and everything finally worked

As for that patched package, obviously I failed to install it. I supposed the install procedure would have been the same (there are no different build instructions), so I have replaced the package in the PKGBUILD with the patched one, but the build failed on some undefined value on a file (I accidentally didn't copy the error message). But I did not need all those patches (especially the fibonacci one), so for the time being I'm fine like this. Thanks a lot for your kind support, despite my lame questions

---

Have you Syued today?
Free music for free people! | Earthlings

"Perfection is achieved, not when there is nothing more to add, but when there is nothing left to take away." -- A. de Saint-Exupery

shining

Pacman Developer

Registered: 2006-05-10

Posts: 2,043

Re: dwm bottom stack patch and upgrade

As for that patched package, obviously I failed to install it. I supposed the install procedure would have been the same (there are no different build instructions), so I have replaced the package in the PKGBUILD with the patched one, but the build failed on some undefined value on a file (I accidentally didn't copy the error message). But I did not need all those patches (especially the fibonacci one), so for the time being I'm fine like this. Thanks a lot for your kind support, despite my lame questions

AFAIK fibonacci is just a different layout, so you don't have to use it, it shouldn't harm in any way.
About the errors, maybe it's your config.h which isn't in sync with the added patches. Try with the default config.h providen with this tarball, if there is one.

But well, if you finally managed to apply what you wanted, it's alright.

---

pacman roulette : pacman -S $(pacman -Slq | LANG=C sort -R | head -n $((RANDOM % 10)))

upsidaisium

Member

From: Vietnam

Registered: 2006-09-16

Posts: 263

Website

Re: dwm bottom stack patch and upgrade

fibonacci is two differnt layouts: spiral, and dwindle.  i think they're great.

---

I've seen young people waste their time reading books about sensitive vampires. It's kinda sad. But you say it's not the end of the world... Well, maybe it is!

F

Member

Registered: 2006-10-09

Posts: 322

Re: dwm bottom stack patch and upgrade

fibonacci is two differnt layouts: spiral, and dwindle.  i think they're great.

bumping an old thread.

has anyone gotten the fibonacci patches working with dwm-4.5?
The patches say they're for 4.4.1.

keks

Member

Registered: 2007-07-11

Posts: 42

Re: dwm bottom stack patch and upgrade

i don't get the bottom stack patch to work either

shining

Pacman Developer

Registered: 2006-05-10

Posts: 2,043

Re: dwm bottom stack patch and upgrade

Afaik, fibonacci hasn't been updated for dwm >= 4.5 .
But bottom stack was : http://www.suckless.org/wiki/dwm/patches/bottom_stack

Edit : for questions that specific, it's probably a better idea to use irc (#dwm on oftc) or mailing list : http://www.suckless.org/cgi-bin/mailman/listinfo/dwm

Last edited by shining (2007-10-11 14:27:17)

---

pacman roulette : pacman -S $(pacman -Slq | LANG=C sort -R | head -n $((RANDOM % 10)))