Arch Linux

raca

Member

Registered: 2007-06-26

Posts: 11

My new AUR package, please review it

My first package

I created a package for paint.mono a paint.net port to mono and I would like some feedback on it
The link to the package: http://aur.archlinux.org/packages.php?ID=17363

paint.mono isn't stable so don't mind the crashes...

Last edited by raca (2008-06-06 23:27:19)

Allan

Pacman

From: Brisbane, AU

Registered: 2007-06-09

Posts: 11,398

Website

Re: My new AUR package, please review it

In general it is a good first PKGBUILD.  Here is a few quick comments:

- Licenses: MIT is not a standard license so you need to install a copy of it into /usr/share/licenses/${progname}/.  Run "pacman -Ql licenses" to see what licenses are installed as standard.  You should also use "CCPL:cc-by-nd" to match the license package too

- Empty fields: remove groups=(), repaces=() etc.

- Long lines:  you can split those long install lines over two lines.

- Install: you don't really need the echo line there

- Desktop file:  use destop-file-validate (from desktop-file-utils) to check this.

---

PGP Key: F99FFE0FEAE999BD

raca

Member

Registered: 2007-06-26

Posts: 11

Re: My new AUR package, please review it

Thanks for the input

-Changed the license to custom and put the License that is in the sources there.
-Removed the empty fields.
-Split the long lines.
-Removed the echo lines
-Improved the desktop file.

package updated

Last edited by raca (2008-06-07 10:43:35)