Arch Linux

leo2501

Member

From: Buenos Aires, Argentina

Registered: 2007-07-07

Posts: 658

dwm. add tileh patch to PKGBUILD

hi! i'm trying to add this horizontal tiling patch http://herbst.homeunix.org/~jceb/dwm/5. … tileh.diff to my dwm PKGBUILD and it compiles ok, but when add

static Layout layouts[] = {
        /* symbol     arrange function */
        { "[]|",      tile }, /* first entry is default */
        { "[]=",      tileh },          /* <-------- patch */
        { "><>",      NULL }, /* no layout function means floating behavior */

to my config.h file it exits with this output:

[aleyscha@aleyscha 24 dwm]$ makepkg -f
==> Making package: dwm 5.0.1-1  (Sat Jun 28 08:48:06 PDT 2008)
==> Checking Runtime Dependencies...
==> Checking Buildtime Dependencies...
==> Retrieving Sources...
  -> Found dwm-5.0.1.tar.gz in build dir
  -> Found dwm-5.0.1-tileh.diff in build dir
  -> Found config.h in build dir
==> WARNING: Integrity checks (md5) are missing or incomplete.
==> Extracting Sources...
  -> bsdtar -x -f dwm-5.0.1.tar.gz
==> Removing existing pkg/ directory...
==> Entering fakeroot environment...
==> Starting build()...
patching file config.def.h
patching file tileh.c
dwm build options:
CFLAGS   = -std=c99 -pedantic -Wall -Os -I. -I/usr/include -I/usr/include/X11 -DVERSION="5.0.1" -DXINERAMA
LDFLAGS  = -s -L/usr/lib -lc -L/usr/lib/X11 -lX11 -L/usr/lib/X11 -lXinerama
CC       = cc
CC dwm.c
In file included from dwm.c:241:
config.h:42: error: 'tileh' undeclared here (not in a function)
make: *** [dwm.o] Error 1
==> ERROR: Build Failed.
    Aborting...

My PKGBUILD:

# $Id: PKGBUILD,v 1.14 2008/04/07 16:50:08 sergej Exp $
# Maintainer: Sergej Pupykin <sergej@aur.archlinux.org>
# Contributor: Dag Odenhall <dag.odenhall@gmail.com>
# Contributor: Grigorios Bouzakis <grbzks@gmail.com>

pkgname=dwm
pkgver=5.0.1
pkgrel=1
pkgdesc="A dynamic window manager for X"
url="http://www.suckless.org/wiki/dwm"
arch=('i686' 'x86_64')
license=('MIT')
depends=('libx11')
install=dwm.install
source=(http://www.suckless.org/download/$pkgname-$pkgver.tar.gz \
        dwm-5.0.1-tileh.diff config.h)

md5sums=('27d91d886c9ba1aad4b09178e2653ee0')

build() {
  cd $startdir/src/$pkgname-$pkgver

  patch -p1 < ../dwm-5.0.1-tileh.diff || return 1
  cp ../config.h .

  make X11INC=/usr/include/X11 X11LIB=/usr/lib/X11 || return 1
  make PREFIX=/usr DESTDIR=$startdir/pkg install || return 1

  install -m644 -D LICENSE $startdir/pkg/usr/share/licenses/$pkgname/LICENSE && \
  install -m644 -D README $startdir/pkg/usr/share/doc/$pkgname/README
}

Thank you all for read!

Last edited by leo2501 (2008-06-28 11:50:44)

---

Perfection is achieved, not when there is nothing more to add, but when there is nothing left to take away.
-- Antoine de Saint-Exupery

dolby

Member

From: 1992

Registered: 2006-08-08

Posts: 1,581

Re: dwm. add tileh patch to PKGBUILD

you should add an include #tile h or similar line. read on the dwm how to apply patches to the original source

---

There shouldn't be any reason to learn more editor types than emacs or vi -- mg (1)
[You learn that sarcasm does not often work well in international forums.  That is why we avoid it. -- ewaller (arch linux forum moderator)

sniffles

Member

Registered: 2008-01-23

Posts: 275

Re: dwm. add tileh patch to PKGBUILD

Add this to the beginning of your config.h file:

#include "tileh.c"

Just read the patch

Last edited by sniffles (2008-06-28 12:20:06)

leo2501

Member

From: Buenos Aires, Argentina

Registered: 2007-07-07

Posts: 658

Re: dwm. add tileh patch to PKGBUILD

lol i forget to include it in the config.h that's right but when i include it i have another error

==> Starting build()...
patching file config.def.h
patching file tileh.c
dwm build options:
CFLAGS   = -std=c99 -pedantic -Wall -Os -I. -I/usr/include -I/usr/include/X11 -DVERSION="5.0.1" -DXINERAMA
LDFLAGS  = -s -L/usr/lib -lc -L/usr/lib/X11 -lX11 -L/usr/lib/X11 -lXinerama
CC       = cc
CC dwm.c
In file included from config.h:1,
                 from dwm.c:241:
tileh.c: In function 'tileh':
tileh.c:13: error: 'mfact' undeclared (first use in this function)
tileh.c:13: error: (Each undeclared identifier is reported only once
tileh.c:13: error: for each function it appears in.)
tileh.c:14: error: 'resizehints' undeclared (first use in this function)
make: *** [dwm.o] Error 1
==> ERROR: Build Failed.
    Aborting...

im gonna ask in the dwm mailing list, sorry, i must start asking there now i think

---

Perfection is achieved, not when there is nothing more to add, but when there is nothing left to take away.
-- Antoine de Saint-Exupery

sniffles

Member

Registered: 2008-01-23

Posts: 275

Re: dwm. add tileh patch to PKGBUILD

No need. Find the following lines in your config.h:

 static float mfact      = 0.55;
 static Bool resizehints = True; /* False means respect size hints in tiled resizals */

"Move them" above the line which says:

#include "tileh.c"

My bad for not paying attention.

leo2501

Member

From: Buenos Aires, Argentina

Registered: 2007-07-07

Posts: 658

Re: dwm. add tileh patch to PKGBUILD

ho thankyou sniffles! now it compiles great!

lol i just realize that now the horizontal and vertial are vertical, like no change was made, strange

---

Perfection is achieved, not when there is nothing more to add, but when there is nothing left to take away.
-- Antoine de Saint-Exupery