Arch Linux

skottish

Forum Fellow

From: Here

Registered: 2006-06-16

Posts: 7,942

Request help on "malformed patch at line..." errors [SOLVED]

FFmpeg from subversion is broken again. [NOT TRUE ANYMORE] And this site had a patch that even mentioned Arch:

http://archives.free.net.ph/message/200 … fmpeg-user

Fine, I grabbed the patch, got it set up to patch configure in the FFmpeg directory of my build script, and I kept getting a "malformed patch at line 5 check_cflags -Wwrite-strings"

The patch (I added the 'ffmpeg' to conform to my build script)

===================================================================
--- ffmpeg/configure (revision 14800)
+++ ffmpeg/configure (working copy)
@@ -1852,6 +1852,9 @@
check_cflags -Wwrite-strings
check_cflags -Wtype-limits
enabled extra_warnings && check_cflags -Winline
+check_cflags -std=c99
+check_cflags -fasm
+check_cflags -D_BSD_SOURCE

# add some linker flags
check_ldflags -Wl,--warn-common

What are these errors from? I know that it was patching the right file, as well as I know that this code is good (from my other nasty but functional hack of the day).

Last edited by skottish (2008-08-25 18:23:02)

Snowman

Developer/Forum Fellow

From: Montreal, Canada

Registered: 2004-08-20

Posts: 5,212

Re: Request help on "malformed patch at line..." errors [SOLVED]

You need to add a space in front of the line. Same for the others except the ones beginning with + and the comment.

skottish

Forum Fellow

From: Here

Registered: 2006-06-16

Posts: 7,942

Re: Request help on "malformed patch at line..." errors [SOLVED]

You need to add a space in front of the line. Same for the others except the ones beginning with + and the comment.

Thanks Snowman. As usual your help was right on.

--EDIT--

Working patch:

===================================================================
--- ffmpeg/configure (revision 14800)
+++ ffmpeg/configure (working copy)
@@ -1852,6 +1852,9 @@
 check_cflags -Wwrite-strings
 check_cflags -Wtype-limits
 enabled extra_warnings && check_cflags -Winline
+check_cflags -std=c99
+check_cflags -fasm
+check_cflags -D_BSD_SOURCE

# add some linker flags
 check_ldflags -Wl,--warn-common

Last edited by skottish (2008-08-24 15:28:12)

Snowman

Developer/Forum Fellow

From: Montreal, Canada

Registered: 2004-08-20

Posts: 5,212

Re: Request help on "malformed patch at line..." errors [SOLVED]

Next time something like this happen, you can just recreate the patch yourself, especially if it's a small one. That's what I did BTW .

skottish

Forum Fellow

From: Here

Registered: 2006-06-16

Posts: 7,942

Re: Request help on "malformed patch at line..." errors [SOLVED]

Next time something like this happen, you can just recreate the patch yourself, especially if it's a small one. That's what I did BTW .

Yeah, but I'm stoopid and I smell like under-ripe bananas.

--EDIT--

The patch is unnecessary now. The fix was added upstream.

Last edited by skottish (2008-08-25 17:56:18)