Please Give Some Feedback

haxit · 2008-10-08 22:27:38

This is my first PKGBUILD. I know i didn't describe it, and its already in aur, but I am just practicing for requests. Please give me feedback:

pkgname=tint
pkgver=0.6
pkgrel=0
pkgdesc="Lightweight, taskbar for Openbox."
arch=('i686' 'x86_64')
url="http://www.foo.org"
license=('GPL')
source=(http://tint2.googlecode.com/files/$pkgname-$pkgver.$pkgrel.tar.gz)

build() {
  cd ${srcdir}/$pkgname/src
  make || return 1
  make prefix=${pkgdir}/usr install
  cp ../tintrc1 ~
  mv ~/tintrc1 ~/.tintrc
}

Last edited by haxit (2008-10-08 22:31:42)

pressh · 2008-10-08 22:34:09

A few quick comments:

- you can't create files in ~
- use install instead of cp if possible (so you can set correct permission/ownership)

- take a look here: http://wiki.archlinux.org/index.php/Arc … _Standards

[edit] you had changed the code during the time I was writing this message -> changed my comments a bit

Last edited by pressh (2008-10-08 22:35:43)

haxit · 2008-10-09 20:58:39

pressh wrote:

A few quick comments:
- you can't create files in ~
- use install instead of cp if possible (so you can set correct permission/ownership)
- take a look here: http://wiki.archlinux.org/index.php/Arc … _Standards
[edit] you had changed the code during the time I was writing this message -> changed my comments a bit

Thank you very much

Stythys · 2008-10-09 20:59:47

yes as pressh said you shouldn't be modifying anything outside of the build directory

Arch Linux

#1 2008-10-08 22:27:38

Please Give Some Feedback

#2 2008-10-08 22:34:09

Re: Please Give Some Feedback

#3 2008-10-09 20:58:39

Re: Please Give Some Feedback

#4 2008-10-09 20:59:47

Re: Please Give Some Feedback

Board footer