Arch Linux

[eXr]

Member

From: Vigo, Spain

Registered: 2008-06-20

Posts: 12

Website

VLC 0.9.8a integrated video patch and PKGBUILD

Hi,

maybe it's buggy, or something, but for me VLC works like before the patch without any problem. Basically this patch reactivates the "integrated video" function with the new Qt4 GUI.

First the patches, then the explanation.

Here it is the "qt4_integrated_video.patch" (diff) :

--- qt4.cpp    2008-12-07 14:46:52.000000000 +0100
+++ qt4.cpp    2008-12-07 14:47:04.000000000 +0100
@@ -213,7 +213,7 @@
 
         set_callbacks( OpenDialogs, Close );
 
-#if 0
+#if 1
     add_submodule();
         set_capability( "vout window", 50 );
         set_callbacks( WindowOpen, WindowClose );

To make the package for Arch here it is another patch (diff) for the PKGBUILD from ABS (/var/abs/extra/vlc/PKGBUILD):

--- /var/abs/extra/vlc/PKGBUILD    2008-12-06 06:04:00.000000000 +0100
+++ PKGBUILD    2008-12-07 16:16:28.000000000 +0100
@@ -22,6 +22,7 @@
 
 build() {
   cd ${srcdir}/${pkgname}-${pkgver}
+  patch modules/gui/qt4/qt4.cpp < ${startdir}/qt4_integrated_video.patch
   sed -i -e 's:#include <vlc\/vlc.h>:#include <vlc/vlc.h> \n #include <locale.h>: ' modules/misc/freetype.c
   sed -i -e 's:/usr/share/fonts/truetype/freefont/FreeSerifBold.ttf:/usr/share/fonts/TTF/VeraBd.ttf:' modules/misc/freetype.c
   [ "${CARCH}" = "i686" ] && EXTRAFEATURES="--enable-loader --enable-live555 --with-live555-tree=/usr/lib/live-media"

My way:
Copy the vlc directory from ABS to a different place ( ie: cp -r /var/abs/local/vlc /var/abs/local/ ).
Save the first patch as "qt4_integrated_video.patch" ( ie: /var/abs/local/vlc/qt4_integrated_video.patch ).
Save the second patch as "pkgbuild.patch" ( ie: /var/abs/local/vlc/pkgbuild.patch ).
Go to that directory and patch the PKGBUILD ( ie: patch PKGBUILD < pkgbuild.patch ).
Make as usually ( makepkg )

That's all. Use at your own risk. I've posted it because it could be useful for someone.

See you

---

@nachoexr

Svenstaro

Administrator

From: Germany

Registered: 2008-11-19

Posts: 388

Re: VLC 0.9.8a integrated video patch and PKGBUILD

Thanks for this, I was getting annoyed by it. Compiling your patch now. Though I wonder, is it desired behavior?

EDIT: It works, thanks a bunch

Last edited by Svenstaro (2008-12-09 23:24:56)

deltaecho

Member

From: Georgia (USA)

Registered: 2008-08-06

Posts: 185

Re: VLC 0.9.8a integrated video patch and PKGBUILD

Awesome!  I just compiled VLC with your patch and it works wonders - thanks!

---

Dylon

Svenstaro

Administrator

From: Germany

Registered: 2008-11-19

Posts: 388

Re: VLC 0.9.8a integrated video patch and PKGBUILD

Are you going to create an AUR package with this fix? If you don't want to, I will.

creslin

Member

Registered: 2008-10-04

Posts: 241

Re: VLC 0.9.8a integrated video patch and PKGBUILD

someone already did: vlc-embeddedvideo

---

ARCH|awesome3.0 powered by Pentium M 750 | 512MB DDR2-533 | Radeon X300 M
The journey is the reward.

Svenstaro

Administrator

From: Germany

Registered: 2008-11-19

Posts: 388

Re: VLC 0.9.8a integrated video patch and PKGBUILD

Oh, nice didn't see that.