Arch Linux

dmays

Member

Registered: 2007-09-17

Posts: 19

csfml-svn

Hi, I just submitted the csfml-svn PKGBUILD, but I was unable to figure out how to upload three patches to go along with it. Could a TU upload them for me? Pastebins for the patches are below.

IPAddress.patch: http://pastebin.com/fe6b6eb
SocketTCP.patch: http://pastebin.com/d7fde62d
SocketUDP.patch: http://pastebin.com/m2ecb9814

Thanks a lot

tdy

Member

From: Sacremende

Registered: 2008-12-14

Posts: 440

Re: csfml-svn

Just include them in the tarball that you upload (or use makepkg to create it automatically with `makepkg --source` in the PKGBUILD directory).

As a side note, you might want to add those headers with 'sed' instead of patches since snapshot code could change any time.  Something like this:

  sed -i '32 a\#include <cstring>' src/SFML/Network/Socket{TCP,UDP}.cpp
  sed -i '29 a\#include <cstring>' src/SFML/Network/IPAddress.cpp

You should also take a look at the /usr/share/pacman/PKGBUILD-svn.proto template.  With the way you have it written now, you'll have some issues after local updates like a dirty build dir and broken copy command.

Last edited by tdy (2008-12-29 14:57:06)

---

dots.git  +  awesome.git

dmays

Member

Registered: 2007-09-17

Posts: 19

Re: csfml-svn

Yeah, the reason I did the patches is because I've never made a patch before, and wanted to practice it. i've already reported those bugs upstream and they should be fixed sometime today.

And thanks for the second tip; I had used the fluxbox PKGBUILD on the wiki as a template and didn't notice the bug. It's been fixed.