help with my first PKBUILD

cactus · 2004-11-10 19:10:42

ok..my first packagebuild.
can you guys look over the PKGBUILD and make sure it doesn't suck?
ie. all the things are put in the correct places afterwards?

pkgname=webalizer
pkgver=2.01
pkgrel=1
pkgdesc="A fast, free web server log file analysis program"
url="http://www.mrunix.net/webalizer/"
license="GNU GPL"
depends=('gd' 'libpng' 'zlib')
makedepends=()
conflicts=()
replaces=()
backup=(etc/webalizer.conf)
install=
source=(ftp://ftp.mrunix.net/pub/webalizer/$pkgname-$pkgver-10-src.tgz)
md5sums=('9217595005aec46a505e1fb349052a8e')
                                                                                
build() {
  cd $startdir/src/$pkgname-${pkgver}-10
  ./configure --prefix=/usr --sysconfdir=/etc
  make || return 1
  mkdir -p $startdir/pkg/etc
  mkdir -p $startdir/pkg/usr/bin
  mkdir -p $startdir/pkg/usr/man/man1
  make ETCDIR=$startdir/pkg/etc prefix=$startdir/pkg/usr install
}

It compiles ok. and the package looks good.
The only thing I wonder about really now is the need to do the mkdir -p stuff.
The directories were not being created. I suppose that is makefile specific...
is that true?

also, it uses a config file called webalizer.conf.sample. The user is supposed to rename this file to exclude the .sample suffix. Does that go into a post install to rename it for the user? or should I leave it as is?

also, when you remove the package, the webalizer.conf file is left behind. (it might be looking for webalizer.conf.sample ?)

phrakture · 2004-11-10 21:21:00

yeah, looks good - you can remove the unused fields at the top too - and grab namcap from pacman and run it on the PKGBUILD file - namcap is a utility to scan PKGBUILDs and make usre they're up-to-snuff

skeeterbug · 2004-11-10 21:46:27

Just a quick opinion on the webalizer.conf.sample. I think you should just leave the sample as is and at most make a reference to it - like an echo about it or something in the post install script. I'm just kind of going off of samba which has a sample file and isn't renamed or modified by default. I don't know the generally accepted way to remove the .conf but I would assume you put something in the script, maybe save it to .pacsave if you want.

sarah31 · 2004-11-10 21:58:59

cactus wrote:

ok..my first packagebuild.
can you guys look over the PKGBUILD and make sure it doesn't suck?
ie. all the things are put in the correct places afterwards?
pkgname=webalizer
pkgver=2.01
pkgrel=1
pkgdesc="A fast, free web server log file analysis program"
url="http://www.mrunix.net/webalizer/"
license="GNU GPL"
depends=('gd' 'libpng' 'zlib')
makedepends=()
conflicts=()
replaces=()
backup=(etc/webalizer.conf)
install=
source=(ftp://ftp.mrunix.net/pub/webalizer/$pkgname-$pkgver-10-src.tgz)
md5sums=('9217595005aec46a505e1fb349052a8e')
                                                                                
build() {
  cd $startdir/src/$pkgname-${pkgver}-10
  ./configure --prefix=/usr --sysconfdir=/etc
  make || return 1
  mkdir -p $startdir/pkg/etc
  mkdir -p $startdir/pkg/usr/bin
  mkdir -p $startdir/pkg/usr/man/man1
  make ETCDIR=$startdir/pkg/etc prefix=$startdir/pkg/usr install
}
remove the unused lines you don't need them.

It compiles ok. and the package looks good.
The only thing I wonder about really now is the need to do the mkdir -p stuff.
The directories were not being created. I suppose that is makefile specific...
is that true?
no it is not true there are a few reasons the directories may not be created.
you could replace the "prefix" in the make install line and replace it with DESTDIR you may also be able to ditch the ETCDIR portion too. if you try this comment out the mkdir lines.
buld all this using fakeroot. (install fakeroot then build as user not as root)
likely this is an issue with the makefiles or source more than it is makepkg.
also, it uses a config file called webalizer.conf.sample. The user is supposed to rename this file to exclude the .sample suffix. Does that go into a post install to rename it for the user? or should I leave it as is?
also, when you remove the package, the webalizer.conf file is left behind. (it might be looking for webalizer.conf.sample ?)
leave this file as .sample and let the user edit it and rename it as needed. as for removing webalizer.conf, you could probably have a post_install for it but i don't know if this is wise. the file is not being removed because it is user created and not part of the package.
AKA uknowme
I am not your friend

Arch Linux

#1 2004-11-10 19:10:42

help with my first PKBUILD

#2 2004-11-10 21:21:00

Re: help with my first PKBUILD

#3 2004-11-10 21:46:27

Re: help with my first PKBUILD

#4 2004-11-10 21:58:59

Re: help with my first PKBUILD

#5 2004-11-10 22:11:04

Re: help with my first PKBUILD

#6 2004-11-11 10:25:43

Re: help with my first PKBUILD

#7 2004-11-11 21:20:51

Re: help with my first PKBUILD

Board footer