You are not logged in.

#1 2009-11-01 07:52:52

aditya_bhatt
Member
From: Ahmedabad, India
Registered: 2009-06-19
Posts: 7
Website

A (hopefully) better thumbnailer for videos in the KDE4 Desktop

Hi,

This is my first contribution/patch thingy to the KDE community.
I've hacked the code of mplayerthumbs (the plugin which generates video thumbnails) to make it more ... er... *elegant* smile
The original mplayerthumbs drew a blue strip over the video thumnail, and that too only on the left side - which seems plain ugly to me, and also probably to people who have a fetish for 'perfect desktops'. Since the original author has not made any changes to this for a long time (looks like he doesn't have enought time), i modified it to show the traditional (beautiful ?) black-white strips, and on BOTH sides of the thumbnail.

So try it out. (This will probably overwrite your old mplayerthumbs - but I dont think you'll want to go back after using this wink )
Tell me what you think of it.

So here it is : http://www.kde-apps.org/content/show.ph … ent=114655


rm /etc/rc.conf

Offline

#2 2009-11-01 14:06:38

wantilles
Member
From: Athens - Greece
Registered: 2007-03-29
Posts: 327

Re: A (hopefully) better thumbnailer for videos in the KDE4 Desktop

With all due respect, have you even tested once your code, to see if it works?

Because here, the stock (in extra) kdemultimedia-mplayerthumbnails works.

While yours does not. It does nothing (Dolphin tested).

Here is the PKGBUILD I used:

pkgname=mplayerthumbs-stripes
pkgver=1.0
pkgrel=3
lateststablever=4.3.2
arch=('i686' 'x86_64')
realname=mplayerthumbs
tarname=mplayerthumbs-stripes
sourcetarballdir=http://adslgr64.tiven.org/sources
pkgdesc='Video Files (MPlayerThumbs) - A much better version'
url='http://www.kde-apps.org/content/show.php/Mplayerthumbs-Strips?content=114655'
license=('GPL' 'LGPL' 'FDL')
depends=('kdelibs>=4.3.2' 'kdebase-runtime>=4.3.2' 'mplayer>=29776')
conflicts=('mplayerthumbs' 'kdemultimedia-mplayerthumbs')
provides=("kdemultimedia-mplayerthumbs=${lateststablever}")
makedepends=('pkgconfig' 'cmake' 'automoc4' 'kdelibs-experimental>=4.3.2' 'tunepimp' 'cdparanoia')
source=(${sourcetarballdir}/${tarname}-${pkgver}.tar.bz2
        mplayerthumbs-stripes.config)
md5sums=('2fb96f2c0494fdcb1883c7822d96bff8'
         '698c1579905135043dcdd4dbe55f2c7e')

build() {
  cd ${srcdir}
  mkdir build
  cd build
  cmake ../${pkgname} \
    -DCMAKE_BUILD_TYPE=Release \
    -DCMAKE_INSTALL_PREFIX=/usr
  make

  cd ${srcdir}/build/mplayerthumbs
  make DESTDIR=${pkgdir} install
  install -D -m644 ${srcdir}/mplayerthumbs-stripes.config ${pkgdir}/usr/share/config/mplayerthumbs
}

Offline

#3 2009-11-01 16:24:05

aditya_bhatt
Member
From: Ahmedabad, India
Registered: 2009-06-19
Posts: 7
Website

Re: A (hopefully) better thumbnailer for videos in the KDE4 Desktop

wantilles wrote:

With all due respect, have you even tested once your code, to see if it works?

Because here, the stock (in extra) kdemultimedia-mplayerthumbnails works.

While yours does not. It does nothing (Dolphin tested).

Well, my tarball is actually just the original mplayerthumbs with the images ( stripes ) modified, and a few more lines of code in a source file.
So try this : uninstall the repository version of mplayerthumbs and install the tarball from kde-look.org.
If that generates your thumbnails, then my version should too.
If it does not, then I dunno whats wrong.

Try it.
I'll check further if there IS a problem with my tarball or not, although it works fine on my computer ( see the screenshots ).

Btw, where did you find that PKGBUILD?


rm /etc/rc.conf

Offline

#4 2009-11-01 16:51:05

wantilles
Member
From: Athens - Greece
Registered: 2007-03-29
Posts: 327

Re: A (hopefully) better thumbnailer for videos in the KDE4 Desktop

aditya_bhatt wrote:

...install the tarball from kde-look.org.

I never install anything "by hand", i.e. outside of the package manager.

It messes up the system.

aditya_bhatt wrote:

Btw, where did you find that PKGBUILD?

I created it myself.

Offline

#5 2009-11-01 17:47:11

aditya_bhatt
Member
From: Ahmedabad, India
Registered: 2009-06-19
Posts: 7
Website

Re: A (hopefully) better thumbnailer for videos in the KDE4 Desktop

I never install anything "by hand", i.e. outside of the package manager.

It messes up the system.

Well, it *sometimes* messes up the system, but you really should somehow try compiling and installing that original mplayerthumbs tarball. Because it that doesnt work, then your system IS probably messed up smile

As I said, If the original works, mine should too.


rm /etc/rc.conf

Offline

#6 2009-11-01 18:06:50

wantilles
Member
From: Athens - Greece
Registered: 2007-03-29
Posts: 327

Re: A (hopefully) better thumbnailer for videos in the KDE4 Desktop

aditya_bhatt wrote:

...but you really should somehow try compiling and installing that original mplayerthumbs tarball. Because it that doesnt work, then your system IS probably messed up smile

As I said, If the original works, mine should too.

Never without a properly packaged PKGBUILD.

I will not waste more of my precious time with you and your buggy software.

Offline

#7 2009-11-01 18:56:11

aditya_bhatt
Member
From: Ahmedabad, India
Registered: 2009-06-19
Posts: 7
Website

Re: A (hopefully) better thumbnailer for videos in the KDE4 Desktop

wantilles wrote:
aditya_bhatt wrote:

...but you really should somehow try compiling and installing that original mplayerthumbs tarball. Because it that doesnt work, then your system IS probably messed up smile

As I said, If the original works, mine should too.

Never without a properly packaged PKGBUILD.

I will not waste more of my precious time with you and your buggy software.

And I will not waste my time with you who would stick to your crazy fetish for repository software rather than helping me out by doing what I recommend. Dont be such a troll. It's been one day since I've joined the arch forums and I've seen enough of your threads to prove that you are a ..... forget it. Defeats the whole purpose of my starting this thread.


rm /etc/rc.conf

Offline

#8 2009-11-01 19:24:16

flamelab
Member
From: Athens, Hellas (Greece)
Registered: 2007-12-26
Posts: 2,160

Re: A (hopefully) better thumbnailer for videos in the KDE4 Desktop

It doesn't here either sad

Offline

#9 2009-11-01 19:28:55

anteater
Member
Registered: 2009-04-26
Posts: 11

Re: A (hopefully) better thumbnailer for videos in the KDE4 Desktop

Or you could just use mplayerthumbsconfig to deactivate the stripes.

Offline

#10 2009-11-01 21:33:32

aditya_bhatt
Member
From: Ahmedabad, India
Registered: 2009-06-19
Posts: 7
Website

Re: A (hopefully) better thumbnailer for videos in the KDE4 Desktop

Ok guys, I figured out that the problem was with a conflict of the original plugin and this thing's videopreview library installation paths. Now it works, Ive uploaded the fixed version. Enjoy!

By the way, It *probably* wont conflict with the existing mplayerthumbs now. To enable thumbnails via this plugin, uncheck mplayerthumbs from the preview list and check the new entry "Video Thumbnails".

[Attention : Dont use the installation method given in the original mplayerthumbs, use the method given in the README of THIS plugin]


rm /etc/rc.conf

Offline

#11 2009-11-01 22:16:40

wantilles
Member
From: Athens - Greece
Registered: 2007-03-29
Posts: 327

Re: A (hopefully) better thumbnailer for videos in the KDE4 Desktop

aditya_bhatt wrote:

Ok guys, I figured out that the problem was with a conflict of the original plugin and this thing's videopreview library installation paths. Now it works, Ive uploaded the fixed version. Enjoy!

By the way, It *probably* wont conflict with the existing mplayerthumbs now. To enable thumbnails via this plugin, uncheck mplayerthumbs from the preview list and check the new entry "Video Thumbnails".

[Attention : Dont use the installation method given in the original mplayerthumbs, use the method given in the README of THIS plugin]

1. Now it works and it is very nice.

2. Perhaps you owe me a public apology.

3. Here is the new PKGBUILD:

pkgname=mplayerthumbs-stripes
pkgver=1.0
pkgrel=5
lateststablever=4.3.2
arch=('i686' 'x86_64')
sourcetarballdir=http://adslgr64.tiven.org/sources
pkgdesc='Video Files (MPlayerThumbs) - A much better version'
url='http://www.kde-apps.org/content/show.php/Mplayerthumbs-Strips?content=114655'
license=('GPL' 'LGPL' 'FDL')
depends=('kdelibs>=4.3.2' 'kdebase-runtime>=4.3.2' 'mplayer>=29776')
conflicts=('mplayerthumbs' 'kdemultimedia-mplayerthumbs')
provides=("kdemultimedia-mplayerthumbs=${lateststablever}")
makedepends=('pkgconfig' 'cmake' 'automoc4' 'kdelibs-experimental>=4.3.2' 'tunepimp' 'cdparanoia')
source=(${sourcetarballdir}/${pkgname}-${pkgver}.tar.bz2
        mplayerthumbs-stripes.config)
md5sums=('b1d0a7b0c6da0f7525be32b0cb0190df'
         '698c1579905135043dcdd4dbe55f2c7e')

build() {
  cd ${srcdir}
  mkdir build
  cd build
  cmake ../${pkgname} \
    -DCMAKE_BUILD_TYPE=Release \
    -DCMAKE_INSTALL_PREFIX=/usr
  make

  cd ${srcdir}/build/mplayerthumbs
  make DESTDIR=${pkgdir} install
  install -D -m644 ${srcdir}/mplayerthumbs-stripes.config ${pkgdir}/usr/share/config/mplayerthumbs
}

Offline

#12 2009-11-01 22:37:27

aditya_bhatt
Member
From: Ahmedabad, India
Registered: 2009-06-19
Posts: 7
Website

Re: A (hopefully) better thumbnailer for videos in the KDE4 Desktop

1. Now it works and it is very nice.

2. Perhaps you owe me a public apology.

Thanks, and yes,I DO owe you an apology. I'm really sorry.


rm /etc/rc.conf

Offline

#13 2009-11-07 13:24:58

axel
Member
Registered: 2007-12-10
Posts: 77

Re: A (hopefully) better thumbnailer for videos in the KDE4 Desktop

Nice work on the mplayerthumbs-stripes. It looks better than the default one.

Here is a little problem I have. The thumbnails that were created in the past using the old mplayerthumbs still appear with the blue stripe. Only the new ones appear with the two stripes. Pressing F5 doesn't help. Any idea?

Offline

#14 2009-11-07 14:22:08

wantilles
Member
From: Athens - Greece
Registered: 2007-03-29
Posts: 327

Re: A (hopefully) better thumbnailer for videos in the KDE4 Desktop

axel wrote:

Nice work on the mplayerthumbs-stripes. It looks better than the default one.

Here is a little problem I have. The thumbnails that were created in the past using the old mplayerthumbs still appear with the blue stripe. Only the new ones appear with the two stripes. Pressing F5 doesn't help. Any idea?

Run mplayerthumbsconfig and press the clear cache button.

Offline

#15 2009-11-07 16:03:31

axel
Member
Registered: 2007-12-10
Posts: 77

Re: A (hopefully) better thumbnailer for videos in the KDE4 Desktop

wantilles wrote:
axel wrote:

Nice work on the mplayerthumbs-stripes. It looks better than the default one.

Here is a little problem I have. The thumbnails that were created in the past using the old mplayerthumbs still appear with the blue stripe. Only the new ones appear with the two stripes. Pressing F5 doesn't help. Any idea?

Run mplayerthumbsconfig and press the clear cache button.

Nice, thanks!

Offline

Board footer

Powered by FluxBB