Arch Linux

jlcordeiro

Member

From: Portugal

Registered: 2009-05-23

Posts: 76

[SOLVED] Some questions about a recently submited package (cgames)

Hi there, when searching for ncurses sokoban-like games I ended up finding a great one that wasn't at the AUR yet. I submitted it (the package is named cgames) but I have some questions.

1- The source code provided by the developer has 3 games. Should I have packaged each one individually? I decided this way because they are so small that I figure nobody would have a problem in having them all even when just wanting to play one of them (you can always change the make command in the PKGBUILD if you want a single game).

2 - The original package had some compiling problems due to a function called getline (already existing in stdio.h) and I solved this problem with a sed command. Is this the proper way to do it? Should I have created some patch file or something?

3- I'm 99% sure the game works in 64bit archs, but 99 isn't 100. Can anyone try it out for me, so that I change the PKGBUILD? I know I should have tested it but I don't have the time to install a 64b arch in the next few days.

Thank you in advance

Last edited by jlcordeiro (2010-03-29 15:33:58)

Rorschach

Member

From: Ankh-Morpork

Registered: 2008-11-07

Posts: 143

Re: [SOLVED] Some questions about a recently submited package (cgames)

1 - That's fine as it is
2 - I prefer seperate patchfiles over sed-solutions, also if there are many PKGBUILDs with sed-solutions. But I would suggest doing a patch, including it in your package and at the same time submitting your patch upstream to the cgames developer
3 - sorry just 32bit machines here too

tomk

Forum Fellow

From: Ireland

Registered: 2004-07-21

Posts: 9,839

Re: [SOLVED] Some questions about a recently submited package (cgames)

3. You're only expected to test your packages on the architecture(s) that are available to you - installing Arch64 just to test your package on it would of course be welcome, but it is definitely not required.

mcmillan

Member

Registered: 2006-04-06

Posts: 737

Re: [SOLVED] Some questions about a recently submited package (cgames)

I just tested it on my 64bit and it seemed to work. The only problem I ran into was with the line saying

./configure --prefix=/usr --with-ncurses

which needed to be changed to

./configure --prefix=$pkgdir/usr --with-ncurses

That should have caused problems on 32bit too though, did compile as a non-root user?

jlcordeiro

Member

From: Portugal

Registered: 2009-05-23

Posts: 76

Re: [SOLVED] Some questions about a recently submited package (cgames)

You're right, that needs to be solved. I'll do it as soon as I have the patch ready.

Thank you all

jdarnold

Member

From: Medford MA USA

Registered: 2009-12-15

Posts: 485

Website

Re: [SOLVED] Some questions about a recently submited package (cgames)

It is a little scary to do that first AUR submission, isn't it? But thanks for the effort!

jlcordeiro

Member

From: Portugal

Registered: 2009-05-23

Posts: 76

Re: [SOLVED] Some questions about a recently submited package (cgames)

Yeap, a bit

Anyway, all done (i think)

Second release:

- Replaced sed command with a patch
- Added x64 arch
- Fixed a little bug with the configure command

Last edited by jlcordeiro (2010-03-29 15:32:42)