You are not logged in.
Pages: 1
Pre-emptive notice: I can't edit the page myself because it's locked.
The Arch Packaging Standards wiki page should be updated to include double quotation marks around all variables. There seems to be some misconception that using
${foo}
somehow prevents word-splitting in Bash... it doesn't. All variables should be double-quoted to prevent values with spaces in them from splitting words. Even if most people don't build on a path with spaces in the name, it is bad coding practice to rely on this to prevent breakage. As it stands, the following would not work as intended if the $srcdir contains a space in the path:
cd ${srcdir}
Note that the PKGBUILD prototypes included in pacman wrap variables in double quotation marks, so it seems that the wiki page is simply out-of-date.
It may be a good time to add the OCaml Package Guidelines to the page too.
Last edited by Xyne (2011-01-02 10:00:52)
My Arch Linux Stuff • Forum Etiquette • Community Ethos - Arch is not for everyone
Offline
ask Eric for rights.
Give what you have. To someone, it may be better than you dare to think.
Offline
ask Eric for rights.
ok, email sent
My Arch Linux Stuff • Forum Etiquette • Community Ethos - Arch is not for everyone
Offline
I had just updated the prototype before reading this. I've added the OCaml Package Guidelines to the page.
Offline
Thanks
My Arch Linux Stuff • Forum Etiquette • Community Ethos - Arch is not for everyone
Offline
Pages: 1